From: Leo Famulari <leo@famulari.name>
To: guix-devel@gnu.org
Subject: search-input-file vs (assoc-ref inputs)
Date: Thu, 23 Dec 2021 12:46:09 -0500 [thread overview]
Message-ID: <YcS14RRg0/RUXaNt@jasmine.lan> (raw)
I noticed that, as part of the transition to the new inputs style [0],
we are sometimes replacing code like (assoc-ref inputs "foo") with
(search-input-file inputs "/bin/foo").
I think that we should instead replace the old style with gexps that
specify which package, in order to keep the equivalent functionality.
Otherwise, we risk regressions, when the code finds a match for the
desired filename in the wrong input.
I would say that (search-input-file) is a replacement for the Guile
(which) procedure.
On the other hand, we can replace (assoc-ref inputs ...) with
(this-package-input "foo").
What do you think?
[0] https://guix.gnu.org/en/blog/2021/the-big-change/
next reply other threads:[~2021-12-23 17:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-23 17:46 Leo Famulari [this message]
2022-01-03 15:29 ` search-input-file vs (assoc-ref inputs) Ludovic Courtès
-- strict thread matches above, loose matches on Subject: below --
2022-01-07 15:34 Zhu Zihao
2022-01-08 21:10 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YcS14RRg0/RUXaNt@jasmine.lan \
--to=leo@famulari.name \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).