From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <guix-devel-bounces+larch=yhetil.org@gnu.org>
Received: from mp2 ([2001:41d0:8:6d80::])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
	by ms0.migadu.com with LMTPS
	id iBojNcRIdWHYRgAAgWs5BA
	(envelope-from <guix-devel-bounces+larch=yhetil.org@gnu.org>)
	for <larch@yhetil.org>; Sun, 24 Oct 2021 13:51:32 +0200
Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
	by mp2 with LMTPS
	id KI7XMMRIdWHgBAAAB5/wlQ
	(envelope-from <guix-devel-bounces+larch=yhetil.org@gnu.org>)
	for <larch@yhetil.org>; Sun, 24 Oct 2021 11:51:32 +0000
Received: from lists.gnu.org (lists.gnu.org [209.51.188.17])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by aspmx1.migadu.com (Postfix) with ESMTPS id 647E726FF8
	for <larch@yhetil.org>; Sun, 24 Oct 2021 13:51:32 +0200 (CEST)
Received: from localhost ([::1]:37692 helo=lists1p.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.90_1)
	(envelope-from <guix-devel-bounces+larch=yhetil.org@gnu.org>)
	id 1mec2F-00062U-HI
	for larch@yhetil.org; Sun, 24 Oct 2021 07:51:31 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:35674)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <efraim@flashner.co.il>)
 id 1mec1s-000602-O9
 for guix-devel@gnu.org; Sun, 24 Oct 2021 07:51:09 -0400
Received: from flashner.co.il ([178.62.234.194]:59294)
 by eggs.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <efraim@flashner.co.il>)
 id 1mec1n-0005wv-Uf; Sun, 24 Oct 2021 07:51:08 -0400
Received: from localhost (unknown [141.226.169.107])
 by flashner.co.il (Postfix) with ESMTPSA id 4CA094034B;
 Sun, 24 Oct 2021 11:50:30 +0000 (UTC)
Date: Sun, 24 Oct 2021 14:47:42 +0300
From: Efraim Flashner <efraim@flashner.co.il>
To: Vagrant Cascadian <vagrant@debian.org>
Subject: Re: Incentives for review
Message-ID: <YXVH3vLG/W+VpA3Y@3900XT>
Mail-Followup-To: Vagrant Cascadian <vagrant@debian.org>,
 Ludovic =?utf-8?Q?Court=C3=A8s?= <ludo@gnu.org>,
 zimoun <zimon.toutoune@gmail.com>, guix-devel@gnu.org
References: <874k9if7am.fsf@inria.fr> <86ee8hfm1k.fsf@gmail.com>
 <87sfwx896z.fsf@inria.fr> <86k0i9drh5.fsf@gmail.com>
 <87mtn56mzg.fsf_-_@inria.fr> <875ytqp8qc.fsf@yucca>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
 protocol="application/pgp-signature"; boundary="3xLhxM+EF3nyabt6"
Content-Disposition: inline
In-Reply-To: <875ytqp8qc.fsf@yucca>
X-PGP-Key-ID: 0x41AAE7DCCA3D8351
X-PGP-Key: https://flashner.co.il/~efraim/efraim_flashner.asc
X-PGP-Fingerprint: A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Received-SPF: pass client-ip=178.62.234.194;
 envelope-from=efraim@flashner.co.il; helo=flashner.co.il
X-Spam_score_int: -18
X-Spam_score: -1.9
X-Spam_bar: -
X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-BeenThere: guix-devel@gnu.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: "Development of GNU Guix and the GNU System distribution."
 <guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
 <mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
 <mailto:guix-devel-request@gnu.org?subject=subscribe>
Cc: guix-devel@gnu.org
Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+larch=yhetil.org@gnu.org>
X-Migadu-Flow: FLOW_IN
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org;
	s=key1; t=1635076292;
	h=from:from:sender:sender:reply-to:subject:subject:date:date:
	 message-id:message-id:to:to:cc:cc:mime-version:mime-version:
	 content-type:content-type:in-reply-to:in-reply-to:
	 references:references:list-id:list-help:list-unsubscribe:
	 list-subscribe:list-post; bh=1zYfoLl6a2B9sCN4GtexP/jq+U71VPAxGyFeq12V4M4=;
	b=SsyVXjgywb/SugR2oVUZu0dg5Ltz49ru6JsUefAq448DvBtlgt8YQrwJo66d3fkTkw+CPu
	FumQxfCcbn64gcmbro7heiinRs+6I6bljELBRH2Sts/cNkbtM5B/w1jBEj5aSmmpCEQXz2
	i4Zod1WgnwcmtqyaR/LBUdJrrkqPQb/Q9uU4y7JGOdOKrNdXzOf+Rm/Kepzx2BkNTB/JW6
	qfbBsfQt2lQ/kQdd77lQnPlga5+E+p3pYLjfj4lkdYljve4DDePMvUxYJliCcIz0UJsHSL
	0exAOgW+PIhRfGUzF4Jpq0xAkukjfxgNWJ5CtAECDdJPrlSzvOvxR5VGC5RDyw==
ARC-Seal: i=1; s=key1; d=yhetil.org; t=1635076292; a=rsa-sha256; cv=none;
	b=t0WfHjRoeny3u5hNMrH0vCfwOZ5L+QbSVNo+LQww4cAp6vov3TZ/kX7+L/PEg6stIZ6S8e
	7Zv1fnc7w3AqDYY5tqyWq5jPMvoSlM/9JeqWSL+AsHJtxhKREDN168zLH3odhao5mHrhpc
	bsqjule7vDcQ5tGeqaya5F8H8PWh9Q+qyS1IXntP8WPvOweI3QA61IZwsQLRp84/dgcHYB
	8hkhXu2W+bQK8OG42993aA3hbewifLZ2qu1i9F5tH0mb1y1HeqzNA2+akzvitWpWHBl1a7
	O9e5hq6FO28luSqgxkr3tAxlfqvmw0wjb3j/EwFdZ5W9Jp/cIcCjEbNyl1/iTw==
ARC-Authentication-Results: i=1;
	aspmx1.migadu.com;
	dkim=none;
	dmarc=none;
	spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org
X-Migadu-Spam-Score: -4.02
Authentication-Results: aspmx1.migadu.com;
	dkim=none;
	dmarc=none;
	spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org
X-Migadu-Queue-Id: 647E726FF8
X-Spam-Score: -4.02
X-Migadu-Scanner: scn0.migadu.com
X-TUID: 2yBox3El5FOT


--3xLhxM+EF3nyabt6
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Oct 21, 2021 at 10:51:07AM -0700, Vagrant Cascadian wrote:
> On 2021-10-19, Ludovic Court=C3=A8s wrote:
> > zimoun <zimon.toutoune@gmail.com> skribis:
> >
> >> On Tue, 19 Oct 2021 at 14:56, Ludovic Court=C3=A8s <ludovic.courtes@in=
ria.fr> wrote:
>=20
> >> One question is =E2=80=9Cencouragement=E2=80=9D for reviewing, somehow=
=2E  Asking for new
> >> package additions to go via guix-patches is a call making kind of
> >> equality between contributors.  As someone without commit access, I can
> >> tell you that it is often demotivating to send a trivial addition, wait
> >> forever, ping people (aside I know who I have to ping :-)).  Usually, =
it
> >> means people are busy elsewhere, so I try to help to reduce the worklo=
ad
> >> by reviewing stuff or by doing bug triage.  However, in the same time,=
 I
> >> see committers push their own trivial additions.  It appears to me
> >> =E2=80=9Cunfair=E2=80=9D.
> >
> > I understand and sympathize (I also see us slipping off-topic :-)).
> >
> >> Why are committer=E2=80=99s trivial additions more =E2=80=9Curgent=E2=
=80=9D than mine?
> >
> > Yeah, I see what you mean.
> >
> > I would like to see us committers do more review work.  But I also view
> > things from a different angle: everyone contributes in their own way,
> > and each contribution is a gift.  We can insist on community
> > expectations (reviewing other people=E2=80=99s work), but we should als=
o welcome
> > contributions as they come.
>=20
> I must admit, I don't review patches unless they're in an area of
> expertise (e.g. u-boot, arm-trusted-firmware, reproducible builds
> tooling, etc.); I just don't have sufficient skill with guile to review
> arbitrary packages in a meaningful way, other than the most trivial of
> packages...
>=20
> Before I was granted commit access, I *really* appreciated getting
> review... but was also frustrated by how long it took to get a
> contribution in; having limited time available for guix, spending that
> energy checking if something I'd already "finished" was actually merged
> was a bit demotivating.
>=20
> I have added a small number of trivial packages without review; maybe I
> shouldn't have... but it was also a bit of a sigh of relief once I could
> push directly to no have to get caught up in the waiting game; I had
> more time to actually contribute other improvements to guix.
>=20
>=20
> > There=E2=80=99s a balance to be found between no formal commitment on b=
ehalf of
> > committers, and a strict and codified commitment similar to what is
> > required for participation in the distros list=C2=B9.
>=20
> So yeah, it is a quite balancing act!
>=20
>=20
> Would a workflow of pushing to a "wip-pending" branch in guix.git that
> then gets merged and/or cherry-picked into master/staging/core-updates
> help at all?
>=20
> A cursory review could commit to "wip-pending", with the
> plan/hope/expectation that it would get some other review and/or a
> timeout before it gets merged.
>=20
> I guess it would be hard to avoid having to constantly rebase with the
> latest updates... "wip-pending" might just add more work to an already
> needs-more-resources process...
>=20
>=20
> live well,
>   vagrant

There is cbaines' guix-patches service (and other things), where you can
add the git remote https://git.guix-patches.cbaines.net/git/guix-patches
and then cherry-pick commits from there to the necessary branch. I
haven't used it much though.

--=20
Efraim Flashner   <efraim@flashner.co.il>   =D7=A8=D7=A0=D7=A9=D7=9C=D7=A4 =
=D7=9D=D7=99=D7=A8=D7=A4=D7=90
GPG key =3D A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

--3xLhxM+EF3nyabt6
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAmF1R94ACgkQQarn3Mo9
g1GSFQ//d5x5ELI2qjXg0jdaWHXAaJ48om6tCTw4oLIh1JdBkaolzWjf0zBcED1X
osZXcoDOsalHPuxHiyTYUg+WiZ2eRRVz6nKGIYz3S6h46i/sL7WqsC0EvCnss7Eh
laerF76j2iBnZV5++ZIpuKIQXcW2d2xAPLmciZK5WjUZV3jlYsXBYe1TbUzAqCb0
foS7teHq/J3pRUVlTKJSKW5mUbDTq8NHviYV+et2M5YZ8HhmqAJaNm0Ruc8icgcy
FJA4dZRWVCJ22F/BfVvKdUHNQVqth1S2kavk5crC/LZwo2FTLqO1dQzH0pCv6fiy
UcwFiv6vSpp9SApyCkJBXBTzJcFgDbS/SIM+lqsVlwGChcg/P7CbzupxubhULvy4
ofwvNLBQlfW+wx7oDX3fZLafWyfzBKQk8sXpXwvc2B8jbYHE7U01SiANZztDhljL
5D5ENz/dtAsaJ4RxwX6/n4NF9wwWN3ESJBVNY7X9FlweI6qCYAWhD2y4Ialr0aJy
zWQhe0Ho+AdXSNrdbkAVYg41RmpouAG5yHP2lrlfeV2EKGGEAX0encl3M/CXDbRI
fE+zkkUcZ3yR0Jd7T2LTufDEgr+spPFDhozW8OFMXpBGIfDDwLJHVrGWkuE2hDCl
wjyCkFQVSOOsVy6YrdC3EuKE5q/aaR4k2vyUHdmXvQaSU8xqclc=
=KX5Y
-----END PGP SIGNATURE-----

--3xLhxM+EF3nyabt6--