Re: branch core-updates-frozen updated: gnu: sddm: Fix build.

Re: branch core-updates-frozen updated: gnu: sddm: Fix build.

[Ludovic Courtès]

Hello!

guix-commits@gnu.org skribis:

> efraim pushed a commit to branch core-updates-frozen
> in repository guix.
>
> The following commit(s) were added to refs/heads/core-updates-frozen by this push:
>      new f883677  gnu: sddm: Fix build.
> f883677 is described below
>
> commit f8836774e2c76c1f4d9bee11339839f7d878e32a
> Author: Efraim Flashner <efraim@flashner.co.il>
> AuthorDate: Thu Sep 2 17:15:39 2021 +0300
>
>     gnu: sddm: Fix build.
>     
>     * gnu/packages/display-managers.scm (sddm)[arguments]: Use gexp for
>     configure-flags.

Out of curiosity, what was the build issue?  Could it be that
‘%build-inputs’ was undefined for this build system?

>      (arguments
>       `(#:configure-flags

[...]

> +       ,#~(list
> +            ;; This option currently does nothing, but will presumably be enabled
> +            ;; if/when <https://github.com/sddm/sddm/pull/616> is merged.
> +            "-DENABLE_WAYLAND=ON"
> +            "-DENABLE_PAM=ON"
> +            ;; Both flags are required for elogind support.
> +            "-DNO_SYSTEMD=ON" "-DUSE_ELOGIND=ON"
> +            "-DCONFIG_FILE=/etc/sddm.conf"
> +            ;; Set path to /etc/login.defs.
> +            ;; An alternative would be to use -DUID_MIN and -DUID_MAX.
> +            (string-append "-DLOGIN_DEFS_PATH="
> +                           #$shadow

Note that this style makes it impossible for users to override “shadow”
via something like:

  (package
    (inherit sddm)
    (inputs `(("shadow" ,my-very-own-shadow))))

To avoid that pitfall, the New Recommended Style™ is:

  #~(list …
          #$(this-package-input "shadow"))

Thanks,
Ludo’.

Re: branch core-updates-frozen updated: gnu: sddm: Fix build.

[Efraim Flashner]

[-- Attachment #1: Type: text/plain, Size: 2226 bytes --]

On Thu, Sep 02, 2021 at 06:47:10PM +0200, Ludovic Courtès wrote:
> Hello!
> 
> guix-commits@gnu.org skribis:
> 
> > efraim pushed a commit to branch core-updates-frozen
> > in repository guix.
> >
> > The following commit(s) were added to refs/heads/core-updates-frozen by this push:
> >      new f883677  gnu: sddm: Fix build.
> > f883677 is described below
> >
> > commit f8836774e2c76c1f4d9bee11339839f7d878e32a
> > Author: Efraim Flashner <efraim@flashner.co.il>
> > AuthorDate: Thu Sep 2 17:15:39 2021 +0300
> >
> >     gnu: sddm: Fix build.
> >     
> >     * gnu/packages/display-managers.scm (sddm)[arguments]: Use gexp for
> >     configure-flags.
> 
> Out of curiosity, what was the build issue?  Could it be that
> ‘%build-inputs’ was undefined for this build system?

definitely a possiblity.

> 
> >      (arguments
> >       `(#:configure-flags
> 
> [...]
> 
> > +       ,#~(list
> > +            ;; This option currently does nothing, but will presumably be enabled
> > +            ;; if/when <https://github.com/sddm/sddm/pull/616> is merged.
> > +            "-DENABLE_WAYLAND=ON"
> > +            "-DENABLE_PAM=ON"
> > +            ;; Both flags are required for elogind support.
> > +            "-DNO_SYSTEMD=ON" "-DUSE_ELOGIND=ON"
> > +            "-DCONFIG_FILE=/etc/sddm.conf"
> > +            ;; Set path to /etc/login.defs.
> > +            ;; An alternative would be to use -DUID_MIN and -DUID_MAX.
> > +            (string-append "-DLOGIN_DEFS_PATH="
> > +                           #$shadow
> 
> Note that this style makes it impossible for users to override “shadow”
> via something like:
> 
>   (package
>     (inherit sddm)
>     (inputs `(("shadow" ,my-very-own-shadow))))
> 
> To avoid that pitfall, the New Recommended Style™ is:
> 
>   #~(list …
>           #$(this-package-input "shadow"))
> 
> Thanks,
> Ludo’.

Sounds good. I'll take another go at it in the morning unless someone
beats me to it.

-- 
Efraim Flashner   <efraim@flashner.co.il>   רנשלפ םירפא
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]