From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:8:6d80::]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id APFEKcNTiGBZbAEAgWs5BA (envelope-from ) for ; Tue, 27 Apr 2021 20:11:15 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id aIQRJcNTiGDfMQAA1q6Kng (envelope-from ) for ; Tue, 27 Apr 2021 18:11:15 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 2AF78165DF for ; Tue, 27 Apr 2021 20:11:15 +0200 (CEST) Received: from localhost ([::1]:33480 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lbSAz-000370-8W for larch@yhetil.org; Tue, 27 Apr 2021 14:11:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52662) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lbSAU-00032K-BL for guix-devel@gnu.org; Tue, 27 Apr 2021 14:10:43 -0400 Received: from hera.aquilenet.fr ([2a0c:e300::1]:45914) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lbSAO-0006L4-I6 for guix-devel@gnu.org; Tue, 27 Apr 2021 14:10:38 -0400 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id D3A1199A; Tue, 27 Apr 2021 20:10:30 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id WYY1VQpZSUhH; Tue, 27 Apr 2021 20:10:30 +0200 (CEST) Received: from jurong (p200300dd57108c006a5d31da0fb6891a.dip0.t-ipconnect.de [IPv6:2003:dd:5710:8c00:6a5d:31da:fb6:891a]) by hera.aquilenet.fr (Postfix) with ESMTPSA id BA5E9368; Tue, 27 Apr 2021 20:10:28 +0200 (CEST) Date: Tue, 27 Apr 2021 20:10:24 +0200 From: Andreas Enge To: =?iso-8859-15?B?TOlv?= Le Bouter Subject: Re: A "cosmetic changes" commit that removes security fixes Message-ID: References: <87tunz11mf.fsf@netris.org> <87r1j30xmo.fsf@netris.org> <87czumypz3.fsf@netris.org> <87o8e4zy5k.fsf@gmail.com> <5cbbfa9b258fb28beb9288685ccc85b4d015cd8a.camel@zaclys.net> <3b57b80c25b48c1c1377bfc076ac4dc9b38ebb39.camel@zaclys.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <3b57b80c25b48c1c1377bfc076ac4dc9b38ebb39.camel@zaclys.net> X-Spamd-Bar: / X-Rspamd-Server: hera X-Rspamd-Queue-Id: D3A1199A X-Spamd-Result: default: False [-0.50 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; TO_DN_ALL(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; RCVD_NO_TLS_LAST(0.10)[]; FROM_EQ_ENVFROM(0.00)[]; MID_RHS_NOT_FQDN(0.50)[]; FORGED_RECIPIENTS(2.00)[lle-bout@zaclys.net ..,andreas.enge@aquilenet.fr ...]; RCVD_COUNT_TWO(0.00)[2]; BAYES_HAM(-3.00)[100.00%] Received-SPF: neutral client-ip=2a0c:e300::1; envelope-from=andreas@enge.fr; helo=hera.aquilenet.fr X-Spam_score_int: -10 X-Spam_score: -1.1 X-Spam_bar: - X-Spam_report: (-1.1 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_NEUTRAL=0.779 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Guix Devel Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1619547075; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=I/d1cqS6P/nDL0UNHJVpGBuOzV9/kduJB95nGdLwSOQ=; b=HP70So0Q01NQ9anjrgSM05MFoof012dMI5Lx/8QQxXPPghEm+q9IHgHEtwyRzL/GRaWS2l B3NJrZ8/7DiCBR2pAQlRpuotl9MdNZren0FPIHXPw4fcZaA7soQndEhJfKj8AYD9HdRnA7 xaaqoFRK2N58xPB6Lkquxub+R+otLssohFGRVNfcM5OW620cI2dgzLOGRhblqlWOG8TkoW qTWluTV5mMmKeGgNCIRX1n62F0PrJKvgt9V9t4MXTgLhMdvLBt3B4Kd5dHNFoxQdBVr7As AygtzCiV/yw3rX44Sv/9Yh+iMAIwi7YohMsGdOWkH1+aflIPhseg/Pazx4vFMA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1619547075; a=rsa-sha256; cv=none; b=d6dGvhViaNx22m6o9ZShIuMpEzcZEYNLIzXui+nE5cu3KiYJL7LIXUHTSUHXX9ls7hC+ue V7tzQpyPF6FKQwKNQ1tdyk+m4e784upafZ8VBjPwgjf0SZ9QWMcBOEjA6kliDwZQNQ5TgO VQy7ULo9bh4Z8w2EDSnpXhj9FhJZ8IkPm3dmz8T2qTYRRbgZAoxHc0coK/KU0mncE9Vzf3 EsKrgu5efBKRwpeloqDyNp5AvhfJe5aGJThgqweMdYhvhde+MMLyJzclvNOqkIqNgUWr04 4xh5FK4uTccUab9543o/0V6zC3vXmZTieIdW94RBg6j8g+nJ738UH+bCeF4/Tw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Spam-Score: -1.95 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Queue-Id: 2AF78165DF X-Spam-Score: -1.95 X-Migadu-Scanner: scn0.migadu.com X-TUID: NETZE1EYqUV9 Hello Léo, Am Mon, Apr 26, 2021 at 09:31:18PM +0200 schrieb Léo Le Bouter: > also consider other things like how people feel when they > contribute to GNU Guix, do they feel discouraged or rewarded by their > contributions indeed that is an important aspect. > I find that it can be tiring and very discouraging to > respond back and forth to many many review comments, and at some point, > even if things have some rough edges, I tend to prefer rewarding a > contributor for their work than insist the commit history should be > perfect or something. I also stopped upholding myself to high rigorous > standards at all times, also because I think it is not good for my > mental health. I agree that it can be a bit tiring, but at the same time, I think that the high quality of Guix is a very important feature, that sets it apart from some other distros. It is definitely one of the reasons I am using it and have been contributing to it. And it has been one of the defining features of Guix from the start that we try to avoid rough edges as much as possible. Like building texlive from source instead of wrapping Debian binaries, to give just one example. Or striving for bootstrappability, which can be seen as removing rough edges at the expense of extraordinary efforts. Luckily, I do not think that enjoying contributing and keeping high quality standards are in contradiction. > I tend to move the responsability of rigorous testing > into tools, I think putting testing/checking into tools is at the same > time good for mental health and inclusive because it means also > everyone can check their own changes and correct errors. Tooling can definitely be helpful with this. We have "guix lint", and if you have ideas for improved tools, these would be very welcome. Andreas