From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id rSr6ATkqg2CHGwEAgWs5BA (envelope-from ) for ; Fri, 23 Apr 2021 22:12:41 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id gFTQNzgqg2DyOQAAbx9fmQ (envelope-from ) for ; Fri, 23 Apr 2021 20:12:40 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 739D3152A5 for ; Fri, 23 Apr 2021 22:12:40 +0200 (CEST) Received: from localhost ([::1]:45002 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1la2AJ-0003aZ-LM for larch@yhetil.org; Fri, 23 Apr 2021 16:12:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48804) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1la2A4-0003YL-Qd for guix-devel@gnu.org; Fri, 23 Apr 2021 16:12:24 -0400 Received: from wout2-smtp.messagingengine.com ([64.147.123.25]:34143) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1la2A2-000790-Ns for guix-devel@gnu.org; Fri, 23 Apr 2021 16:12:24 -0400 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id 432CC37E0; Fri, 23 Apr 2021 16:12:20 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Fri, 23 Apr 2021 16:12:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=mesmtp; bh=uKKlCNQgFquKQ8pDsJyY90Tg IS4yKCZ2vqHdVG6iHPU=; b=JG0r6RMQYg/jfu+t41qkXqaTs3tjGXkhGtttCx0E 5UmqIS/AyytJj4EZjt5/a/cwo25/lqnaTma0Ax5wLqAQwhAAKp6x1IMusZf6Bzsa qTqUx4ZOJLa7ukbVVvssB9OTd/iWrbLY/OkNqyLU3/Jv60De70wXtzzrGwEoEOuu 6+Y= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=uKKlCN QgFquKQ8pDsJyY90TgIS4yKCZ2vqHdVG6iHPU=; b=m5tl5JFuxrEvImZiN3cxc8 OR1q///inAlqvmTkJWW7/I/e/Z2QF4/VSffqU6NT+MtGglk/J8ESjEoytztACrH5 R7K/vmuMjjMhwV5zuUv9h7FJ0cuzzKp6tQkQ0nVD0Z/Kav7op7VBWH8wCWXAT7ff adoAeJB929z43N8zTiwqr3rpIbcAKanGaWhKMd0Efq0zJOf1SGdl8/C21erbI0gT lZZc+PrBjaeZvDrceLHQWrzkacuU6DuUGDfIirnvxN9x4X9z8Ar2EpnhehvUlWMk AednZazHM3GYArdEa3fDYDMJ6mSnyriyFnd/Mk4HTqM4AmKvbwGGoRVG7c4W5Z6g == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvdduvddgudegiecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvuffkfhggtggujgesghdtreertddtudenucfhrhhomhepnfgvohcu hfgrmhhulhgrrhhiuceolhgvohesfhgrmhhulhgrrhhirdhnrghmvgeqnecuggftrfgrth htvghrnhepudfhffevhedtgfejveelfeeukefhtddvffetgeeuiefgvedvkeefieejfffg ffelnecukfhppedutddtrdduuddrudeiledruddukeenucevlhhushhtvghrufhiiigvpe dtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehlvghosehfrghmuhhlrghrihdrnhgrmhgv X-ME-Proxy: Received: from localhost (pool-100-11-169-118.phlapa.fios.verizon.net [100.11.169.118]) by mail.messagingengine.com (Postfix) with ESMTPA id 34E79240054; Fri, 23 Apr 2021 16:12:18 -0400 (EDT) Date: Fri, 23 Apr 2021 16:12:13 -0400 From: Leo Famulari To: =?iso-8859-1?B?TOlv?= Le Bouter Subject: Re: A "cosmetic changes" commit that removes security fixes Message-ID: References: <87tunz11mf.fsf@netris.org> <87r1j30xmo.fsf@netris.org> <87czumypz3.fsf@netris.org> <87o8e4zy5k.fsf@gmail.com> <5cbbfa9b258fb28beb9288685ccc85b4d015cd8a.camel@zaclys.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="gkRengjWWdtBkAqB" Content-Disposition: inline In-Reply-To: Received-SPF: pass client-ip=64.147.123.25; envelope-from=leo@famulari.name; helo=wout2-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Maxim Cournoyer , Raghav Gururajan , Sou Bunnbu , Leo Prikler , Guix Devel Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1619208760; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=uKKlCNQgFquKQ8pDsJyY90TgIS4yKCZ2vqHdVG6iHPU=; b=Bc4oBD+MLAY0HsgNM7REa+XYU9pWoyzLPMuWBfB7Oepx6+sbfn8KQGkh+KV7yNrC+PBfyO hzLSv6/RMBjzKuzmDEr/hwzSCnmz6kAaYFDWw1UB35b/xffvgcnj6/4dsV6ck1LA6+RVMy /glH0V60js4Gmj7VyAyAw74WF0OED3WjZZ/WCC/k4aHd7PVexAe/VszsbfjCp3vRdZA+yn dMJlYAH68KsEGb3bxsdbiDczeqClHUB3nnv/pgSaetOgaAJViOguNbv7ziRkTg33usLMkN mL9IbBSIdBJhCTlU6PHlvHinwl3A3s7Gh3Xq/J1W4UgRTygNyTvzDS/ZGHuckQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1619208760; a=rsa-sha256; cv=none; b=Kuqdb3hvc51uRhDXB+lvvsUQzBSugo3yKOUeexsYNizHvALciGycR8N+4bcBCzf0EQ8xpN Cbm7Kn5lsFlpa4fm5CtgceJR55cv/zh/70fHTjsq1z9R9rYJogfVOFEWX7yYcuJ+UGK1tz haIx6gDtEbiGJWkJIqOyuH4OOFcPIhgDKXiVa9MWPuf+0A0ZcSEbAw0CgasKxi9jMWaZY9 jPcehciKW09sc0CP5IH/5CjYwPAXb0MXrFVUU4XZgLCpmwyv96N/15CdnBRT/ATP1Sg+Bd K8QGTaxF44umGMX6IU8cpkDkPmRM51+SJU9oiOy9anTrViQJRafCKZyndIU3wQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=famulari.name header.s=mesmtp header.b=JG0r6RMQ; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm2 header.b=m5tl5JFu; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Spam-Score: -2.04 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=famulari.name header.s=mesmtp header.b=JG0r6RMQ; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm2 header.b=m5tl5JFu; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Queue-Id: 739D3152A5 X-Spam-Score: -2.04 X-Migadu-Scanner: scn0.migadu.com X-TUID: 6dVOCTIIm71m --gkRengjWWdtBkAqB Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Apr 23, 2021 at 09:33:07PM +0200, L=E9o Le Bouter wrote: > I knew about this but I didnt feel like telling Raghav to do yet > another rebase. I felt like Raghav was taking on with so much already. > The rebase was specially complicated because Raghav's commit changed > indentation, git has bad quite bad UX for cases like these. At the time > I had lots of things to handle also and couldnt spend lots of time on > it myself. I didnt feel like blocking the merge of these patches for > commit history was worth it at all. Such blocking could have hindered > the GNOME upgrade effort even more. Thankfully now there's lots of > energy being put to it, at the time there wasnt anyone else than Raghav > and me. I'm sympathetic. There is an imbalance between the work that we want to complete, and the time and energy that we can give to it. And in the case of GNOME, we have already fallen short of our goals several times, having missed multiple upgrades. I too have felt the temptation to cut corners with Git when I know that the final result will be "okay". But Guix is not just about the final product (a release, or a merge). We also have the --commit option to Guix commands, and `guix time-machine`. So the Git history is important too. And I have also spent several hours at a time, focused on completing (after several restarts) a complicated rebase involving dozens of commits. And I've done that many times. I do think that Mark is being hyperbolic about the wip-gnome branch. The name says "work in progress" and we don't hold those branches to a high standard. But what happened on core-updates *must not happen again*. For a task as large as "updating GNOME in Guix", history tells me that it has to be a group effort. In many cases, the hardest part of a project is coordination and leadership, not coding. I hope that this current effort continues, and that more people decide to join. --gkRengjWWdtBkAqB Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAmCDKhoACgkQJkb6MLrK fwgkHhAA8VzJmk/2Lwjja7k3QYsYZII5Ij6nrH6Qd1d9IPPe330TemyhtsxFSN3k d0KZ6YhOyfbNQkNApUfNn8tK5y9y4LD+duxsuxxTG03SWDzq6hCo/xG5yQwK3BuC 3xo7EhFqmHMbHjRtaHWLHFsWl79scazuy4EZV4qWl3JrMehDr53bSxBBY6cteRJs JbMW+ESDEbqaB1pKejE52VXDQkWc3gUxfUiKgXhhyB6Y9gGIOe4HqLc92u7viGlD F8WO0fmH5cdjp/EZ0mPMTMs/TGYepiSDw2yW4OIkXo0aekGkPlwE0L5MgdpeJ2aT Pz3xWK67VcvxfIHVYQN2o8NPz1Gsk4GtfReYq2qhnu/tuUOgSWnk9InHMDELam+O EMhcFfSzHgfG4PqEQDd8ROdTnJwl9Vy0SxgT/3gNpe6Fxn6xcMjF7+B36vTHjdv9 HuzgIGsPewF9G3Lf7YYhtGdoin/Hb1GSM7GfFLuGvFjJjh1J/wAR77s9gaf/Ecqh cG+ihGfFV1GNuLtjJJHY0781bEWBTRDoyyO4USyBdnOAz/4As+QFJPNsWQZb0yUg xyDRCDiBUNjnesjghZqh+m/DSVu9d8XwufVO1MqD4ps7/ost+/bVwozBVVQ30yo2 mfGiSomtKVKcD4UHy/a8nUobq4S/YnObdUhOqsTJI6b7cJmKhKU= =Cqa2 -----END PGP SIGNATURE----- --gkRengjWWdtBkAqB--