From: Andreas Enge <andreas@enge.fr>
To: "Léo Le Bouter" <lle-bout@zaclys.net>
Cc: guix-devel@gnu.org
Subject: Re: imagemagick@6.9.11-48 to graft or not to graft with 6.9.12-2
Date: Mon, 22 Mar 2021 11:29:04 +0100 [thread overview]
Message-ID: <YFhxcOGC2iSbUwNz@jurong> (raw)
In-Reply-To: <d84349e57bc20d554ba0590b0a433dd6986199f6.camel@zaclys.net>
Am Fri, Mar 19, 2021 at 10:40:45AM +0100 schrieb Léo Le Bouter:
> We had a user reporting that Inkscape stopped working after the graft (
> https://logs.guix.gnu.org/guix/2021-03-18.log#100200), after which we
> decided on IRC with rekado we might cheat by symlinking the shared
> libraries, which I've done in commit
> 2e0ff59f0cd836b156f1ef2e78791d864ce3cfcd, from a glance it didnt seem
> the soname change caused backwards incompatible changes but only
> forward incompatible changes.
It happens I just wanted to use inkscape, started submitting a bug report:
https://issues.guix.gnu.org/47315
and ended up realising that this is exactly the issue discussed on
guix-devel.
I cannot afford a "guix pull" right now, since with
https://issues.guix.gnu.org/31719
this might mean a download of a few gigabytes, so I did not check whether
the symlinking fix does work.
But honestly, this feels like piling a cludge (symlinking) onto a cludge
(grafting), and that we are not in the high quality approach for which
I appreciate Guix.
Personally, I would suggest to revert the commits. If the CVE is sufficiently
important (it would be useful if the commit log or the diff itself contained
its number), maybe we can update the imagemagick version on the wip-release
branch, which is supposed to be built soon and merged back to master?
And please let us agree that in the future, we only backport fixes in grafts
and do not update version numbers.
Andreas
next prev parent reply other threads:[~2021-03-22 10:44 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-19 9:40 imagemagick@6.9.11-48 to graft or not to graft with 6.9.12-2 Léo Le Bouter
2021-03-19 11:12 ` Julien Lepiller
2021-03-21 14:04 ` Ludovic Courtès
2021-03-22 10:53 ` zimoun
2021-03-22 16:55 ` Ludovic Courtès
2021-03-22 10:29 ` Andreas Enge [this message]
2021-03-22 21:12 ` Mark H Weaver
2021-03-23 13:34 ` Léo Le Bouter
2021-03-23 17:42 ` Leo Famulari
2021-03-23 14:07 ` Ludovic Courtès
2021-03-23 23:32 ` Mark H Weaver
2021-03-23 14:22 ` Andreas Enge
2021-03-23 14:38 ` Léo Le Bouter
2021-03-23 17:45 ` Leo Famulari
2021-03-23 23:05 ` Mark H Weaver
2021-03-24 4:12 ` Leo Famulari
2021-03-23 23:42 ` Mark H Weaver
2021-03-24 10:15 ` zimoun
2021-03-27 15:48 ` Andreas Enge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YFhxcOGC2iSbUwNz@jurong \
--to=andreas@enge.fr \
--cc=guix-devel@gnu.org \
--cc=lle-bout@zaclys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).