From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id qERmFjr3UGBaHgAA0tVLHw (envelope-from ) for ; Tue, 16 Mar 2021 18:21:46 +0000 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id WBomEjr3UGADRQAAbx9fmQ (envelope-from ) for ; Tue, 16 Mar 2021 18:21:46 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id CB53510863 for ; Tue, 16 Mar 2021 19:21:45 +0100 (CET) Received: from localhost ([::1]:53050 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lMEK8-0005BX-QX for larch@yhetil.org; Tue, 16 Mar 2021 14:21:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52846) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lMDvL-0004IP-Vm for guix-devel@gnu.org; Tue, 16 Mar 2021 13:56:08 -0400 Received: from wout3-smtp.messagingengine.com ([64.147.123.19]:46845) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lMDvH-0000YN-B6 for guix-devel@gnu.org; Tue, 16 Mar 2021 13:56:07 -0400 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id 1C34112B9; Tue, 16 Mar 2021 13:56:01 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Tue, 16 Mar 2021 13:56:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=mesmtp; bh=NPES/D958Ho87Np+DMy4Xo7/ 7OB68mfFxboPdrqKvYk=; b=s0mUu73ninFS8BWYp724z14q8PbKo8VdzWFDO4PY On8LSBkhuCCC1A4L9KyiwS9mrZQ5XE/Qc+BXNrP20nbk832SdRyBQ78Oj79CLNaz 8U5EKnthZskTF6I9PXLfomVYwEAqJuqCLfjSgqP0g/MR4chUczQ60oJimhHe9+gM VTI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=NPES/D 958Ho87Np+DMy4Xo7/7OB68mfFxboPdrqKvYk=; b=UQJjQfjt+duF+WwYKKcUXd G5la2n7as9Kr5FF+WmcayL8G0kw1ZxSBfMZrEy3JbxIGVEu1xy1V4P08Hyf7EATb fOjC5H+uTiAAQliyoD4TFHaN6j382isi72VgrdG6fmNwpVAXvPL8Ls1UOMEn+S8j 019MCSmzJTQERNCseHzdMvLVHBbBSQwYDc3YPSvKtrxqf4fut0v30FjDfYUK7sZs rdQ8t1e8RVuKef8U+z84tdzrdDokp9xYUoARmCPLXZpIY7O+/THER4xMQJEBLLGX pjExaQeCspGB6uanuRNu9rU2LA+Irm30AS4YMJp7EyZo+W7lz9dzMEIPpUs1DHvw == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudefvddguddtkecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvuffkfhggtggujgesghdtroertddtudenucfhrhhomhepnfgvohcu hfgrmhhulhgrrhhiuceolhgvohesfhgrmhhulhgrrhhirdhnrghmvgeqnecuggftrfgrth htvghrnhepudeffeehteelvefgudeuudetuedvhefgkefhueegvdfftdejvdehffevtdej tddunecuffhomhgrihhnpehgnhhurdhorhhgnecukfhppedutddtrdduuddrudeiledrud dukeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehl vghosehfrghmuhhlrghrihdrnhgrmhgv X-ME-Proxy: Received: from localhost (pool-100-11-169-118.phlapa.fios.verizon.net [100.11.169.118]) by mail.messagingengine.com (Postfix) with ESMTPA id 4C082240057; Tue, 16 Mar 2021 13:56:00 -0400 (EDT) Date: Tue, 16 Mar 2021 13:55:58 -0400 From: Leo Famulari To: zimoun Subject: Re: Release 1.2.1: zstd 1.4.4 -> 1.4.9: grafting or core-updates? Message-ID: References: <91998d12df3c4a279f46cf50b15d47c99e064a46.camel@zaclys.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="5KCsH6ydK7lEe3M8" Content-Disposition: inline In-Reply-To: Received-SPF: pass client-ip=64.147.123.19; envelope-from=leo@famulari.name; helo=wout3-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Guix Devel Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1615918905; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=NPES/D958Ho87Np+DMy4Xo7/7OB68mfFxboPdrqKvYk=; b=NeizV/BoaTPDs8Z5HrhPddtDR19SQbwMmLkkttyFQ8J3bqCf9CfSdqVls54zyt6BEUVXYf vfSOCCQpi/pO5xrLDcADu5TX1dg/IyVu/fMtJN8BTdAeDR3YjpXLHL+rFZDHBHpsZYUnB0 2RK4eDDpcILz+r1smJjU5wKoi0gcpsbU5u7U90YZiY8Uc+h5Z3rc0ifcBYazOTQeKEHxtF Iikg2o8ifKqNzZDxWIYWcnhUs0zJRBdcALwQl0N5W5z/arqqtXeWF4K78xJzArVXmp9VMn zS7lTLLj07DokYVJX+9MrPfLTuKBaVZFvWwWJVXXEb3g1zW5z0egxo/VVL41ig== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1615918905; a=rsa-sha256; cv=none; b=mZNwHpqOiHsTikFspg0Cs/e1jc1YAD3WGnOteguj4a666HIIN3+aC7ItL91SdxEl+Y21fq WgNx5LJ/IJhWiJhp1mpHo+L2qjq6ASXrPb1ZSR51XoRbRWju/84T/n10Ao2XqhsJzSPIC6 QXoOxtuc8agfc1PZhlJPUj6TE9Hmt1DYvD1JLUEtJqZj2khApqnIVgp4PMeXYmPudG19+K p9L8rvOYyekvQXKDsHW6baxv87wo64rtwjg8tXRh9bbbSnNqGfQhc/mdfpc5EyCe3eL9Pk R8mtjYa0YNRttydTJJ2hPCT8mHS2Q+ip0MHseLGcQLydybqy1liwMrY5NVkAQA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=famulari.name header.s=mesmtp header.b=s0mUu73n; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm2 header.b=UQJjQfjt; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Spam-Score: -2.50 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=famulari.name header.s=mesmtp header.b=s0mUu73n; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm2 header.b=UQJjQfjt; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Queue-Id: CB53510863 X-Spam-Score: -2.50 X-Migadu-Scanner: scn0.migadu.com X-TUID: BHl5PzrHLz8c --5KCsH6ydK7lEe3M8 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Mar 16, 2021 at 05:34:34PM +0100, zimoun wrote: > The question is: should the next release 1.2.1 contain zstd@1.4.9 as > graft? Or do we revert the commit and simply fix it on core-updates > and wait for the next core-updates cycle. Personally, I am in favor > of the latter. WDYT? The release should not contain any grafts, if we can help it. On the wip-next-release branch, I've simply updated zstd to 1.4.9: https://git.savannah.gnu.org/cgit/guix.git/log/?h=3Dwip-next-release I do agree that updating this program 5 versions in a graft was perhaps too much. We should always try to cherry-pick bug-fix patches when grafting. Otherwise the risk of breakage is too high. At least, these types of patches should be reviewed on guix-patches. L=E9o, can you send them to guix-patches in the future? Sometimes it is okay to update things in a graft, but it depends on the situation. --5KCsH6ydK7lEe3M8 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAmBQ8S4ACgkQJkb6MLrK fwiqwhAA6QoDb+7oQYNjgcI/W5ngN5VINzeWPJYK0r7vmx3YpJiSRrnaOtIqPdhL afiblV+k3MI6K4/EFbkcimWA4PAf/aKObSFjqqax0X81OFZ/5z1acU3iNNHM3OVz ehQbGV6IprzIkCpsOrocnWLjrGMFkrg0yxF418ncc680aP5ofcZ1SMWXhBg/0fv7 5cjXJlsw/zy4H2vErgvaLUyCdXVgNGbkQxccNXB6eQXaxAdXTRlCdAgp04tJw4lD k3t6I2XP2K3VJYFY2GgZgDTGz6LMjqQ3dC99OjMcCM3uIRhYGT3tDYiKXd2tCK0S m83INkEjUBck7hNzqqG7t+Z7IkP6C+0Cr3ICjRRGozpc9/FlPDxF5ceCYmwWShJz KFIR1S/3+pgWPaz9WVralB0nnCfX+wMIC8gEIK1eDjjWE4/S++KHLWZDbJefvRZr pesqLmUE+m1cuasiuIbi/IPodxZPclsIoMooQyH85hZA38mgDK2FRGwp1l8SCmuh EyPeQLV/qMHDIFxT2B2LtpJlBbB28oZiRKRzYjvojDoGMZ+7CLyGurDEp2KdXsWe kTg8vNlXjR2IKMRWwCVbRvHnH27jM9IbOoPlyjGHdU8cv2S9W+0moxiQhf8GM7Z9 igAEYwQa3ZBBQjLPErbu6NjD7OW3jFAH6nU9c0HG1rnaZk185Bk= =hfb6 -----END PGP SIGNATURE----- --5KCsH6ydK7lEe3M8--