From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id GCkSG4FwS2ANagAA0tVLHw (envelope-from ) for ; Fri, 12 Mar 2021 13:45:37 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id KA3NFoFwS2BLZQAAbx9fmQ (envelope-from ) for ; Fri, 12 Mar 2021 13:45:37 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 0B617B0FE for ; Fri, 12 Mar 2021 14:45:37 +0100 (CET) Received: from localhost ([::1]:37560 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lKi6i-00073L-8A for larch@yhetil.org; Fri, 12 Mar 2021 08:45:36 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:41378) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lKi5i-0006gB-DN for guix-devel@gnu.org; Fri, 12 Mar 2021 08:44:34 -0500 Received: from flashner.co.il ([178.62.234.194]:60790) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lKi5g-0005Sx-6P; Fri, 12 Mar 2021 08:44:34 -0500 Received: from localhost (unknown [31.210.181.184]) by flashner.co.il (Postfix) with ESMTPSA id 37AFC40668; Fri, 12 Mar 2021 13:43:59 +0000 (UTC) Date: Fri, 12 Mar 2021 15:43:26 +0200 From: Efraim Flashner To: Chris Marusich Subject: Re: Release on April 18th? Message-ID: References: <87im6042fr.fsf@gmail.com> <86sg53cf58.fsf@gmail.com> <87a6ra3w39.fsf@gmail.com> <87h7lgzs8h.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="t9gC7cKuuEiQx3Um" Content-Disposition: inline In-Reply-To: <87h7lgzs8h.fsf@gmail.com> X-PGP-Key-ID: 0x41AAE7DCCA3D8351 X-PGP-Key: https://flashner.co.il/~efraim/efraim_flashner.asc X-PGP-Fingerprint: A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Received-SPF: pass client-ip=178.62.234.194; envelope-from=efraim@flashner.co.il; helo=flashner.co.il X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Guix Devel Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1615556737; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=D0DF2q36Iat9tm3Xhhu1hYPdp2gK1w0jEgM0bIoRtx0=; b=DJZd61NzwUUPaeuExY7CnA5YQn/LSjukbGO+r++JA79RnSIYoIGV01qJlT2W4hx/GlNBeb ooYRukMyfCNmGwCIxQSuxlp2d7DK8BWegqy9UvExnFMIC2bxD2AM+6qGe9ZmWuJ2kjTWWT FWaqoGXoa8JEllcUptdND+lcW+0S7rXHrtvJgJMoma0Mzs0WDf5vEPq95DtqN9JT83t1sf FCSLGpxY1+qt0jycIY869sII2wDAYMaNbh/DrIpj1OQPQ8o96MlobjJ0xFXH0Ej74Sfy5f 2IknEUiSgf7SOfCvZbuNp+DcYrGhYjUjOIfXhBvSggkLYrZ4hKsUiydbsPS0Cw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1615556737; a=rsa-sha256; cv=none; b=QjgNEzI2iUzT4xgLYsOLXwAXibEjdo4eyHy829UvSjhZmYeLe17iszEAlCdbFDu0OGe/wE 3c/204hnOxjkPCbX53b3NKOC79Wz8WW/jnCgahnD/bGQS2pzUE9FcKrOjroSMzukX8ie5l f8CIj1bQclNC/wntLUJwG5oXYbSZVBUFSEyI25q0RFAIni0KA85Y2FqEKM4YMd+xGWCU2T zjhTwIfPXYXRXkc/45QBVNwaftY/QlfkQ5HW3GOq6k3AcpmbdQrN7v6UMziOCUBlsvCM8d IW+QkLoibNLlLYt1snfn/vyLZ0E8r7mwW0JSsQIT+/qrUky+PffSVTfBd19BZA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Spam-Score: -2.99 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Queue-Id: 0B617B0FE X-Spam-Score: -2.99 X-Migadu-Scanner: scn0.migadu.com X-TUID: azoCpcGI9UOw --t9gC7cKuuEiQx3Um Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Mar 12, 2021 at 12:33:18AM -0800, Chris Marusich wrote: > Hi Efraim and Ludo, >=20 > Efraim Flashner writes: >=20 > > My plan was absolutely to merge master into core-updates after and then > > integrate all the changes into their affected packages. I'd also make > > sure to bump gcc to 8 (assuming we don't go straight to 9). >=20 > Sounds good. If we can get powerpc64le-linux working on master, I'd be > very happy. We can simultaneously try that while still working on > wip-ppc64le (based on core-updates). >=20 > I tried out the wip-ppc64le-for-master branch. I can build it manually > on my Debian ppc64le system, but "make check" fails. There are two test > failures. >=20 > The first test failure is tests/syscalls.scm. It seems that Ludo's > recently added mount procedure (7e9d9f2 syscalls: Add 'mounts' and the > record type.) does not work on my system. In fact, it does not > work on my Debian ppc64le system, nor does it work on my x86_64 Fedora > system. In both cases, the code makes the incorrect assumption that the > type and source are located in columns 8 and 9, like so: >=20 > --8<---------------cut here---------------start------------->8--- > (define (mounts) > "Return the list of mounts ( records) visible in the namespace o= f the > current process." > (define (string->device-number str) > (match (string-split str #\:) > (((=3D string->number major) (=3D string->number minor)) > (+ (* major 256) minor)))) >=20 > (call-with-input-file "/proc/self/mountinfo" > (lambda (port) > (let loop ((result '())) > (let ((line (read-line port))) > (if (eof-object? line) > (reverse result) > (match (string-tokenize line) > ((id parent-id major:minor root mount-point > options _ _ type source _ ...) > (let ((devno (string->device-number major:minor))) > (loop (cons (%mount (octal-decode source) > (octal-decode mount-point) > devno type options) > result))))))))))) > --8<---------------cut here---------------end--------------->8--- >=20 > However, on my systems, the correct columns are 9 and 10. Here's the > first few lines of output from Fedora: >=20 > --8<---------------cut here---------------start------------->8--- > $ cat /proc/self/mountinfo=20 > 22 97 0:21 / /sys rw,nosuid,nodev,noexec,relatime shared:2 - sysfs sysfs = rw > 23 97 0:5 / /proc rw,nosuid,nodev,noexec,relatime shared:24 - proc proc rw > 24 97 0:6 / /dev rw,nosuid shared:20 - devtmpfs devtmpfs rw,size=3D392382= 8k,nr_inodes=3D980957,mode=3D755 > ... > --8<---------------cut here---------------end--------------->8--- >=20 > And here it is from Debian: >=20 > --8<---------------cut here---------------start------------->8--- > 22 28 0:20 / /sys rw,nosuid,nodev,noexec,relatime shared:7 - sysfs sysfs = rw > 23 28 0:21 / /proc rw,nosuid,nodev,noexec,relatime shared:11 - proc proc = rw > 24 28 0:5 / /dev rw,nosuid,noexec,relatime shared:2 - devtmpfs udev rw,si= ze=3D15625664k,nr_inodes=3D244151,mode=3D755 > ... > --8<---------------cut here---------------end--------------->8--- >=20 > On these systems, the 7th column is an optional field, like "shared:7". > The proc man page has this to say about column 7: >=20 > (7) optional fields: zero or more fields of the form "tag[:value]" >=20 > So presumably there can be even more than just one optional field. In > any case, Leo Le Bouter kindly checked his own x86_64 system, where he > observed different output: >=20 > --8<---------------cut here---------------start------------->8--- > $ cat /proc/self/mountinfo=20 > 23 27 0:21 / /proc rw,relatime - proc none rw > 24 27 0:5 / /dev rw,relatime - devtmpfs none rw,size=3D7972408k,nr_inodes= =3D1993102,mode=3D755 > 25 27 0:22 / /sys rw,relatime - sysfs none rw > --8<---------------cut here---------------end--------------->8--- >=20 > As you can see, in this case there is no optional column, so the mount > procedure works fine on Leo's system. But it fails on mine. >=20 > Ludo, do you have an opinion on how to fix this? It seems like we can't > assume the number of columns will always be the same, so I guess we'll > have to somehow ignore the optional columns more intelligently, if we > want to keep using string-tokenize to do this. >=20 > The second test failure is tests/pack.scm. There are two contributing > factors to this test failure. >=20 > The first contributing factor was commit 8f52ea2 on > wip-ppc64le-for-master. It fixes an issue that is not present on > master, and for that reason it actually causes a problem if it's > included. I have removed it from the branch in Savannah; please update > your local copy. Ooops, I guess it was like the findutils-boot0 patch, necessary for core-updates but not needed for master. > The second contributing factor is this bug: >=20 > https://issues.guix.gnu.org/47018 >=20 > However, we can work around it by simply not running guix-daemon when > running the test. When guix builds guix, it'll be done in the build > environment, so these problematic tests will probably be skipped. >=20 > Finally, I tried running make guix-binary.powerpc64le-linux.tar.xz just > to see how far it would get, anyway. I was quickly greeted with this > failure when building glibc-intermediate: >=20 > --8<---------------cut here---------------start------------->8--- > glibc-2.31/wctype/wctrans_l.c > glibc-2.31/wctype/wctype.c > glibc-2.31/wctype/wctype.h > glibc-2.31/wctype/wctype_l.c > phase `unpack' succeeded after 2.4 seconds > starting phase `apply-patch' > Backtrace: > In ice-9/boot-9.scm: > 160: 14 [catch #t # ...] > In unknown file: > ?: 13 [apply-smob/1 #] > In ice-9/boot-9.scm: > 66: 12 [call-with-prompt prompt0 ...] > In ice-9/eval.scm: > 432: 11 [eval # #] > In ice-9/boot-9.scm: > 2412: 10 [save-module-excursion #] > 4089: 9 [#] > 1734: 8 [%start-stack load-stack ...] > 1739: 7 [#] > In unknown file: > ?: 6 [primitive-load "/gnu/store/kvwc9b9ga1sl4l6fyi3z182570rbsk2i-glib= c-intermediate-2.31-guile-builder"] > In ice-9/eval.scm: > 387: 5 [eval # ()] > In ice-9/boot-9.scm: > 160: 4 [catch srfi-34 ...] > In srfi/srfi-1.scm: > 827: 3 [every1 # ...] > In guix/build/gnu-build-system.scm: > 847: 2 [# #] > In guix/build/utils.scm: > 652: 1 [invoke "patch" "--force" "-p1" "-i" #f] > In unknown file: > ?: 0 [system* "patch" "--force" "-p1" "-i" #f] >=20 > ERROR: In procedure system*: > ERROR: Wrong type (expecting string): #f > --8<---------------cut here---------------end--------------->8--- >=20 > Something about the way in which we are searching for the patch is off, > but I don't have time just now to investigate. Efraim, if you can > figure it out, that'd be nice, but I'll look into it more tomorrow. > It's probably something simple and related to commit 2712703. >=20 Leo told me about it yesterday and I pushed a second commit that fixed it. We needed to make sure the patch file was included as an input, that's why it got #f instead of a string. In any case, commit 710cfc330a7ed06934a193583b159fbdf07bf2fe takes care of it; it's the combination of 2712703 and the squash commit. I'm now running make guix-binary.powerpc64le-linux.tar.xz and so far it's made it past the initial building stages, we're on to building the grafts now. --=20 Efraim Flashner =D7=90=D7=A4=D7=A8=D7=99=D7=9D = =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --t9gC7cKuuEiQx3Um Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAmBLb/wACgkQQarn3Mo9 g1FT+w/+PqbAp08pzzvBhNw5aOZD9CqUlDXfjUGUtzzOeVnGY40EaQvndA9BC0Af MFhRHdXpRQljIokrUUtYO5VWzqR5IOE2vD07lzrJ+KKodM9Thf4Lw6A0jR7iIVhc YLyMq4FCWBhzvz6uBY3Yu7Zb5DV0pytBOh8WLVM94z1+W4vKPUn80web3XDGMAZc UQEC3cB2zQmNZhzzEu7jRu/JXfs3NnE0Na/sdVMDz5izGli0RKpwOW821NMADmfb EXSBVDezjPxUSDNn5XjIXLQMC2CXyCOc7aPK+RJhNYYzzTgIgR6c+lITBSsQU2Q8 K5+Hhmn5Bb9rcdhSPE/fXyaT2beGHywE+z8qBUVhKTLV3oI4ukgWD6GYM2IBu1TP th/y1z/togyVqbxGbBSEJV0CXybE1++qJSpYFyAt5LeVnbhn4+xzZel/2/4DP8kT rZ8ltbCjiNyjod9Rfbrxg4V08l00D9J0FVsm0l7Pdqs8nOS70WpdXD2MNQwVqVx7 nB5DiWiSFpz5vbEgGKK9S8Xn5boJ5t+6W8pKeiYptZFasVfjUk+NLuMtmRLi9Xtc hSWK6DLZJ+Brr+HqRnLZpHtZ8gugsHWk001bBwLPwUdN/djcQS7Wbs1d+mDx2Saj nCs7cFq0UrljyXOeemM5WE7X1tJkceIzjJXFUwc/in/qEay9Qyc= =PjXn -----END PGP SIGNATURE----- --t9gC7cKuuEiQx3Um--