From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id qERyFM2ZI2AILgAA0tVLHw (envelope-from ) for ; Wed, 10 Feb 2021 08:31:09 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id oPY1EM2ZI2DXdQAAbx9fmQ (envelope-from ) for ; Wed, 10 Feb 2021 08:31:09 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id CB74294038E for ; Wed, 10 Feb 2021 08:31:08 +0000 (UTC) Received: from localhost ([::1]:56134 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l9ktv-0000u0-O2 for larch@yhetil.org; Wed, 10 Feb 2021 03:31:07 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:45468) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l9kt1-0000tG-4z for guix-devel@gnu.org; Wed, 10 Feb 2021 03:30:11 -0500 Received: from flashner.co.il ([178.62.234.194]:53966) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l9ksz-0007ps-If for guix-devel@gnu.org; Wed, 10 Feb 2021 03:30:10 -0500 Received: from localhost (unknown [31.210.181.184]) by flashner.co.il (Postfix) with ESMTPSA id 79B3240224; Wed, 10 Feb 2021 08:30:07 +0000 (UTC) Date: Wed, 10 Feb 2021 10:29:21 +0200 From: Efraim Flashner To: raid5atemyhomework Subject: Re: ZFS on Guix Message-ID: References: <=5F1CLe9QSGsoMlu5WxBMXm4CbFLM=5FM9iRG1XQF9GDsK0GP208jpngdymfix4tAfoLP94mhMTt-Tx6OP2xN=5Fn78Jhx5KQzkiqPpIci=5F44C9OI=3D@protonmail.com> <5DEAAAD8-1D08-4489-9AEC-675618F8E388@zancanaro.id.au> <07kwAFNpjhGFe7ArkjjAtRhr564wvMPGhHFyjGb=5FXdmmPNddKTmT9Swky1NbbUxHBC4xw3p-m=5F3JyW16Ql9J7PLyk6UdhCsA2cdkHehdti8=3D@protonmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="f0UJLu1K6akEXrrX" Content-Disposition: inline In-Reply-To: X-PGP-Key-ID: 0x41AAE7DCCA3D8351 X-PGP-Key: https://flashner.co.il/~efraim/efraim_flashner.asc X-PGP-Fingerprint: A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Received-SPF: pass client-ip=178.62.234.194; envelope-from=efraim@flashner.co.il; helo=flashner.co.il X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAD_ENC_HEADER=0.001, BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "guix-devel@gnu.org" Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -3.96 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Queue-Id: CB74294038E X-Spam-Score: -3.96 X-Migadu-Scanner: scn1.migadu.com X-TUID: RM/7z3MFHBWH --f0UJLu1K6akEXrrX Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Feb 08, 2021 at 09:32:27AM +0000, raid5atemyhomework wrote: > > * the shepherd services defined in `configuration.scm` > > seem one-shot services to me, so maybe add '(one-shot? #t)'. >=20 > I was wary of making the `zfs-scan` one-shot, since there is a dependent = service on top of it. Not to mention restarting `zfs-scan` could be useful= if for example you were doing hotswapping of devices. Maybe. >=20 After a one-shot service 'happens' it is effectively in a 'stopped' state. So if something else comes along and requires it it will start it again. So if running 'zfs scan' can be considered a one-off action and it's ok if it's run when other services need it then making it a one-shot service is OK. >=20 > > * in the 'stop' of zfs-automount, the code changes the working > > directory. As it isn't restored afterwards, this doesn't seem > > kosher to me. Or maybe this isn't an issue at all. >=20 > The code is modeled after `file-system-shepherd-service` procedure in `gn= u/services/base.scm`, which includes a `(chdir "/")` as well with the comme= nt "Make sure PID 1 doesn't keep TARGET busy.". Since this also does files= ystem mounting/unmounting, I judged it best to imitate the existing filesys= tem mounting/unmounting service. Makes sense to me. >=20 > Thanks > raid5atemyhomework >=20 --=20 Efraim Flashner =D7=90=D7=A4=D7=A8=D7=99=D7=9D = =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --f0UJLu1K6akEXrrX Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAmAjmV4ACgkQQarn3Mo9 g1FRqw/9H3TJ2XcvfJFqzqNjGlf88mx8bj53vzq/ncJZtI2CpX8jCCEWNnAYg+So jI1AISsR57aSk9yHvvOso1xp2cwNizH82Z1ZhPzag1b1M+rauihSci6Yf2R6sYn8 iTJ0Dr1AS3jky7h5cfBrGy7g7zocax7FwCU0nVf+HlVADGGfneAL8NmavvDsQazs KlPlCW0KsNLcXDbekxAyEomePJXL1seu7aCg27hSkmMRAtx3EwEQ104meOAkO7xn zxI2qt7qN0annSb9wxwBNP0DdC+0aOvgXhbcqpGVFTCL9rFdYjQOgfPsieF/YtJi wM226JQBHtsaumA9OxBSaSXq3DNPQGUGkNyBD0eUQJTy/J2K56xif7q2IC8wunjU fEf7Pb6LmgJXTBbm/56FanSij4rStYoqEAp0pBz6vdCzZT45IOp4bko1tnZuO5SV MG4jERxFLWwA5ihRjDcK55gVDJJVb+Bv8Ke48GFH7PtHgRdhf6ZgubbH/cTzvAHv tYuqILkF/kl3/5WshzsmkjW+o8YHyV6kic9E+n6/1yJJdjWn1cxL0Y3EteE2TEql o3++4zTsnoapGUXqcG6Bon4YinuOlcR3wMT5Jm8bDEPCkcMQ0N3lpYzbmm3T80qR 9jrev4RdoZf+jFJwqC5/U8wKqEhnh2M8E0e4eJIduME/7jmgISw= =Xr1y -----END PGP SIGNATURE----- --f0UJLu1K6akEXrrX--