From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id ABm1Mco8vWPF1QAAbAwnHQ (envelope-from ) for ; Tue, 10 Jan 2023 11:24:10 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id CE6lMco8vWPLyQAAauVa8A (envelope-from ) for ; Tue, 10 Jan 2023 11:24:10 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 9AA0D1FCA9 for ; Tue, 10 Jan 2023 11:24:10 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pFA1s-000759-V0; Tue, 10 Jan 2023 03:30:45 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pFA1X-0006rX-45 for guix-devel@gnu.org; Tue, 10 Jan 2023 03:30:23 -0500 Received: from mail-wm1-x333.google.com ([2a00:1450:4864:20::333]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pFA1Q-0006ZZ-3T for guix-devel@gnu.org; Tue, 10 Jan 2023 03:30:19 -0500 Received: by mail-wm1-x333.google.com with SMTP id m26-20020a05600c3b1a00b003d9811fcaafso9193125wms.5 for ; Tue, 10 Jan 2023 00:30:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:sender:from:to :cc:subject:date:message-id:reply-to; bh=Jr+q+ILD3VmhIiuqhpzYlXsN4By0jxvhsSjbFl1VOPY=; b=PdVCk5aRqAfktANPKxb1vpIStddgKCUFBqVMc2PZwVeKn4oo86hHJtuOH9jIZebSHK HyuidVVhmHr8omcbT5A1nQ3b2hSZ30DGeLxYD+apbmXQjRQ0t1IU5suCS6DXxEQg2q+Q nB8mTvKMAISklislG5G+OeQsNOsSrrj4N2lqYf6g61QaidjLuawS0gdyoJ87I/CH986o NCoYBzhYnDB9rrMRhbI4kzeiQBCiRxrGzMP2x+l/OkfA7oGba1vt34tCDZsU1hyn66J7 9oT39i/kos7of8Kj4Pk4nFfDij5CG4Orkcs2lGgZ3/uDRjsVkYT0zaMssZkPK6uhfPpB VZjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:sender :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Jr+q+ILD3VmhIiuqhpzYlXsN4By0jxvhsSjbFl1VOPY=; b=yQA/UGy0mPTAUTKL5p2ILl306Gp69Qal8B5rnBWGC/qZPypiL79eyka8obFtmFyUWo MI6AIYZ/q1p79nqPhO3B6b5l/fqsb+UpB7PauDugzCz0v7cSOr9smQnLVWQYDxZJQlaR UOKTDlc6sjNwZk9jDMNgSnBq8XVFCuGNUwx/xOECb+EOS3zsaoRAyt+IFn2L1AmSH5X3 oNeowyn/yvtdj41oTmmibry0/W0pfv38VZJZTNsfApkRRYMi3O233AXVvsOxQ0BaZ3Vh dGJRgzV/u7k+IHDUQX4P0ToiuuBz4oOcb6LPs26XdbM4fyhMqJTLHPGeVes5HzYVswot BQTw== X-Gm-Message-State: AFqh2kqWMpQJHI5EthilRIuahBBbUarOGLDAkL2jZk06JVxDTHpCzYvG c5HAEGqhzPYObMLi+coS2o8= X-Google-Smtp-Source: AMrXdXszIp7N8vv6onUCaCW6fIKps/8sXpjgCrd2QmqYRJxWU93PZH5MLZXyC+P+PIUqxYQRBw3fmQ== X-Received: by 2002:a05:600c:1d98:b0:3d3:48f4:7a69 with SMTP id p24-20020a05600c1d9800b003d348f47a69mr58676394wms.17.1673339414244; Tue, 10 Jan 2023 00:30:14 -0800 (PST) Received: from localhost ([2a02:ed3:910:1100:b62e:99ff:fef0:7bc0]) by smtp.gmail.com with ESMTPSA id f14-20020adff58e000000b00241fea203b6sm10698772wro.87.2023.01.10.00.30.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Jan 2023 00:30:13 -0800 (PST) Date: Tue, 10 Jan 2023 10:30:11 +0200 From: Efraim Flashner To: Nicolas Graves Cc: guix-devel@gnu.org Subject: Re: skia for libreoffice Message-ID: Mail-Followup-To: Nicolas Graves , guix-devel@gnu.org References: <87k01xe0fg.fsf@ngraves.fr> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="NpNQeMyw1dtJFnc3" Content-Disposition: inline In-Reply-To: <87k01xe0fg.fsf@ngraves.fr> X-PGP-Key-ID: 0x41AAE7DCCA3D8351 X-PGP-Key: https://flashner.co.il/~efraim/efraim_flashner.asc X-PGP-Fingerprint: A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Received-SPF: pass client-ip=2a00:1450:4864:20::333; envelope-from=efraim.flashner@gmail.com; helo=mail-wm1-x333.google.com X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.096, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: guix-devel-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1673346250; a=rsa-sha256; cv=none; b=nHsK2R6z5Z37x18OOc5642XEE0ZAz9gWjR+zZr9mB3caFUD8qaiZgyZRiyCiEc69UQHBC8 XuYXtZLDrjd1tMsfMEIth0ignbAZzBkHnmB7REhmpm1PX3MB1Tqi5X5wYo8yb5rwb9m5/U 8291TesBy+1Srs4KYEZzUCmo2/5q9vvhtH4kXFVC7Qryyc3iZTdUCSbUeJIyWaJlow9iDh MCOwrN30zuCQRVMOpP3L8y7Ai+gRJW/4KjL2t3tkP5I6FHeVruN3/afjPy4Uu2uq09QSMC qh0tHCi7Kkr344nveQIMkCpFo7DS2ipSrUdgkBA07AnBcGTEq5Dzegs6a3X+QA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=PdVCk5aR; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1673346250; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=Jr+q+ILD3VmhIiuqhpzYlXsN4By0jxvhsSjbFl1VOPY=; b=ZXWvZsDrVmof/2gBgVzsu6toUAkbW6l41PXXvuZE3a97B/ocIxj86/r3VlEPBFZtJixLwn 1BtPVAxL/2u2LvCxYLbxmzP2g3dSBmLU7LZE4/clM1jPFzgE9nC5IL7OH6E3838/z+YyjB t5k4mop+O1wxOvY1jGrfVQQtHbaPuMxyzOlyDRoZZ1hE8dgzF6VOQaMo2d7m/ZVzrjPA8c zVCRShnBMeVxUXK1kNmreLSObl9ExQ+CCHj4QrN5dU3y31pPmvLULG7PL3x6urSHvhYI0o zXYYavbRdAQMpl2BFkQUqzpidqB4vIqINcDZNNiG6kHjPzcQPjo4YLvrP1px6Q== X-Migadu-Spam-Score: -3.48 X-Spam-Score: -3.48 X-Migadu-Queue-Id: 9AA0D1FCA9 X-Migadu-Scanner: scn1.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=PdVCk5aR; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=none X-TUID: fw0JuyfPMXbL --NpNQeMyw1dtJFnc3 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Jan 08, 2023 at 12:21:55PM +0100, Nicolas Graves via Development of= GNU Guix and the GNU System distribution. wrote: >=20 > Hi! > (please tell me if I should use another channel for such questions) >=20 > I recently have been working on enabling tests for skia and including > skia in libreoffice (see bug 60571 for the first part). >=20 > Now that I delve into libreoffice's build of skia, I see that there's a > series of patches that libreoffice use for the build of the > library. Which makes me wonder if it's worth it packaging a > "skia-for-libreoffice" package variant, or if we should just add the > tarball in the external directory as it has been done with dtoa, and > rely on libreoffice's build of skia. In the end, both versions will end > up in the store in any case, because of the patches libreoffice needs. >=20 > What is Guix policy in this case? It's a toss-up. skia-for-libreoffice wouldn't see any use outside of libreoffice since it's specific patches and not a different version of the library. In those cases (especially if the library is maintained upstream by the same people, which I don't think is the case here) we're far more lenient on leaving it bundled. On the other hand, separating it out would decrease the build time for libreoffice, which would be a Good Thing=E2=84=A2. IF (and I mean it) you can separate it out easily and it doesn't make building libreoffice with it then go ahead and do so, especially if the version and/or patches don't change regularly. Otherwise I'd consider adding a note in libreoffice's snippet (assuming it has one) or configure-flags about why we're not using an unbundled version. --=20 Efraim Flashner =D7=90=D7=A4=D7=A8=D7=99=D7=9D = =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --NpNQeMyw1dtJFnc3 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAmO9IhAACgkQQarn3Mo9 g1HpMBAAg4axawYg0YcyIGoS1tIoL670QddDNfzdTPg3sOxu70N92DD0bqfPWMgz 4BZiYeuTLYKLt5fnFaYYllRjLzM1SB/uNWICkWYWGJtgjsRoNMRuC3teEAxzOhyq 1esZlxt39+pUs9dzsvNEQH37MjOneYJp8SwVl/VC+wne88ILbp5cUwg1jJqpbHQ4 AGeNNbUPS5XTsKeH95XB47B1UzB+WMV9PqQRgPl0UTYaXDV095SjdWf/hropSW0t 8DBBedPrWN1/zc4NIIXVQ29PmlXx4EwLOUVvQgjjU3QzMrpITjV/ijzgMM8ydRFd riXKSiEVayQVX69VGGJoNBRYLRf+g2if7rZctbAcFpP6zKWxuK2pugiuP/DcwFYQ TABHIRlbBxVdQRWcsmc7kuzIkPrYrH3wZHos1xSnenqiRm3KNwHmwgAQWdmlD5BF QYYd0bKLPwL26NT781UGKlCIilJ6XYHQdrFI+PmNugAv9Fog1ogXBpzGagWbjegC p6b30HGk+8+4u/vEx9ojFXTznBa3PkiGXZZJeAPvZQysrlj5g0ojJj8fxWQflBfd djGfToDk3b9RuxxrkfJmO5Gj+9yQZfh9kvgVU6UvBF5ZOh3RpjMuGzNB2A+sJKjy 5GweRKX+J6IjusG/mG1JIqhdImuRG9P3iMpp653iA6tHCjSvi3A= =Uch9 -----END PGP SIGNATURE----- --NpNQeMyw1dtJFnc3--