From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id AMlYCwU/RGNflwAAbAwnHQ (envelope-from ) for ; Mon, 10 Oct 2022 17:49:25 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id kK2yCgU/RGM+NwAA9RJhRA (envelope-from ) for ; Mon, 10 Oct 2022 17:49:25 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id E7F172FED7 for ; Mon, 10 Oct 2022 17:49:24 +0200 (CEST) Received: from localhost ([::1]:59312 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ohv1w-0001T4-3f for larch@yhetil.org; Mon, 10 Oct 2022 11:49:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37448) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ohuxu-0006nS-5V for guix-devel@gnu.org; Mon, 10 Oct 2022 11:45:14 -0400 Received: from mout-p-201.mailbox.org ([2001:67c:2050:0:465::201]:48050) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_CHACHA20_POLY1305:256) (Exim 4.90_1) (envelope-from ) id 1ohuxr-0001L9-HR for guix-devel@gnu.org; Mon, 10 Oct 2022 11:45:13 -0400 Received: from smtp102.mailbox.org (smtp102.mailbox.org [10.196.197.102]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-201.mailbox.org (Postfix) with ESMTPS id 4MmNX808VWz9sQD; Mon, 10 Oct 2022 17:44:56 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6xq.net; s=MBO0001; t=1665416696; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=2zaZduqs7hPnBpDsx8q/msZvLAFWBLrgthL5ocy5m24=; b=XzrFCSIHOqwuzbj/1wjjJqTDHqVVSJrlSDq01+wgNP7Zg8gE8503w9McU/gf1X5h/0u4mW l59l3isYHeTaDbHD+uR+z0gPj17F2U3GYhXAonTCUEN7eELYvUwdwMtsOt8+Ym2WKZWpgX zA/dO1eZSecKv2IKdhf65QoiPfJgPfwpazlL4SjlFpnYokGDaEfex/eh+nAClngto2xmkv ZphGr9RWYJa3Ogdg2Dk9f7Zscx6p6IUevmZJB8/qsZU0b9GxGe9bAxWts1PwKXm36R8RqL rTr0/L2TuOD5OwVQ7s+QgFWZe4RZxVhIEw3Tgucoe+W0/SlYj1U2uFQg724feA== Date: Mon, 10 Oct 2022 17:44:51 +0200 From: Lars-Dominik Braun To: guix-devel@gnu.org Cc: maxim.cournoyer@gmail.com Subject: Re: 01/03: guix-install.sh: Improve prompt_yes_no procedure. Message-ID: References: <166514571663.3366.6547940820636399037@vcs2.savannah.gnu.org> <20221007122837.15E56C0CD93@vcs2.savannah.gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221007122837.15E56C0CD93@vcs2.savannah.gnu.org> Received-SPF: pass client-ip=2001:67c:2050:0:465::201; envelope-from=lars@6xq.net; helo=mout-p-201.mailbox.org X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1665416965; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=2zaZduqs7hPnBpDsx8q/msZvLAFWBLrgthL5ocy5m24=; b=oEXpH/7Hc+dK6xRLY6c+8ICPsrrBO5AepIAE0I0tNN0Qw7dbXbjJFEsxNry932uQMLdUfQ 20EK6bcg7M2i/0mhdPlcomi7s8EhfmAiu+2Fl7DxCQ24BIei7zFmqDsG9houc9v0ZEIV3p 78CoW+8iB5wTYZGV1DYdJQM5VX9odmfav8zvQLyTRFOLUlVxxPw7k+x4d4MLPq5tWrE8Ge d8PAooV22kRRkkpi+7rfRqBRTzGy0lNleydr3upumVgNcCaxuD7yBXusqKS8LWQ9RCNeWM IGSJArpVUd3Yg/e97Hkr+2ncUz4FO2tYRDwpiydNyaNaA/EvWh7S9UCpPvtGew== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1665416965; a=rsa-sha256; cv=none; b=Bsjx5isgYm33gJTtwMHH4wbTnhgrZGaQd3oPjqXuCxk8audsESJmncdW9OGTaIJgF5IVpf /pZcsNI1oIJ0W/RT2rKo23snWq+3MJX9kbSVAoBiz5qjWi7xoJaAQEDz6XRRzfhHfYgsh7 2NIeSs+BLkXXwOuFDC5fhl2AvhQvM//3TguDvcrRuoR+Jpa9NtXdrQcDCvoB87bHunRMa9 9piwXsmO20pjlfPNumyHgmuKpSg7Xx1pUtI2ZghU49qdDy83IvUfmlRD91bMl3spANUHVo 0gNMbPRi40uKahHdd/cBXKVFIy8cRIaQKB8dMDtThPtNcyfwELA3AFwnv8UUXw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=6xq.net header.s=MBO0001 header.b=XzrFCSIH; dmarc=pass (policy=none) header.from=6xq.net; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.99 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=6xq.net header.s=MBO0001 header.b=XzrFCSIH; dmarc=pass (policy=none) header.from=6xq.net; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: E7F172FED7 X-Spam-Score: -3.99 X-Migadu-Scanner: scn1.migadu.com X-TUID: BmN4n+M6WyjM Hi Maxim, > commit 6a2e303d3a49baf7c222a70b91f453e9efd456c6 > Author: Maxim Cournoyer > AuthorDate: Wed Oct 5 21:48:25 2022 -0400 > > guix-install.sh: Improve prompt_yes_no procedure. > > * etc/guix-install.sh (_flush): New function. > (prompt_yes_no): Clear input, then only read the first character, silently. > Add the [Yes/no] string to the message. When a newline is entered by the > user, treat it as the default value, which is "yes". > (chk_gpg_keyring): Remove "(yes/no)" from the prompt message. > (configure_substitute_discovery): Likewise. > (sys_authorize_build_farms): Likewise. I got a report here[1] that this refactoring broke my GitHub action, which simply pipes `yes` into guix-install.sh. Thus all pipelines depending on https://github.com/PromyLOPh/guix-install-action are (again) broken. Shall we revert this or do you have a quick fix at hand? Lars [1] https://github.com/PromyLOPh/guix-install-action/issues/16