From: Lars-Dominik Braun <lars@6xq.net>
To: guix-devel@gnu.org
Cc: maxim.cournoyer@gmail.com
Subject: Re: 01/03: guix-install.sh: Improve prompt_yes_no procedure.
Date: Mon, 10 Oct 2022 17:44:51 +0200 [thread overview]
Message-ID: <Y0Q981BROASboLxD@noor.fritz.box> (raw)
In-Reply-To: <20221007122837.15E56C0CD93@vcs2.savannah.gnu.org>
Hi Maxim,
> commit 6a2e303d3a49baf7c222a70b91f453e9efd456c6
> Author: Maxim Cournoyer <maxim.cournoyer@gmail.com>
> AuthorDate: Wed Oct 5 21:48:25 2022 -0400
>
> guix-install.sh: Improve prompt_yes_no procedure.
>
> * etc/guix-install.sh (_flush): New function.
> (prompt_yes_no): Clear input, then only read the first character, silently.
> Add the [Yes/no] string to the message. When a newline is entered by the
> user, treat it as the default value, which is "yes".
> (chk_gpg_keyring): Remove "(yes/no)" from the prompt message.
> (configure_substitute_discovery): Likewise.
> (sys_authorize_build_farms): Likewise.
I got a report here[1] that this refactoring broke my GitHub action,
which simply pipes `yes` into guix-install.sh. Thus all pipelines
depending on https://github.com/PromyLOPh/guix-install-action are (again)
broken. Shall we revert this or do you have a quick fix at hand?
Lars
[1] https://github.com/PromyLOPh/guix-install-action/issues/16
next parent reply other threads:[~2022-10-10 15:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <166514571663.3366.6547940820636399037@vcs2.savannah.gnu.org>
[not found] ` <20221007122837.15E56C0CD93@vcs2.savannah.gnu.org>
2022-10-10 15:44 ` Lars-Dominik Braun [this message]
2022-10-10 16:26 ` 01/03: guix-install.sh: Improve prompt_yes_no procedure zimoun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y0Q981BROASboLxD@noor.fritz.box \
--to=lars@6xq.net \
--cc=guix-devel@gnu.org \
--cc=maxim.cournoyer@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).