From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id 4GGxKr8N7mMt6wAAbAwnHQ (envelope-from ) for ; Thu, 16 Feb 2023 12:04:31 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id WEHIKr8N7mM0zAAA9RJhRA (envelope-from ) for ; Thu, 16 Feb 2023 12:04:31 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 0ABBF5B94 for ; Thu, 16 Feb 2023 12:04:30 +0100 (CET) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=QU+wX0CM; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1676545471; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=F2gqv76vGcH+wVwcUmA7cx7I4IzODAmdC2VruumuS/I=; b=SBsYT+E4lIJAnHGIjxGekGbA8dpNyRwWRvfhNos9Iw4BgTGST5DoqPmFVWTBIHZE/WByPp TzsPI93VefNOu+gUxKwzmVH6AZuCiauXYpryRs0iiCnnD4zRK9OzIMqbratlUlBleMOJkU UO8FomL9kINUkInkGpuZykGMIAvEqECE0TB3TleG9AsgzNcLYyxSwCusXE5R+DElB9NZ5O KuXvEsddD5pg3bfhrx2EB8GFuoQhXLulFYUL01+Y9wZlIxLiYQRH6uGzwj4bj3/drM2msC eSCLMhadhrzmYmO6k6trCS3XWAOv2sbaxDBc8zbOQOiT5hsgGiCEonlBwIghnA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=QU+wX0CM; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1676545471; a=rsa-sha256; cv=none; b=RWt/Av5qyjaTf7A3BGWuS4X9/MJ0aTLMmEjeQuFlUiNwFU+jiBysyZNQFgPVsrL7ZOLXjk CQiovmv5s2opI1W4zf70GhZvznyMwQ6VnucFe/B6y5UidJncU+WdcmEVGdJUO11Zfc1HQ1 6dWhRr1th/qAvJ977S+XVr0hsvwu9XxkeRe4M/2HQsG6x5zQz+qTGX20V1Uvr+f5NZlFRm zKVjr8YQxU2gRYWbQiHGNvxQBVrrPgjbjMzkSG+Qj7+JvmRIEjhIERhIQlbXpQkbtz90q4 4rHXcYH5I+6E2XEYeLjfN+0NEstfuy1//IY6nNs2DQCTM+bJ0XgHbrqq+oswXA== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pSc3S-0003WG-VF; Thu, 16 Feb 2023 06:03:58 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pSc3Q-0003Vj-CM for guix-devel@gnu.org; Thu, 16 Feb 2023 06:03:56 -0500 Received: from mail-wr1-x42d.google.com ([2a00:1450:4864:20::42d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pSc3O-0007dv-07 for guix-devel@gnu.org; Thu, 16 Feb 2023 06:03:55 -0500 Received: by mail-wr1-x42d.google.com with SMTP id m10so1463371wrn.4 for ; Thu, 16 Feb 2023 03:03:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:sender:from:to :cc:subject:date:message-id:reply-to; bh=F2gqv76vGcH+wVwcUmA7cx7I4IzODAmdC2VruumuS/I=; b=QU+wX0CMYoE7wx9JA1olh6rGww/9DQPs/6B/8zj0JC9Ch87o6auhSMo04j9Y9nfsrL W0w11hfO1miH+aKNcuyE9Dq+S3CW9UeXSoluHE5RJo155c0Oou6d/YTWbX4S/1m/rOPR Fl6bNklzVBuC6gfT8KKk2m7Qn0a43OGFa4MECZbjZm8L9NJ/cy3FamZ5bW0ACwMPB5bJ FDznArG5w+su3mYSGyXiD67NOZcEdAYOYjX5vnt5PYrbGzvDavIS6QarGhVCrgYxP6YW dCEz1CSDiCsY/GEHuttB0F9ZlatpLMKgi8dBrsSaIn+TpGYSXD1IFGQ0DnmzDWqVepPS smjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:sender :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=F2gqv76vGcH+wVwcUmA7cx7I4IzODAmdC2VruumuS/I=; b=bwFlbNIx5JGyL0YWS8tk/Wh7Xy6RThuA6PZSEKlYfQZIZWJV2f9any7lfHy3QWit6D UXWAz3BHJDk9+wpNrCdESjJHvXWCptGinXhBLHvDQj0o3aUpBDN1wFhhwHBVVS8Rwhs0 G+46dX+ZUZP6H5rG+zOAvzU9LcVlVOtkGKxhII9R4kRdLO7v0HP2g+YaJVu1vHu6LJ1v cUDCW4UnLkY4d8eMXWbcxWhEuCX6z5y2ZcOQhsv9kD/3+Oln5abyDy8GGmthqEktZJw8 v9aY2h4YWeAbuyzUf9zykPRv6nNiDVWDEMKMp0F42x+t74Imisik6F7q1Kc9SPZdBwRt dgyw== X-Gm-Message-State: AO0yUKUrmAZfLuU+l/7aBqEbIjcCdhAVPw20VnteZusGmU4NZYuRS3R2 KSY65k4B8XMvDmQwrAzw45U= X-Google-Smtp-Source: AK7set+/+mvlotSBzvkDkiOBHFq5yCImNMl23K1Mq8ZdfMeP1fq2CFhNagqnhNa1zD8MnTFtKXcq/Q== X-Received: by 2002:a5d:5010:0:b0:2c5:7de8:212b with SMTP id e16-20020a5d5010000000b002c57de8212bmr1478502wrt.45.1676545430688; Thu, 16 Feb 2023 03:03:50 -0800 (PST) Received: from localhost ([141.226.15.115]) by smtp.gmail.com with ESMTPSA id k9-20020adfd849000000b002c3f50228afsm1198691wrl.3.2023.02.16.03.03.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Feb 2023 03:03:49 -0800 (PST) Date: Thu, 16 Feb 2023 13:03:35 +0200 From: Efraim Flashner To: Andreas Enge Cc: Julien Lepiller , guix-devel@gnu.org Subject: Re: Openjdk (was: Merging core-updates?) Message-ID: Mail-Followup-To: Andreas Enge , Julien Lepiller , guix-devel@gnu.org References: <20230212100540.2214f16c@sybil.lepiller.eu> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="kDflEE/WrB/hdUfd" Content-Disposition: inline In-Reply-To: X-PGP-Key-ID: 0x41AAE7DCCA3D8351 X-PGP-Key: https://flashner.co.il/~efraim/efraim_flashner.asc X-PGP-Fingerprint: A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Received-SPF: pass client-ip=2a00:1450:4864:20::42d; envelope-from=efraim.flashner@gmail.com; helo=mail-wr1-x42d.google.com X-Spam_score_int: -14 X-Spam_score: -1.5 X-Spam_bar: - X-Spam_report: (-1.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: X-Migadu-Queue-Id: 0ABBF5B94 X-Spam-Score: 0.18 X-Migadu-Spam-Score: 0.18 X-Migadu-Scanner: scn0.migadu.com List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: guix-devel-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-TUID: Fd10UYtrvMXR --kDflEE/WrB/hdUfd Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Feb 15, 2023 at 08:19:08PM +0100, Andreas Enge wrote: > Am Wed, Feb 15, 2023 at 07:51:56PM +0100 schrieb Andreas Enge: > > Actually the patch has already been applied to openjdk13, if I am not > > mistaken. So I do not understand how the source could be built in master > > then, while the exact same code (?!) fails on core-updates... >=20 > Well, there is a somewhat hidden difference. > core-updates introduces > "openjdk-10-hotspot-pointer-comparison.patch" > "openjdk-10-hotspot-stack-size.patch" > to openjdk10. >=20 > openjdk11 is a package of its own without the patch. >=20 > openjdk12 uses the newly defined make-openjdk to start from openjdk11, > overwriting the source together with openjdk-10-hotspot-stack-size.patch > in core-updates, and without the patch in master. (And it uses an obscure > tarball instead of a git checkout - why?) >=20 > openjdk13 has the same code in core-updates and master: > (define-public openjdk13 > (make-openjdk openjdk12 "13.0.13" > "0pxf4dlig61k0pg7amg4mi919hzam7nzwckry01avgq1wj8ambji")) > So in core-updates it inherits the patch from openjdk12, in master > it does not (I think). And then I suppose it passes the patch on to all > its descendants. It's definitely possible that the master->core-updates merge messed with the package definitions and the inheritance and I didn't notice it. > The following seems to work and create source for openjdk13 and later: > (define-public openjdk13 > (make-openjdk openjdk12 "13.0.13" > "0pxf4dlig61k0pg7amg4mi919hzam7nzwckry01avgq1wj8ambji" > (source (origin > (inherit (package-source base)) > (patches '()))))) >=20 > Okay to push if I manage to build current openjdk with it? Yeah, that's probably fine. > Is it necessary to keep all these version of openjdk and to bootstrap > version n with version n-1? Probably? I assume if you can cut some out that'd be ok. I'm pretty sure openjdk-11 and openjdk-17 are considered LTS by upstream so it would make sense to keep those specifically. --=20 Efraim Flashner =D7=90=D7=A4=D7=A8=D7=99=D7=9D = =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --kDflEE/WrB/hdUfd Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAmPuDYEACgkQQarn3Mo9 g1Elvg//f36vh46gVzjOBiWRRYl0zIKdZjbRrf7B0QZnBgpqHC4z3AA//+Hm26Jx I+UuPr+M7UnXLJ6rgTtE2+8D2lAr0xGfldzAAxEjKlM6mkqzUbRC6T0NpuNmUB1d EgFID1ZJpn56L5+Ekzvvk4wQusqqBrgJPjjfdVrk2njVLcO5tScq1ibF3waNwRXt 9slwKE5hCiyu1BQFV8WT9cxaexRf5p2gZAEJ2NJ410ptv31BXeKBLEaoK/D5gDJT RD3SN04F/e+zVOQb978wAdcw8cIwjhB+0FodmKrAKFjlDjdhIepVrtqocVBk9YcW gLRQru3836WaifLTQ8R12CfgV1SB12ZGi/kn84JodD4wEaT28i+wD8Y+65z+jY/+ 01+br4C5mFu71O5tDBBbVhVIbD1XGxrIspBxipLQbzjB8O3ADF3mFRMlNihSFTJG L9T3atuLjyWGyhsxdtPbNtkdv2NuHu8B2hv5A7pOT9hBj6q9wccom8XTywhHBQXh dCe9xLH9lFk4mJck1APFvgeuud/VuPhOqCg/uadHH9gh6HUPNP7xRVEDKnJ3xEpT fLeLqav6eE4NeAtgGahez72Ih0heGaQF2GB+xR47byKOifgie9xWe17jMJQY2/3Q W16KkxXCapnf+ypECm6+9CWigiwKHI41mWPItlUolrSJB5V1+nA= =Zhxc -----END PGP SIGNATURE----- --kDflEE/WrB/hdUfd--