From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id kPoXOkkB/WMdkQAAbAwnHQ (envelope-from ) for ; Mon, 27 Feb 2023 20:15:22 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id yGP+OUkB/WP4XAAAauVa8A (envelope-from ) for ; Mon, 27 Feb 2023 20:15:21 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 755D28CC3 for ; Mon, 27 Feb 2023 20:15:21 +0100 (CET) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=KFn4ryL9; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Seal: i=1; s=key1; d=yhetil.org; t=1677525321; a=rsa-sha256; cv=none; b=if89ymZLUCItWwWEhJpW8ihV7+dU+zcdo8UVzwzB+ddQb+5tVt84Q/O6KspTyQ2tE06RLt jy9zbhBcYdFPQHzEoYDzEBYZtR7R5YEwXhg6wKncN0J0P7YCOYZ6TuULZew8sV+B7hD8L5 X5KdHxMpvC57eYyylKRyrfOtdivvZ0WwiNwlcLiESElTA3kpJTPUz4izqpi0ihSnBYO6nV lh7KWib1a23zdwmq0GJY9MGMuOIL7CCp1o7jdH4LqiV6SowxYkIHEK4fiZp4kzSOhB1cp8 69vHSrPcLIMyg/q1THbvXXUmEUhSwgiRv+cK5r3VVhBPuhdLj6Bk1zXo9YtCYQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=KFn4ryL9; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1677525321; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=SOJuvn0Vn4zSUauK68yQMJ7yUQp+8Ce0+46v2rWS844=; b=WevW5cI39dlV5PkL6QX2MNGcMILQyQvdl9FUi3zp+MH23FfTbI3/DKYAJ/8cFcOJASGE3f TioZfw4MqPKzBIETJ8u2AEbhdeFuD91/2QqkP/trXJXgcvpLjvlONq+YXtnYdxpNSIzr+u rtoeYyXBjL+lI9v+IcYNyKRTPTsMx1O6ab0HUsIbRzXrESTAZKyYhPQraN/cjLBzq+B681 u5uop2w/bMiWCIpPn5h5hplll1jQ0BbGBfYQX4S+i6ADVvByOp2uCkxooPEpaKm1mgMQ4Q g27GoMrpkLLM5O5BwYKCNa5gkY82vz1qlw7ZIZuv3CgNC1CAPeYnXHEp1CxUyg== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pWixn-00059Q-FG; Mon, 27 Feb 2023 14:15:07 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pWixl-00058q-R7 for guix-devel@gnu.org; Mon, 27 Feb 2023 14:15:05 -0500 Received: from mail-ed1-x52a.google.com ([2a00:1450:4864:20::52a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pWixk-0007uF-1J; Mon, 27 Feb 2023 14:15:05 -0500 Received: by mail-ed1-x52a.google.com with SMTP id ee7so30237527edb.2; Mon, 27 Feb 2023 11:15:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:sender:from:to :cc:subject:date:message-id:reply-to; bh=SOJuvn0Vn4zSUauK68yQMJ7yUQp+8Ce0+46v2rWS844=; b=KFn4ryL9cAMAoj2N0m6ax4rA0lZs+BuEswGEkrSd0EoQutv03IUCRCAeTxLl2nkRsW EtIhqCY8/Q/3f5oKDLl0iqqU6TTHUdbvE26nTXY05jVsCW5h64XV7G1euJwHbLomksjD RMPRGyObusM0qt3A1GkaqtrAEj5B8RoXLRjw6Fybl6DqncGTKjXyEgmHJY8/xnWPfWvp qod0znhQxO7VjQo7TdyuV9ubKEgkbBpoQnJ/DdQFwS/ANwpoRbQzokDka3CXzDCTpfWd o4z7V24ElY6mjQHo7uciSFcN56W85Ls4Coyu2NtR0dQRzxHG4fZJXqcQzJeCBHX/4kZZ 7l6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:sender :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=SOJuvn0Vn4zSUauK68yQMJ7yUQp+8Ce0+46v2rWS844=; b=JWtE/fnLo/IPtOYZx1YSnKef00eORGwLf7ghz2ccl27C1IAfI4K75QCMH8vW5Lor0M Aj4itJIxuxUMtG3GAT1Mk60l9pU9JVCIld5LgVF1PLfAaHFCRDslEGMH+1Hk2CJb0wEY MDl6HZBnFZIIlvmA3DkRs62XqnOkcX24DoVYOQE9l92um3CSgUfV29vK2dHbud+GOr9n 0V8gbKSzlwCUwtrHawc0pjmB+pq20rPH1Dzr19UNKXBbvXQKEU75uy7/0JC/YfoCASu5 m/Pn6ad8Nii6cxjDgKZY+uPwWd+GKj9ipiHxh1hAcmQsARgxhVLo5Ti7it5f0qMvG7yo 4JsA== X-Gm-Message-State: AO0yUKUN6BTYitC+RmIHj0lQ0EbP5Jo6Kk6fbWx9MvnmdEacQcYgEt0L GWF9HJykcmw0xmsDYnKOEok= X-Google-Smtp-Source: AK7set8RD4P2SnYsMBtB2kFShCKMq8p/793/T/KVXmUPRnynds9vCdlB1YowfYgUMuzDPwQ6ATAQ9g== X-Received: by 2002:a17:906:b356:b0:886:7e24:82eb with SMTP id cd22-20020a170906b35600b008867e2482ebmr34646577ejb.21.1677525301587; Mon, 27 Feb 2023 11:15:01 -0800 (PST) Received: from localhost ([2a02:ed3:910:9200:b62e:99ff:fef0:7bc0]) by smtp.gmail.com with ESMTPSA id r5-20020a1709064d0500b008b17ca37966sm3612524eju.148.2023.02.27.11.15.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Feb 2023 11:15:01 -0800 (PST) Date: Mon, 27 Feb 2023 21:14:59 +0200 From: Efraim Flashner To: Maxim Cournoyer Cc: Ludovic =?utf-8?Q?Court=C3=A8s?= , guix-devel Subject: Re: Feedback on indentation rules (was: [PATCH 0/5] Add support for the RPM format to "guix pack") Message-ID: Mail-Followup-To: Maxim Cournoyer , Ludovic =?utf-8?Q?Court=C3=A8s?= , guix-devel References: <20230203221409.15886-2-maxim.cournoyer@gmail.com> <20230203221409.15886-5-maxim.cournoyer@gmail.com> <87357alp9n.fsf_-_@gnu.org> <878rgxws6l.fsf@gmail.com> <871qmg5qpj.fsf@gnu.org> <877cw8hvlk.fsf_-_@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="UaNHm+69xx9XgWFP" Content-Disposition: inline In-Reply-To: <877cw8hvlk.fsf_-_@gmail.com> X-PGP-Key-ID: 0x41AAE7DCCA3D8351 X-PGP-Key: https://flashner.co.il/~efraim/efraim_flashner.asc X-PGP-Fingerprint: A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Received-SPF: pass client-ip=2a00:1450:4864:20::52a; envelope-from=efraim.flashner@gmail.com; helo=mail-ed1-x52a.google.com X-Spam_score_int: -14 X-Spam_score: -1.5 X-Spam_bar: - X-Spam_report: (-1.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: X-Migadu-Queue-Id: 755D28CC3 X-Spam-Score: -2.59 X-Migadu-Spam-Score: -2.59 X-Migadu-Scanner: scn0.migadu.com List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: guix-devel-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-TUID: xV+65EH5XsW2 --UaNHm+69xx9XgWFP Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Feb 23, 2023 at 05:20:55PM -0500, Maxim Cournoyer wrote: > -CC bug#61255 > +CC guix-devel >=20 > Hi Ludovic and guix-devel readers, >=20 > Ludovic Court=C3=A8s writes: >=20 > > Hi, > > > > Maxim Cournoyer skribis: > > > >> Ludovic Court=C3=A8s writes: > >> >=20 > [...] >=20 > >>> I=E2=80=99m not convinced by the indentation rule for =E2=80=98gexp->= derivation=E2=80=99 added > >>> in 82daab42811a2e3c7684ebdf12af75ff0fa67b99: there=E2=80=99s no reaso= n to treat > >>> =E2=80=98gexp->derivation=E2=80=99 differently from other procedures. > >> > >> The benefit I saw was that writing > >> > >> (gexp->derivation the-name > >> #~(begin > >> (the > >> (multi-line > >> (gexp))))) > > > > I understand, but you know, it=E2=80=99s best to avoid unilaterally cha= nging > > established conventions. :-) > > > > If and when there=E2=80=99s consensus about this change, (guix read-pri= nt) > > should be updated. >=20 > OK. I'm not against soliciting more opinions; I'm CC'ing guix-devel, > hoping some opinionated individuals tip in on this 2021 > 82daab42811a2e3c7684ebdf12af75ff0fa67b99 commit, more specifically, the > part that change the indentation rules for .dir-locals.el like this: >=20 > --8<---------------cut here---------------start------------->8--- > + (eval . (put 'gexp->derivation 'scheme-indent-function 1)) > --8<---------------cut here---------------end--------------->8--- >=20 > In the same spirit there was also > b1c25e2ce364741d1c257d3bb3ab773032807a80 (".dir-locals.el: Add > indentation rule for computed-file.") made more recently (last month). >=20 > The idea was to be able to format gexp->derivation like this: >=20 > --8<---------------cut here---------------start------------->8--- > (gexp->derivation "check-deb-pack" > (with-imported-modules '((guix build utils)) > #~(begin > (use-modules (guix build utils) > (ice-9 match) > (ice-9 popen) > (ice-9 rdelim) > (ice-9 textual-ports) > (rnrs base)) > [...] > --8<---------------cut here---------------end--------------->8--- >=20 > Rather than like this: >=20 > --8<---------------cut here---------------start------------->8--- > (gexp->derivation "check-deb-pack" > (with-imported-modules '((guix build utils)) > #~(begin > (use-modules (guix build utils) > (ice-9 match) > (ice-9 popen) > (ice-9 rdelim) > (ice-9 textual-ports) > (rnrs base)) > --8<---------------cut here---------------end--------------->8--- >=20 > (or having to use another 'builder' variable, for example). >=20 > What do you all think? The second one is waaaay to indented. For myself I sometimes end up wrapping the lines (although I don't love it) so it looks like this: (gexp->derivation "check-deb-pack" (with-imported-modules '((guix build utils)) #~(begin (use-modules (guix build utils) (ice-9 match) (ice-9 popen) (ice-9 rdelim) (ice-9 textual-ports) (rnrs base)) --=20 Efraim Flashner =D7=90=D7=A4=D7=A8=D7=99=D7=9D = =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --UaNHm+69xx9XgWFP Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIyBAABCAAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAmP9ATMACgkQQarn3Mo9 g1FQLQ/0DG8NMzGslsneSucFrRZtbTSntvxZlm8DWy7p+A8psl01KMQYdd5LVy1b DXVdaDSjHI6Lvgvs10ZLByOm4n8zFQliJhwo9q5zN/HJMqfWVCCnwqBVHL4QWeYV ArXSC+XR2youQnMq/WiS1o6QMI+ddydAkk3chLXVEdfesoCOJSDKheiDwdG/5Pyg puHZrDhaU9TBguguaNJVsa8vLWtX5LGz82i7PQgW5K9btQJgXEXi//YbGjCW6KXH ikwc8J1huR+3iZgdMxnRmccECdAO2P7k6/LRYQzsssRLoUR1q82ubU2QfY5zjZQS iUmxfAZ2bo2lGnCsTvBxTmIFqmfbO14ImCaHFz6eT4iEvc1cVrM5CBCPd6VGF4st AjOir9aVZnlYdgxOZoEvT1oaVjzmji1xtPpEvKn4Xqui27P9PPExTlWrVTzIC+r0 e8G4EqNLFOi9DI8tFsuZnP0wXV4bQGxL6qKdL3a3tyzMg40RPGQq+bTcAjluKlLn wBd9JLEzws3uV756jMW/vYcLBXYtZ7z+ZVNANdNwlwfu1vhDZ7eMgjbTQ/ipaWJI MFvccSDRZWm2Ed3ZVpBCeKm3isKIeZn1ySL+f03RSiST40H42KQGtBXoxFrXSs3Z 4PlCLRxV1LVxbLyJuHYn8Q805QgXdAWzaiExJePNxYiD3HPfbA== =9JnQ -----END PGP SIGNATURE----- --UaNHm+69xx9XgWFP--