From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id cKsPKlYv9F+TFgAA0tVLHw (envelope-from ) for ; Tue, 05 Jan 2021 09:20:22 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id ltrlJVYv9F9JAQAA1q6Kng (envelope-from ) for ; Tue, 05 Jan 2021 09:20:22 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 6A2339404CD for ; Tue, 5 Jan 2021 09:20:22 +0000 (UTC) Received: from localhost ([::1]:55480 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kwiVp-0006IW-7g for larch@yhetil.org; Tue, 05 Jan 2021 04:20:21 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:57966) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kwiVY-0006II-Pc for guix-devel@gnu.org; Tue, 05 Jan 2021 04:20:04 -0500 Received: from mout-p-201.mailbox.org ([80.241.56.171]:25004) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_CHACHA20_POLY1305:256) (Exim 4.90_1) (envelope-from ) id 1kwiVN-0006vZ-Ga for guix-devel@gnu.org; Tue, 05 Jan 2021 04:20:02 -0500 Received: from smtp2.mailbox.org (smtp2.mailbox.org [IPv6:2001:67c:2050:105:465:1:2:0]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-201.mailbox.org (Postfix) with ESMTPS id 4D96QW0ptxzQl9v; Tue, 5 Jan 2021 10:19:47 +0100 (CET) X-Virus-Scanned: amavisd-new at heinlein-support.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6xq.net; s=MBO0001; t=1609838385; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kNicPqBoxUJ9fS67UstQrQGyfsZQkqqUJC4G4HPsN74=; b=Q0sz2qcPpwHc9PlZDbiJvypSk0a+ipJWhiJHYpDaP3HwCh10zLZJdvI35Bln9mYjwu3Tm4 Q9gROHdM0DChougMLzajH3smez1EzyZqIbMESNegbFZafNEEpiDG9XWRGa7W7UDHo5wl2P DxP9LYWTvpSkO2e+xHaCPyRT3IPQu0M2iEMnqbAQmdJeW9+WQwumOSkAnb9NahaySaMwPw bTNqhjstrGFRGvDhP06XcyUzgzkjKQINjtDqiWt1ozDdJkc2ioascpCo+cDZJjORlLMlXX HZ86thWy17sSrLKuAl0u4Hm2X4HYisC2vAedisZH+6CHDeYq1k9EoJGDyi1Myg== Received: from smtp2.mailbox.org ([80.241.60.241]) by spamfilter03.heinlein-hosting.de (spamfilter03.heinlein-hosting.de [80.241.56.117]) (amavisd-new, port 10030) with ESMTP id D3vxNlveFvCc; Tue, 5 Jan 2021 10:19:44 +0100 (CET) Date: Tue, 5 Jan 2021 10:19:42 +0100 From: Lars-Dominik Braun To: Hartmut Goebel Subject: Re: [RFC] Improve Python package quality Message-ID: References: <11b7fa96-1ae8-bc1f-6c11-58f4abfb57b7@crazy-compilers.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <11b7fa96-1ae8-bc1f-6c11-58f4abfb57b7@crazy-compilers.com> X-MBO-SPAM-Probability: X-Rspamd-Score: -0.71 / 15.00 / 15.00 X-Rspamd-Queue-Id: 23C9A17B2 X-Rspamd-UID: 0de282 Received-SPF: pass client-ip=80.241.56.171; envelope-from=lars@6xq.net; helo=mout-p-201.mailbox.org X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: guix-devel Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -1.24 Authentication-Results: aspmx1.migadu.com; dkim=fail (headers rsa verify failed) header.d=6xq.net header.s=MBO0001 header.b=Q0sz2qcP; dmarc=fail reason="SPF not aligned (relaxed)" header.from=6xq.net (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Queue-Id: 6A2339404CD X-Spam-Score: -1.24 X-Migadu-Scanner: scn0.migadu.com X-TUID: mPVHOmsQ+ijc Hi Hartmut, > this is a good idea. (Since you where mentioning setuptools, I first was > afraid your solution would be tightened to setuptools, but it is not. > Well done!) afaik pkg_resources is technically a part of setuptools, although it is distributed with Python. > This comment should go behind the line of code, as it only related to > that single line. > […] > I suggest putting the comments into the python source. This would allow > to indent them according the the python code, which would make it easier > to understand. This would also allow to use a single multi-line > guile-string, which allows to easiyl copy the script out and in from the > guile-source for testing it. > […] > Please follow PEP8 (no space before opening parentheses) - also at other > places. > […] > Add `end=""`, thus the "result" can be printed on the same line. > Print result terse, on same line, without repeating the name: You’re right, all fixed. I’ll send a non-hacky patch (with test-cases!) to guix-patches@ for review once we’ve figured out a path to merge it. I guess it would be best to fix packages directly on master and merge this new phase to core-updates? Shall I apply for commit access or can you (or Tobias?) review and “proxy” required changes? Right now I have fixes for about 10 packges, but there will be more. > Would is be better to use mkdtemp here to ge a fresh, empty directory? I tried that, but mkdtemp! is not available and I’m not confident enough to add that module to the closure. Any ideas? Cheers, Lars