From: Lars-Dominik Braun <lars@6xq.net>
To: Hartmut Goebel <h.goebel@crazy-compilers.com>
Cc: guix-devel <guix-devel@gnu.org>
Subject: Re: [RFC] Improve Python package quality
Date: Tue, 5 Jan 2021 10:19:42 +0100 [thread overview]
Message-ID: <X/QvLtfxp+/yz/7G@noor.fritz.box> (raw)
In-Reply-To: <11b7fa96-1ae8-bc1f-6c11-58f4abfb57b7@crazy-compilers.com>
Hi Hartmut,
> this is a good idea. (Since you where mentioning setuptools, I first was
> afraid your solution would be tightened to setuptools, but it is not.
> Well done!)
afaik pkg_resources is technically a part of setuptools, although it is
distributed with Python.
> This comment should go behind the line of code, as it only related to
> that single line.
> […]
> I suggest putting the comments into the python source. This would allow
> to indent them according the the python code, which would make it easier
> to understand. This would also allow to use a single multi-line
> guile-string, which allows to easiyl copy the script out and in from the
> guile-source for testing it.
> […]
> Please follow PEP8 (no space before opening parentheses) - also at other
> places.
> […]
> Add `end=""`, thus the "result" can be printed on the same line.
> Print result terse, on same line, without repeating the name:
You’re right, all fixed. I’ll send a non-hacky patch (with test-cases!)
to guix-patches@ for review once we’ve figured out a path to merge it. I
guess it would be best to fix packages directly on master and merge this
new phase to core-updates? Shall I apply for commit access or can you
(or Tobias?) review and “proxy” required changes? Right now I have fixes
for about 10 packges, but there will be more.
> Would is be better to use mkdtemp here to ge a fresh, empty directory?
I tried that, but mkdtemp! is not available and I’m not confident enough
to add that module to the closure. Any ideas?
Cheers,
Lars
next prev parent reply other threads:[~2021-01-05 9:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-03 10:00 [RFC] Improve Python package quality Lars-Dominik Braun
2021-01-03 10:48 ` Hartmut Goebel
2021-01-05 9:19 ` Lars-Dominik Braun [this message]
2021-01-03 15:04 ` Tobias Geerinckx-Rice
2021-01-05 9:31 ` Vincent Legoll
2021-01-05 10:20 ` Lars-Dominik Braun
2021-01-05 10:48 ` Vincent Legoll
2021-01-06 16:09 ` Hartmut Goebel
2021-01-07 13:31 ` Lars-Dominik Braun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=X/QvLtfxp+/yz/7G@noor.fritz.box \
--to=lars@6xq.net \
--cc=guix-devel@gnu.org \
--cc=h.goebel@crazy-compilers.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).