From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id eKFsJLtgIWABZQAA0tVLHw (envelope-from ) for ; Mon, 08 Feb 2021 16:03:07 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id ACNJILtgIWDBJQAA1q6Kng (envelope-from ) for ; Mon, 08 Feb 2021 16:03:07 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 5999D9403EB for ; Mon, 8 Feb 2021 16:03:07 +0000 (UTC) Received: from localhost ([::1]:60364 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l990D-0005mg-75 for larch@yhetil.org; Mon, 08 Feb 2021 11:03:06 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:48290) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l92v5-0000IA-Nk for guix-devel@gnu.org; Mon, 08 Feb 2021 04:33:24 -0500 Received: from mail-40140.protonmail.ch ([185.70.40.140]:31987) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l92ua-0007eP-8e for guix-devel@gnu.org; Mon, 08 Feb 2021 04:33:10 -0500 Date: Mon, 08 Feb 2021 09:32:27 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail; t=1612776752; bh=X1wMXHeNtQW84aOZwICBQOm8RM1TnQHE95iRW2M9GFc=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References:From; b=KCkV60LV5Id+nXCGg8jKeOFqb+0XxJpNdvQT1GoVarLKox0zLuD0G7zC716mTt7jX 9v/IyKsODwxgLsCNr/XYCTFDVhS2znD3rtlM1w+Hq093Cm2200iROsgiRrM5dqk9mF vM9pkzQKTCz4LgcO+YF/qVHA0H6B1XoCBbG5bI3M= To: Maxime Devos From: raid5atemyhomework Cc: "guix-devel@gnu.org" Subject: Re: ZFS on Guix Message-ID: In-Reply-To: References: =?us-ascii?Q?<=5F1CLe9QSGsoMlu5WxBMXm4CbFLM=5FM9iRG1XQF9GDsK0GP208jpngdymfix4tAfoLP94mhMTt-Tx6OP2xN=5Fn78Jhx5KQzkiqPpIci=5F44C9OI=3D@protonmail.com>_<5DEAAAD8-1D08-4489-9AEC-675618F8E388@zancanaro.id.au>____<07kwAFNpjhGFe7ArkjjAtRhr564wvMPGhHFyjGb=5FXdmmPNddKTmT9Swky1NbbUxHBC4xw3p-m=5F3JyW16Ql9J7PLyk6UdhCsA2cdkHehdti8=3D@protonmail.com>___?= MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=185.70.40.140; envelope-from=raid5atemyhomework@protonmail.com; helo=mail-40140.protonmail.ch X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: raid5atemyhomework Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -3.06 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=protonmail.com header.s=protonmail header.b=KCkV60LV; dmarc=pass (policy=quarantine) header.from=protonmail.com; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Queue-Id: 5999D9403EB X-Spam-Score: -3.06 X-Migadu-Scanner: scn1.migadu.com X-TUID: o9eyfq7FQSmu > * the shepherd services defined in `configuration.scm` > seem one-shot services to me, so maybe add '(one-shot? #t)'. I was wary of making the `zfs-scan` one-shot, since there is a dependent se= rvice on top of it. Not to mention restarting `zfs-scan` could be useful i= f for example you were doing hotswapping of devices. Maybe. > * in the 'stop' of zfs-automount, the code changes the working > directory. As it isn't restored afterwards, this doesn't seem > kosher to me. Or maybe this isn't an issue at all. The code is modeled after `file-system-shepherd-service` procedure in `gnu/= services/base.scm`, which includes a `(chdir "/")` as well with the comment= "Make sure PID 1 doesn't keep TARGET busy.". Since this also does filesys= tem mounting/unmounting, I judged it best to imitate the existing filesyste= m mounting/unmounting service. Thanks raid5atemyhomework