From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 8HuNH6yAOGHjWwAAgWs5BA (envelope-from ) for ; Wed, 08 Sep 2021 11:21:48 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id IHFnG6yAOGGuBwAA1q6Kng (envelope-from ) for ; Wed, 08 Sep 2021 09:21:48 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 9AA4811E35 for ; Wed, 8 Sep 2021 11:21:47 +0200 (CEST) Received: from localhost ([::1]:36258 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mNtm6-0003GM-IV for larch@yhetil.org; Wed, 08 Sep 2021 05:21:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58254) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mNtlO-0002ZT-Ra for guix-devel@gnu.org; Wed, 08 Sep 2021 05:21:02 -0400 Received: from mail-4317.protonmail.ch ([185.70.43.17]:16485) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mNtlL-0007sZ-AE for guix-devel@gnu.org; Wed, 08 Sep 2021 05:21:02 -0400 Date: Wed, 08 Sep 2021 09:20:52 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lendvai.name; s=protonmail2; t=1631092855; bh=8BFUF1gAkn9YEwoxZg05FvfkwlBlYDdwb/YAWKFTnww=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References:From; b=nYlS3qYLoup95+pxiVLh5C7/Kqnid2WyM7gALoSeXGM5SL/7F+jluARJfLeTPums9 j8Uw/gYDTTHA+41wo+xR7sPh96qtblvSWOApy0Cut1xTiCVQkSI7TGX1o1uCOmFHwj 8d013qhpJmQvRmQLSgDPNuTWRRRXUAL4sVHUx/q8TT32e1H4bNRczqGwLe6F6EAcq1 0hiE5xvz2xQsjA1Qgyb8b/DdUfRvn9a/ORs6yclqfPLelTMfWQg2VDcA3Lgy9sBrPz UQzliSLBgAR+MIdeF49ehl+vZDtJq5bhE6vllnbEtjdNJQgEhrlYOD6XPrB/G8Vd7P 19YW+8i796LhQ== To: Maxime Devos From: Attila Lendvai Subject: Re: avoid wrapper scripts when possible Message-ID: In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=185.70.43.17; envelope-from=attila@lendvai.name; helo=mail-4317.protonmail.ch X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Attila Lendvai Cc: "guix-devel@gnu.org" Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1631092908; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=8BFUF1gAkn9YEwoxZg05FvfkwlBlYDdwb/YAWKFTnww=; b=oiRoHmO/LiAnjLdTDsrzXsPBaKUDi6p8TJYQHA17qGTQSRz83b6uXYl/aR0mk4Rx02hVIv eiuEx1D1kNZtx3qjKY+pNp7JYOqXq1KZL/TDFLgj81stVK5CiTgNqx5RvJGQHwiWmUagS3 AbMOhZIkXSGR1nj9xTgFuQnWgMlh+B+oGH5erYJ1gcrJhP5IbHNU/SxeS7kg1I5OfJmEds 0CikYsbmumFB6oKExh0Yi1dFZjFCDsK5RO5aK1We3wdRentIaCQ5tV4tMj0vCM62dqX2hE Vh/PPNBdGvcxoqU8iwB+yv9MRdFIkGU98Lqx48xkQZ+AqeFXjgKvoWg8sfuK+w== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1631092908; a=rsa-sha256; cv=none; b=hOd7KKFPDYl01kFMbeu15D2FUb2g/2fQjghgvGAlt13F47Biu4Yzd7RW74I4qluz2Pn1dv XKqnMtGovSRMi5m+2u24QQevyrWvGO4UkXVZW0WkS0LaNXwKHj+R+Vetmv8Wx3g9ViCmt7 DT0T5D/tcb9leexvlddX8UskWYkTJutdtSKxET6qaQUw+w7fVYuw+UPtRxPYcfXLUEdJDT SRiL/sQ+BRDgmFruzZsCpr/SJ1GvEfhfKM9IRJnSmtfFjpXnuUf3UpFxx7vCKkCgIz6Ona J9QcMKbRqQdpSs5CPkBzpEIWV+8+bIg1HYJNYsxodsoCoqI0c/oOuj18IGoM5Q== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=lendvai.name header.s=protonmail2 header.b=nYlS3qYL; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Spam-Score: -2.61 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=lendvai.name header.s=protonmail2 header.b=nYlS3qYL; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Queue-Id: 9AA4811E35 X-Spam-Score: -2.61 X-Migadu-Scanner: scn0.migadu.com X-TUID: moZo+BIkw8Gz thanks for the ideas Maxime! > You could patch trezor-agent with something like > > Python syntax might be incorrect > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D > > if sys.argv[0] =3D=3D ".trezor-gpg' > sys.argv[0] =3D "trezor-gpg" > device_name =3D os.path.basename(sys.argv[0]).rsplit('-',1)[0] > > Would that work? most probably, but i thought first i'll pursue a more general fix for this. i will fall back to just patching upstream if i fail. > FWIW, there's 'wrap-program' and there is 'wrap-script'. > > wrap-script is less likely to cause errors here (it doesn't rename the ex= ecutable) > but less general. Maybe wrap-script can be used instead of wrap-program? not sure how to do this. looking at python-build-system.scm it looks like there is no way to tell it to use wrap-script, so i went ahead and just changed the wrap-program call to wrap-script globally, and gave it a try. the first error i encountered was in the package called scons. it has .bat files that wrap-script fails on. if i delete them in a snippet, then scons' own build system errors out. any hints on how to proceed from here? was this what you meant at all? would it be a worthwhile improvement to hack my way through this path at all? shall i try to make it configurable from the package's definition, change the default, and force it back to wrap-program for packages that fail with wrap-script? - attila