unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Attila Lendvai <attila@lendvai.name>
To: Ricardo Wurmus <rekado@elephly.net>
Cc: guix-devel@gnu.org
Subject: Re: RFC: new syntax for inline patches
Date: Wed, 05 Jan 2022 08:16:44 +0000	[thread overview]
Message-ID: <NtOn8W291LXoMyRVDbpC-Lq-wg_1MfpZWGEQZoOqxh2nBa5zUj2CEHRbBUbMG8mq0-hActQoc53-hSsC-20OHFysyF5eYvyzOwMPwxnJONk=@lendvai.name> (raw)
In-Reply-To: <87ee5ne7z5.fsf@elephly.net>

i may be lacking the necessary bird's eye view here... but why not just use good old copy-pasted diff for this?

introducing extra complexity in the form of a new DSL has all kinds of costs that people usually ignore (*), and it's not clear to me how those costs would pay off compared to just copy-pasting a small diff into the package declaration.

* lack of tooling; more opportunity for bugs; the ((line 10) (+ ...)) DSL is more fragile to upstream changes, etc)

sure, diff would be more verbose and arguably less aesthetic, but it's much easier on the brain of the coders, and is less fragile, too. and larger patches could go through the current, convoluted local.mk way.

- attila
PGP: 5D5F 45C7 DFCD 0A39



  reply	other threads:[~2022-01-05  8:21 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-04 16:50 RFC: new syntax for inline patches Ricardo Wurmus
2022-01-05  8:16 ` Attila Lendvai [this message]
2022-01-06  0:19 ` Liliana Marie Prikler
2022-01-06  1:20   ` Jelle Licht
2022-01-06  6:43     ` Liliana Marie Prikler
2022-01-06  7:12       ` Ricardo Wurmus
2022-01-06  8:12         ` Liliana Marie Prikler
2022-01-08 21:34 ` Ludovic Courtès
2022-01-12 18:06   ` Efraim Flashner
2022-01-12 17:56 ` Efraim Flashner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='NtOn8W291LXoMyRVDbpC-Lq-wg_1MfpZWGEQZoOqxh2nBa5zUj2CEHRbBUbMG8mq0-hActQoc53-hSsC-20OHFysyF5eYvyzOwMPwxnJONk=@lendvai.name' \
    --to=attila@lendvai.name \
    --cc=guix-devel@gnu.org \
    --cc=rekado@elephly.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).