unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: <vincent@cloutier.co>
To: Guix Devel <guix-devel@gnu.org>
Subject: On my way to my first patch, need review
Date: Sat, 26 Mar 2016 22:49:02 +0000 (GMT)	[thread overview]
Message-ID: <KDp6RaD--3-0@cloutier.co> (raw)

[-- Attachment #1: Type: text/plain, Size: 2503 bytes --]

Even though I don't know if I am accepted for GSoC yet, I thought it would be 
nice to start contributing now! :)

I started by adding the gem wayback_machine_downloader (a very useful piece 
of software by the way).

So I used `guix edit ruby` and I copied it in the Documents folder. Then I 
added somewhere in the middle of the file:

(define-public wayback-machine-downloader
  (package
    (name "wayback-machine-downloader")
    (version "0.2.1")
    (source
      (origin
        (method url-fetch)
        (uri (rubygems-uri
               "wayback_machine_downloader"
               version))
        (sha256
          (base32
            "1nrwm5bc7vqm02m2x0lylxyya446kg0spg6ksi7dfkrad0l9jq8y"))))
    (build-system ruby-build-system)
    (arguments
       `(#:tests? #f ; no rakefile
              ))

    (native-inputs
     `(("ruby-rake-compiler" ,ruby-rake-compiler)
       ("ruby-minitest" ,ruby-minitest)))

    (synopsis
      "Download website from archive.org's Wayback Machine")
    (description
      "Download any website from the Wayback Machine.  Wayback Machine by 
Internet Archive (archive.org) is an awesome tool to view any website at any 
point of time but lacks an export feature.  Wayback Machine Downloader brings 
exactly this.")
    (home-page
      "https://github.com/hartator/wayback-machine-downloader")
    (license expat)))


Then I ran: `guix package -i wayback-machine-downloader -f ~/Documents/ruby` 
and it successfully installed.

So my questions are:

1) Do you guys and gals have a better workflow that includes the git repo, so 
I can send a patch? All I saw in the documentation was about building guix 
itself. I guess I could clone somewhere and use `guix package -f`,  but will 
this be a reliable way of testing? And will this make my guix less stable on 
the long run?

2) Should I add "ruby-" before the name of the package? I know technically 
all gems should have "ruby-" before the name, but this is designed to be use 
independently. Could it have multiple names, or is it a bad idea?

3) Where does this package belong in the directory?

4) Is the package declaration itself all right? Are packages sorted or 
organized in any way?

5) I speak fluent French, can I add a description and summary in French?

Thanks!
Vincent

[-- Attachment #2: Type: text/html, Size: 3627 bytes --]

             reply	other threads:[~2016-03-26 22:49 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-26 22:49 vincent [this message]
2016-03-27 20:29 ` On my way to my first patch, need review rain1
2016-03-28  0:37   ` vincent
2016-03-28  6:47     ` Ricardo Wurmus
2016-03-28  5:11 ` Ben Woodcroft
2016-03-28  6:43   ` Chris Marusich
2016-03-28 16:29     ` Translating package descriptions Ludovic Courtès
2016-03-30 16:01       ` vincent
2016-03-30 21:30         ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=KDp6RaD--3-0@cloutier.co \
    --to=vincent@cloutier.co \
    --cc=guix-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).