unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Romain <romain@rgarbage.fr>
To: Josselin Poiret <dev@jpoiret.xyz>,
	Felix Lechner <felix.lechner@lease-up.com>,
	 Tanguy LE CARROUR <tanguy@bioneland.org>,
	Guix Devel <guix-devel@gnu.org>
Subject: Re: Keyboard layout in GRUB (Was: On the road to the next release: testing the installer)
Date: Mon, 12 Feb 2024 20:12:11 +0100	[thread overview]
Message-ID: <E92EC0E3-F401-4CAF-AE41-908C9D67A315@rgarbage.fr> (raw)
In-Reply-To: <87frxyvuum.fsf@jpoiret.xyz>

Hello,

On February 12, 2024 11:29:37 AM GMT+01:00, Josselin Poiret <dev@jpoiret.xyz> wrote:
>Hi Felix,
>
>Felix Lechner <felix.lechner@lease-up.com> writes:
>
>> I do not suffer from the issue described here but rewrote the bootloader
>> code locally for more flexibility (and may be able to contribute
>> it). Could we simply move the reference to keyboard-layout-config here
>> up by a few lines?  [1]
>
>We could move it up and that would solve it for people not using
>encrypted /boot I believe.  

IIRC, grub doesn't take the keymap into account unless the `at_keyboard` module is loaded. It is not the case at the moment.
Also there seems to be an incompatibility between this module and some laptop keyboards (for example I have a Thinkpad X220 with libreboot/seabios payload and the keyboard stopped working after loading this module).

>I believe we don't use grub-mkimage directly for the efi case for now,
>which is the command we want to use to be able to include arbitrary
>files in the image, hence my comment about the code needing some
>refactoring.

Even in the BIOS case, as far as I understood the code, the grub image installer function doesn't have access to `bootloader-configuration` data. I think that passing it down to this function would require some changes in the way the bootloader is installed. But I might have overseen something, that I why I was hoping for someone knowledgeable to jump in the discussion :)

-- 
Romain


  reply	other threads:[~2024-02-14 21:58 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-06  7:31 On the road to the next release: testing the installer Tanguy LE CARROUR
2024-02-06 12:52 ` Tanguy LE CARROUR
2024-02-09 11:24   ` Tanguy LE CARROUR
2024-02-10 10:35     ` Josselin Poiret
2024-02-10 12:35       ` Romain
2024-02-10 14:59         ` Josselin Poiret
2024-02-11 20:33           ` Keyboard layout in GRUB (Was: On the road to the next release: testing the installer) Felix Lechner via Development of GNU Guix and the GNU System distribution.
2024-02-12 10:29             ` Josselin Poiret
2024-02-12 19:12               ` Romain [this message]
2024-02-13  9:35                 ` Josselin Poiret
2024-02-13 11:36                   ` Romain
2024-02-10 17:47         ` On the road to the next release: testing the installer Tanguy LE CARROUR
2024-02-10 10:43     ` Vivien Kraus
2024-02-10 12:01       ` Tomas Volf
2024-02-10 17:43       ` Tanguy LE CARROUR
2024-02-28 15:16 ` Cuirass 1.2.0-2.7bcd3d0 (and manual): latest install image not available for download (wrong URL?) Giovanni Biscuolo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E92EC0E3-F401-4CAF-AE41-908C9D67A315@rgarbage.fr \
    --to=romain@rgarbage.fr \
    --cc=dev@jpoiret.xyz \
    --cc=felix.lechner@lease-up.com \
    --cc=guix-devel@gnu.org \
    --cc=tanguy@bioneland.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).