From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id WI22HZ8981+2JgAA0tVLHw (envelope-from ) for ; Mon, 04 Jan 2021 16:09:03 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id 0MFFGZ8981+YFgAAB5/wlQ (envelope-from ) for ; Mon, 04 Jan 2021 16:09:03 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 1183694030E for ; Mon, 4 Jan 2021 16:09:03 +0000 (UTC) Received: from localhost ([::1]:38806 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kwSPl-0007ot-VP for larch@yhetil.org; Mon, 04 Jan 2021 11:09:02 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:45104) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kwESo-0002Pj-9R for guix-devel@gnu.org; Sun, 03 Jan 2021 20:15:14 -0500 Received: from mail4.protonmail.ch ([185.70.40.27]:19173) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kwESk-0003w3-RH for guix-devel@gnu.org; Sun, 03 Jan 2021 20:15:13 -0500 Date: Mon, 04 Jan 2021 01:15:02 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail; t=1609722906; bh=dUWISjtytBVvMM8C8z4NahWQYA0XbRQL7vD3uarCYZk=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References:From; b=hkN8dPIZQlA08UfOIvH5GSQJRA+EH+UTE/891d6jBtxb24Td3qAUdeLWokvSix5nr 73KuZ1px+sCVBs+cU+B8M5nAumO70dP6o3RoH0S6RRtAZYxo+F8S6xLZ7D/lgbkdoS a4CEzQ1GC9V0l/yNoA6szsHUVEdfOLJ7YCepYWFI= To: Danny Milosavljevic From: raid5atemyhomework Subject: Re: ZFS on Guix Message-ID: In-Reply-To: References: <_1CLe9QSGsoMlu5WxBMXm4CbFLM_M9iRG1XQF9GDsK0GP208jpngdymfix4tAfoLP94mhMTt-Tx6OP2xN_n78Jhx5KQzkiqPpIci_44C9OI=@protonmail.com> <4nnVFhbpUhipplsq55mHX9KtoMK9s0rZDC3D8rgKQ5O0nUtnapdkHZfPcAVpECgW1mnYm1BbmvyQ4SyTgvNyUgVgzM29gh6b8OL7p3YvczM=@protonmail.com> <20210103165008.6517c1bf@scratchpost.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=185.70.40.27; envelope-from=raid5atemyhomework@protonmail.com; helo=mail4.protonmail.ch X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Mon, 04 Jan 2021 11:08:45 -0500 X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: raid5atemyhomework Cc: "guix-devel@gnu.org" Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -3.03 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=protonmail.com header.s=protonmail header.b=hkN8dPIZ; dmarc=pass (policy=quarantine) header.from=protonmail.com; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Queue-Id: 1183694030E X-Spam-Score: -3.03 X-Migadu-Scanner: scn1.migadu.com X-TUID: MGpdSmWhlliu Available here: https://issues.guix.gnu.org/45643 Please review! Hopefully it gets merged! > Yes, I found that out after a little more digging. > > I have a preliminary patch here: https://issues.guix.gnu.org/45592 > However I will make a patchset based on this in order to support /home on= ZFS and managing ZFS the "legacy" way by (file-system ...) declaration, pl= ease wait. > > > Hi, > > the reason is that our "zfs" package uses > > ("util-linux" ,util-linux "lib") > > and then does > > (substitute* "lib/libzfs/libzfs_mount.c" > > (("/bin/mount") (string-append util-linux "/bin/mount")) > > (("/bin/umount") (string-append util-linux "/bin/umount"))) > > . > > That can't work. > > zfs interna that will be patched by the Guix package are: > > ./lib/libzfs/libzfs_mount.c > > do_mount(const char *src, const char *mntpt, char *opts) > > char *argv[9] =3D { > > "/bin/mount", > > "--no-canonicalize", > > "-t", MNTTYPE_ZFS, > > "-o", opts, > > (char *)src, > > (char *)mntpt, > > (char *)NULL }; > > Easy fix would be to change our package to have both > > ("util-linux:lib" ,util-linux "lib") > > and > > ("util-linux" ,util-linux) > > .