From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id EKXvKHCFSV8EEQAA0tVLHw (envelope-from ) for ; Fri, 28 Aug 2020 22:30:08 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id cIDMJHCFSV/rcAAAB5/wlQ (envelope-from ) for ; Fri, 28 Aug 2020 22:30:08 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 332D59403A0 for ; Fri, 28 Aug 2020 22:30:08 +0000 (UTC) Received: from localhost ([::1]:36472 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kBmso-00032a-Up for larch@yhetil.org; Fri, 28 Aug 2020 18:30:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33800) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kBldw-0001Gq-1b for guix-devel@gnu.org; Fri, 28 Aug 2020 17:10:40 -0400 Received: from mail-bn8nam11olkn2014.outbound.protection.outlook.com ([40.92.20.14]:64047 helo=NAM11-BN8-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kBldt-0008DO-5S; Fri, 28 Aug 2020 17:10:39 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WaGr6OJlSBl3XrSCNhgHqwn+gtuXJ25cy7bI/z6i+MartGqpGiOIjBFG9zrGvxYr78RW86wb3gEcn89pyHfC5dU9WCw4egTmdRD5owoiFUcG8pfBxZOuV++mGJscn8FjeBpV6e57DULhHB2mTMOIdMFUr2RW8h+JAPsoA2PbTyxHSqzGVdj9dcR6CNCDn1ebRWY14/APppXruw8I6fylDf3z4g/WFqku2e7tTrWx2EyOQeg4c2XTqj4hCzE9cfyU95tfUOazhvMYXrLq6tEJlBAh4OO8BFiZw925CxXp3BidX7jFh0wATm7dfIlOaQXj6AgofI4HPDhGLyn1fzECeA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8oWJo5DJkvBdUhxil+tuMUNxgq6NlTewdMSIAdJL8Tg=; b=AqtPsNGNJ/RVbUhQewCP+gmJ2LJWh3ovGAN75iazY0gelaVP13t7Xi84tpjBzX6XXCj7HELijx/DaqFv06FV9JEK3IxEnyjvD5DxThewqYLoNK6mXz+kvuV2qU25NY4RqbzBGq4pcsG6A/c3gjRtSbX+prMXXycLX0OCGCs/Q+5pJ4E8fYzigQ/gow2jqHHFstnddjtQLBkIpVN98DTPNHeuBQ5z20AXQ5K9K8ZWDuNlRvAMOdj/qgI1DespgkcSWQOFGiNAsUcXKAJesHXjXnf1hW80axn+tZsRQA1tuyDb8/QZ0Qq1TFdnskfGY93IvxQCknYe24iJZ06bQvFphA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8oWJo5DJkvBdUhxil+tuMUNxgq6NlTewdMSIAdJL8Tg=; b=b9bzIFY5+GyOSJoP2vw8jvERWpscFyxGpSqRJ++qe6yYlZ4sperpvW9ltk8ulJDclUWUl85jOsSaY1kPTdNoXD/9Wd2hmQCo4Bnshnz2qQOQ0dYoWzVA5pEKpdReBGaMyHO05w/BStXFSwX+pkUOAlwSmH+nGDg/JPcejTVYmk8wm+tVhB4g/C+C6Kzs2FYpzNTdHdcS5i7r8uqiFxHu7c0aIyYcruRUZpQFTR6BGuvlO/VLtrizw/WXDcPm+mgstPJoFFS7EjvUbSWB9TQqC9K1Czy0XXLWQZ/s9pfO/ZyqC16E6T3Iw/fXXy9yWMb4SWWbzZGdUg0xk/XkQeOaRA== Received: from CO1NAM11FT046.eop-nam11.prod.protection.outlook.com (2a01:111:e400:3861::53) by CO1NAM11HT114.eop-nam11.prod.protection.outlook.com (2a01:111:e400:3861::208) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3326.21; Fri, 28 Aug 2020 21:10:34 +0000 Received: from DM5PR1001MB2105.namprd10.prod.outlook.com (2a01:111:e400:3861::4d) by CO1NAM11FT046.mail.protection.outlook.com (2a01:111:e400:3861::203) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3326.19 via Frontend Transport; Fri, 28 Aug 2020 21:10:34 +0000 X-IncomingTopHeaderMarker: OriginalChecksum:828F730B3CBA3514B89DEBC75AC46E725D922510FD802FACC48B1ED9156F4EF8; UpperCasedChecksum:07B44B7BF531BD50E8340E565D9E86E3918A5D531B2D1CA5EFD7961C363FF994; SizeAsReceived:10762; Count:50 Received: from DM5PR1001MB2105.namprd10.prod.outlook.com ([fe80::cc1a:65a6:d74d:52f4]) by DM5PR1001MB2105.namprd10.prod.outlook.com ([fe80::cc1a:65a6:d74d:52f4%6]) with mapi id 15.20.3326.019; Fri, 28 Aug 2020 21:10:34 +0000 To: Mark H Weaver , =?UTF-8?Q?Ludovic_Court=c3=a8s?= References: <20200819040941.32696-1-jackhill@jackhill.us> <87sgc6onvi.fsf@gnu.org> <87lfhybntk.fsf@netris.org> From: Morgan Smith Autocrypt: addr=Morgan.J.Smith@outlook.com; keydata= mQENBFwIaPkBCAC0ftYeut16x9zh8J7PCe+yVncNdhql5kmTPReny9l1kJ8OJRjBtgbhnS/j gImuOkSYJng4jc0PflEf+WoozLznLCHoM0DYHZwX0ThfUvgVMJ+eJEobSpX0n6A5zWdQm2NN zy05+iVNi5Bld8779kP1pLqBwbDR/Z4ohnGIrTyHjYNRa9w0xwJ6wytgiTtpgoqeRwEDA3dZ teuFD8BM4DDyFJ3Gcr1iAp9geS/PaNKNg0V2o0hGA29LVRqT7IKY9WHgXG7nWcJpL9rUlBXO G35NINYB4eAiQrR6CvJbsj6m0Vp39lMXcb5jYqLfZcXLAxKn93oP1srlpD6c0oj5avuhABEB AAG0I21vcmdhbiA8bW9yZ2FuLmouc21pdGhAb3V0bG9vay5jb20+iQFOBBMBCAA4FiEEF3oH h1HcS/5V5sbnUtk0Fu6qRaYFAlwIaPkCGwMFCwkIBwIGFQoJCAsCBBYCAwECHgECF4AACgkQ Utk0Fu6qRabAuQf6Ahi++Fq8XmjjsIuM7K39ArSOpDBMV3kjUeJxOg9gUQKNT8k+CKI/jzd8 B0oALvM0O7yW06qHXqrkTf9XB7tM8mGP+HxHP0BAM9aL0oeq3deKN2Mt1ghhkv1r/ZbmNP+Z ZbKhDV98liZhvnDdwPLQfIGPBNpNz5RDSb55XFHEIV8Il36YYHLBVID2TzT5gWUaoqzmZn0R DCrVAoR2lqZxStoYR3g2dDZeFbJoAtyl5n2lpO5fQvNG4pbPjiPSfScKBoZLS2R+ExAjTc46 ed6na5uplzM1Hx+vGl450p4mZkzP12Jj8s0Z7x3yKJbJzbrWK2d2eu+emAuc9uJOHyqFiLkB DQRcCGj5AQgAxiMI2Atxw7TUTuIE9+AJ29zxkTfB+UUDCuc/SMx8jB6fE7HMQH1+PecQgMrX p1v1II1u13iHj2k0JiET3lBOz7Z7ZSCKnGajkamDH2rWP5au0BuM65EkeYaMQnFZgXNl0zVj SdYwrp1RlNntdy5dflDqg49uiYQZAuvQ9r7i8gBwVYc+7Chhrim2zh5sMz+tGam2CggJUe/o nxBs0WqV4v0lLxi3GEMmPzkEfDCd7KypOiNmZF5WwabtfAgivHbByyMfvqqLe5mwDkh0GPkZ VLDLEnlsdiSKgnRhSNq/RC86+AecwWeJXUuvMAXTHt+2+l7gSHTpJ0nuMtuIhQUU7wARAQAB iQE2BBgBCAAgFiEEF3oHh1HcS/5V5sbnUtk0Fu6qRaYFAlwIaPkCGwwACgkQUtk0Fu6qRaZW Twf+KU7qiZSJoAvX5HmD4ZF0hHHyUBFA9LzxSjQbD0eaFnkfKOe3iP6VQQd6bLnIMOVNVS7m AUFclFS8pa8c/Rilbi3C9T7J3JzES2S4+k3LHYDBINOc2RmeQYI/FnmupCCtcFiVC85huMAU /xAsUKRtX6uLRSkhWbkZoFjpXcnHccLZmxXVoynLChySZw6obGsWbN039Da7pdqRL+7PFpCD pmrQOKB/FARZKjbblq8GEpv1yJPvv9SxuzQpuQ56MMNMFix3gkM72+lyNs4f2hAFwExTMw2m 8xcSbieC39Erg54j96CgMCgcmxrORCcgSljZ+58UECBHsXIpRckfEugRUg== Subject: Re: [PATCH v4] gnu: emacs: Update to 27.1. Message-ID: Date: Fri, 28 Aug 2020 17:10:31 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 In-Reply-To: <87lfhybntk.fsf@netris.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-ClientProxiedBy: YT1PR01CA0038.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:2e::7) To DM5PR1001MB2105.namprd10.prod.outlook.com (2603:10b6:4:2b::24) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from 255.255.255.255 (255.255.255.255) by YT1PR01CA0038.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:2e::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3326.19 via Frontend Transport; Fri, 28 Aug 2020 21:10:32 +0000 X-Microsoft-Original-Message-ID: X-TMN: [i60Ts4dkFCDR5AjqEypPypEVa4drYFmG] X-MS-PublicTrafficType: Email X-IncomingHeaderCount: 50 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-Correlation-Id: 316ca05a-999c-4d10-8ac6-08d84b96cd58 X-MS-TrafficTypeDiagnostic: CO1NAM11HT114: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: BuiuZQRR2tYA0tAf114GSnBGX4vhcp+HxaABwE78QtAVhVOqohN8yDvUdy8klpiwRUrQcy0PLhItU21l2ACzIgGKjdxJe11g2Vae4n1ATxytfjtiVfc9iS+YTyydOza+XmdybSnGOKIEFZcUcjFKoVpokBNSGwlJUmBJDH+ULkKm1WYoZTr1GIr8smqAGaxNueynIp9fjpCtUZIwGFUIIA== X-MS-Exchange-AntiSpam-MessageData: hcqipTFHZXo/Yt4T88FhO9JYHDMqIBdZsQ/OTkrcLvoW+YTiSQmJCcXW4aRt9rIsdP9S5tNL30AxKi96DXuhLQvkgUb0msmDdcrNzO7WjZ25Sh52z3PywnYl6KiMJMUirc3YSIefEQNNOn/4wq+T0A== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 316ca05a-999c-4d10-8ac6-08d84b96cd58 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Aug 2020 21:10:33.9482 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT046.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1NAM11HT114 Received-SPF: pass client-ip=40.92.20.14; envelope-from=Morgan.J.Smith@outlook.com; helo=NAM11-BN8-obe.outbound.protection.outlook.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/28 17:10:34 X-ACL-Warn: Detected OS = Windows NT kernel [generic] [fuzzy] X-Spam_score_int: 7 X-Spam_score: 0.7 X-Spam_bar: / X-Spam_report: (0.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FORGED_MUA_MOZILLA=2.309, FREEMAIL_FROM=0.001, MSGID_FROM_MTA_HEADER=0.001, NICE_REPLY_A=-0.809, RCVD_ILLEGAL_IP=1.3, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Fri, 28 Aug 2020 18:29:52 -0400 X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: guix-devel@gnu.org, cjpeople2013@gmail.com, 42738@debbugs.gnu.org, dnbarbato@posteo.de Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=outlook.com header.s=selector1 header.b=b9bzIFY5; dmarc=pass (policy=none) header.from=outlook.com; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Spam-Score: -2.71 X-TUID: pXjh4RbuqW8S Hello! It seems I am taking some credit for Jack Hill's patch. I simply took Jack's patch (labeled as patch v3 in the debbugs thread) and attempted to build it with my personal config. I noticed that it wouldn't build properly since emacs wanted libxaw and emacs-no-x wanted some image librarys (libtiff, libjpeg, etc). The only contributions I made, where to add libxaw to emacs and to add the configure flags to emacs-no-x. I made these changes and posted them as patch v4. However, the patch Mark committed does build for me so you can ignore my contributions (which weren't well thought out to begin with). The rest of your questions should be directed to Jack. (Also just my 2 cents, we should have upgraded emacs-next to 27.1 and only upgraded emacs a week later. Emacs deserves more care than most packages due to its dependence on so many other packages. Not trying to shame anyone, just something to think of for next time.) Thanks, Morgan On 8/28/20 2:57 PM, Mark H Weaver wrote: > Looking now, here are the main differences I see between our patches: > > * I found that I had to remove the 'restore-emacs-pdump' phase from most > of the other emacs variants, namely the ones that use > 'gnu-build-system', because otherwise the inherited > 'restore-emacs-pdump' phase would fail. Morgan's patch seems not to > consider most of the other emacs variants, and I'm not sure if they > were tested. I briefly tested all of them except for 'guile-emacs'. > > * Morgan removed the snippet code that deletes "eshell/esh-groups.el", > whereas I replaced it with a call to 'find-files' to remove it only if > present, as the previous comment suggested. I'm not sure if this is > still needed, though. > > * Morgan's patch adds "libxaw" to inputs and "texinfo" to native-inputs. > What's the rationale for these? > > * I added 'pango' to the inputs, because the Emacs NEWS mentioned that > Pango was used for font rendering when "--with-cairo" is used. > However, it may be that "pango" finds its way into the build inputs > without being explicitly mentioned. > > * Morgan removed 'libxft' from the inputs of 'emacs', whereas I didn't. > This was an oversight on my part. However, if we remove it, it's > possible that we might need to add it back to 'emacs-no-x-toolkit'. > The references that I see to Pango in the Emacs code are within > "#ifdef HAVE_GTK3". > > * In 'emacs-no-x', my patch removes the new graphical library inputs > (cairo, pango, and harfbuzz) and the "--with-cairo" flag, whereas > Morgan's patch leaves "cairo" and "harfbuzz" as inputs, and overwrites > the inherited configure-flags to be precisely ("--with-jpeg=no" > "--with-gif=no" "--with-tiff=no"), apparently discarding the inherited > "--with-modules" and "--disable-build-details" flags. > > * Morgan made 'emacs-wide-int' into a deprecated package, whereas I > thought that it might still be useful. My rationale was this: from a > brief skim, it looks like '--with-wide-int' might make *immediate* > integers wider, which for some applications might perform much better > than the heap-allocated arbitrary-size integers supported by Emacs 27. > However, I didn't look carefully at this. > > * I updated "emacs-exec-path.patch" and removed > "emacs27-exec-path.patch", whereas Morgan's patch keeps both files and > possibly leaves "emacs-exec-path.patch" orphaned. > > * I updated the patches to apply cleanly to Emacs 27, although this was > not strictly needed. > > * I updated 'notmuch' in the previous commit to a version that builds > successfully with Emacs 27. > > Pierre Neidhardt wrote: >> I confirm that with Mark's commit >> emacs-clojure-mode and emacs-elisp-refs are also broken. > > Sorry about that. If the Emacs 27 update breaks important packages, it > might be that reverting it is the proper action. If the maintainers > decide to do this, I would not object. > > Best regards, > Mark >