unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: "Romain GARBAGE" <romain.garbage@inria.fr>
To: "Ludovic Courtès" <ludovic.courtes@inria.fr>
Cc: <guix-devel@gnu.org>
Subject: Re: [PATCH Cuirass] cuirass: Fix handling of SPECIFICATION-NAME.
Date: Mon, 17 Jun 2024 17:02:06 +0200	[thread overview]
Message-ID: <D22DSWPP7F65.12CDHUUH5B7CM@guix-A102> (raw)
In-Reply-To: <8734pb7kiw.fsf@inria.fr>

On Mon Jun 17, 2024 at 3:42 PM CEST, Ludovic Courtès wrote:
> Hi!

Hi Ludo' !

> Romain GARBAGE <romain.garbage@inria.fr> skribis:
>
> [...]
> > * src/cuirass/base.scm: Handle SPECIFICATION-NAME as a symbol.
> > * src/cuirass/http.scm: Handle SPECIFICATION-NAME as a symbol.
> > * src/cuirass/templates.scm: Fix template generation.
>
> Bonus points if you can mention the affected procedures in the message
> above (I can do it for you otherwise).

Will fix in v2.

> I tested it locally following the instructions from ‘README’.  One case
> where we still get a type error is when triggering evaluation through
> the web interface:
>
>   wget --post-data="" -O/dev/null \
>     http://localhost:8080/jobset/random/hook/evaluate
>
> This leads to this backtrace in ‘cuirass web’:
>
> --8<---------------cut here---------------start------------->8---
> In cuirass/http.scm:
>   1408:46  1 (url-handler #<input-output: socket 44> _ _)
> In ice-9/boot-9.scm:
>   1685:16  0 (raise-exception _ #:continuable? _)
> In procedure string->symbol: Wrong type argument in position 1 (expecting string): random
> --8<---------------cut here---------------end--------------->8---
>
> Note that this in turn causes communication with ‘cuirass register’ over
> the “bridge”, so there could be other issues there.

IIRC I saw that the register part properly handles the symbols.

I made some changes and checked locally, this case seems to be handled
correctly in v2.

Romain


      reply	other threads:[~2024-06-17 15:03 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-17 12:44 [PATCH Cuirass] cuirass: Fix handling of SPECIFICATION-NAME Romain GARBAGE
2024-06-17 13:42 ` Ludovic Courtès
2024-06-17 15:02   ` Romain GARBAGE [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=D22DSWPP7F65.12CDHUUH5B7CM@guix-A102 \
    --to=romain.garbage@inria.fr \
    --cc=guix-devel@gnu.org \
    --cc=ludovic.courtes@inria.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).