Disable gnulib's test-lock test in packages?

[Eric Bavier <bavier@cray.com>]

[-- Attachment #1: Type: text/plain, Size: 1023 bytes --]

Hello Guix,

Several packages (libunistring, gettext, and libidn) in the guix bootstrap path hang on the "test-lock" test from gnulib while building on a aarch64 system I have access to.  Some of them already have a patch applied that is supposed to fix the hang on system's with large core-counts, but it seems ineffective on my system.  The findutils package is also affected, and there may be others, but I haven't discovered them yet.

This commit in gnulib fixes the test-lock issue on my system, but doesn't help until our packages update their gnulib source:
https://git.savannah.gnu.org/cgit/gnulib.git/commit/?id=be95b17ae933323cb757471f3d7c3f0617f9257e

Not knowing any better, I created a dummy project to run the latest gnulib lock tests, attached for clarity.

Until the updated lock module and tests make its way into these packages, I would like to ask if disabling these tests outright would be acceptable, similar to the attached patch.  Thoughts?

Eric Bavier, Scientific Libraries, Cray Inc.

[-- Attachment #2: gnulib-test-0.0.tar.gz --]
[-- Type: application/x-gzip, Size: 356526 bytes --]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #3: guix-disable-gnulib-test-lock.patch --]
[-- Type: text/x-patch; name="guix-disable-gnulib-test-lock.patch", Size: 4822 bytes --]

diff --git a/gnu/packages/base.scm b/gnu/packages/base.scm
index bc74535..cf795b4 100644
--- a/gnu/packages/base.scm
+++ b/gnu/packages/base.scm
@@ -267,7 +267,18 @@ interactive means to merge two files.")
                       ;; test-lock has performance issues on multi-core
                       ;; machines, it hangs or takes a long time to complete.
                       ;; This is a commit from gnulib to fix this issue.
-                      "findutils-gnulib-multi-core.patch"))))
+                      "findutils-gnulib-multi-core.patch"))
+            (modules '((guix build utils)))
+            (snippet
+             '(begin
+                ;; Completely disable the test-lock test.  According to the
+                ;; tests mentioned at
+                ;; https://lists.gnu.org/archive/html/bug-gnulib/2017-01/msg00034.html,
+                ;; our systems' glibc libraries are probably broken, so
+                ;; test-lock just hangs.
+                (substitute* "tests/Makefile.in"
+                  (("test-lock\\$\\(EXEEXT\\) ") ""))
+                #t))))
    (build-system gnu-build-system)
    (arguments
     `(#:configure-flags (list
diff --git a/gnu/packages/gettext.scm b/gnu/packages/gettext.scm
index 76c01b1..3aed953 100644
--- a/gnu/packages/gettext.scm
+++ b/gnu/packages/gettext.scm
@@ -52,7 +52,20 @@
              ;; There is one commit in gettext and one commit
              ;; in gettext's embedded gnulib to fix this issue.
              (patches (search-patches "gettext-multi-core.patch"
-                                      "gettext-gnulib-multi-core.patch"))))
+                                      "gettext-gnulib-multi-core.patch"))
+             (modules '((guix build utils)))
+             (snippet
+              '(begin
+                 ;; Completely disable the test-lock test.  According to the
+                 ;; tests mentioned at
+                 ;; https://lists.gnu.org/archive/html/bug-gnulib/2017-01/msg00034.html,
+                 ;; our systems' glibc libraries are probably broken, so
+                 ;; test-lock just hangs.
+                 (substitute* "gettext-runtime/tests/Makefile.in"
+                   (("TESTS = test-lock\\$\\(EXEEXT\\)") "TESTS ="))
+                 (substitute* "gettext-tools/gnulib-tests/Makefile.in"
+                  (("test-lock\\$\\(EXEEXT\\) ") ""))
+                 #t))))
     (build-system gnu-build-system)
     (outputs '("out"
                "doc"))                            ;8 MiB of HTML
diff --git a/gnu/packages/libidn.scm b/gnu/packages/libidn.scm
index dfb1be6..6dc386d 100644
--- a/gnu/packages/libidn.scm
+++ b/gnu/packages/libidn.scm
@@ -38,7 +38,18 @@
                                 ".tar.gz"))
             (sha256
              (base32
-              "068fjg2arlppjqqpzd714n1lf6gxkpac9v5yyvp1qwmv6nvam9s4"))))
+              "068fjg2arlppjqqpzd714n1lf6gxkpac9v5yyvp1qwmv6nvam9s4"))
+            (modules '((guix build utils)))
+            (snippet
+             '(begin
+                ;; Completely disable the test-lock test.  According to the
+                ;; tests mentioned at
+                ;; https://lists.gnu.org/archive/html/bug-gnulib/2017-01/msg00034.html,
+                ;; our systems' glibc libraries are probably broken, so
+                ;; test-lock just hangs.
+                (substitute* "lib/gltests/Makefile.in"
+                  (("test-lock\\$\\(EXEEXT\\) ") ""))
+                #t))))
    (build-system gnu-build-system)
 ;; FIXME: No Java and C# libraries are currently built.
    (synopsis "Internationalized string processing library")
diff --git a/gnu/packages/libunistring.scm b/gnu/packages/libunistring.scm
index df02f68..409e25e 100644
--- a/gnu/packages/libunistring.scm
+++ b/gnu/packages/libunistring.scm
@@ -43,7 +43,18 @@
              ;; test-lock has performance issues on multi-core machines,
              ;; it hangs or takes a long time to complete.
              ;; This is a commit from gnulib to fix this issue.
-            (patches (search-patches "libunistring-gnulib-multi-core.patch"))))
+            (patches (search-patches "libunistring-gnulib-multi-core.patch"))
+            (modules '((guix build utils)))
+            (snippet
+             '(begin
+                ;; Completely disable the test-lock test.  According to the
+                ;; tests mentioned at
+                ;; https://lists.gnu.org/archive/html/bug-gnulib/2017-01/msg00034.html,
+                ;; our systems' glibc libraries are probably broken, so
+                ;; test-lock just hangs.
+                (substitute* "tests/Makefile.in"
+                  (("test-lock\\$\\(EXEEXT\\) ") ""))
+                #t))))
    (propagated-inputs (libiconv-if-needed))
    (build-system gnu-build-system)
    (arguments