unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Ben Woodcroft <woodibe@gmail.com>
To: Marius Bakke <mbakke@fastmail.com>, Leo Famulari <leo@famulari.name>
Cc: guix-devel <guix-devel@gnu.org>, Alex Kost <alezost@gmail.com>
Subject: Re: [PATCH] gnu: Add dlib.
Date: Wed, 24 Aug 2016 18:51:59 -0400	[thread overview]
Message-ID: <CD768191-982B-4CE5-B1B0-84B576A42AE5@gmail.com> (raw)
In-Reply-To: <878tvm2ddh.fsf@ike.i-did-not-set--mail-host-address--so-tickle-me>



On 24 August 2016 3:08:58 PM GMT-04:00, Marius Bakke <mbakke@fastmail.com> wrote:

>
>>> Adding "#:parallel-build? #f" had no effect on tests, indeed the
>check
>>> phase does not seem to use the previously built dlib; it builds it
>again
>>> without parallel-build. I will try reproducing the
>non-reproducibility
>>> on some higher end hardware, hopefully this week.
>>
>> It's weird that it rebuilds the application again for the tests.
>Which
>> build is actually installed in the case of success? Is it worth an
>> upstream bug report?
>
>We rely on cmake-build-system for everything but the check phase, which
>doesn't have a "proper" check target. I'm no cmake expert, but we can
>probably prevent re-build by not including the main application in
>test/CmakeLists.txt and instead copy/link in our already-built version:
>
>https://github.com/davisking/dlib/blob/master/dlib/test/CMakeLists.txt#L15

The cmake build system has an #:out-of-tree? option, maybe set that to #f?

Ben

  reply	other threads:[~2016-08-24 22:52 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-13 17:15 [PATCH] gnu: Add dlib Marius Bakke
2016-08-14 17:25 ` Leo Famulari
2016-08-14 19:52   ` Marius Bakke
2016-08-15  7:43     ` Alex Kost
2016-08-15 11:51       ` Marius Bakke
2016-08-15 20:15         ` Leo Famulari
2016-08-15 20:29           ` Marius Bakke
2016-08-15 22:28             ` Leo Famulari
2016-08-16  0:15               ` Ben Woodcroft
2016-08-16 10:45                 ` Marius Bakke
2016-08-16 20:47                   ` Leo Famulari
2016-08-16 23:31                     ` Ben Woodcroft
2016-08-16 23:45                       ` Leo Famulari
2016-08-17  3:24                         ` Ben Woodcroft
2016-08-17  5:01                           ` Ben Woodcroft
2016-08-17 14:48                           ` Marius Bakke
2016-08-18 20:23                             ` Leo Famulari
2016-08-19 10:52                               ` Marius Bakke
2016-08-21 20:17                                 ` Leo Famulari
2016-08-22  2:30                                   ` Ben Woodcroft
2016-08-22 12:01                                     ` Marius Bakke
2016-08-23 18:33                                       ` Marius Bakke
2016-08-24 10:26                                         ` Marius Bakke
2016-08-24 17:26                                           ` Leo Famulari
2016-08-24 19:08                                             ` Marius Bakke
2016-08-24 22:51                                               ` Ben Woodcroft [this message]
2016-08-30 14:43                                               ` Marius Bakke
2016-08-31 19:09                                                 ` Leo Famulari
2016-09-09 12:15                                                   ` Marius Bakke
2016-09-10 12:32                                                     ` Marius Bakke
2016-09-10 18:16                                                       ` Leo Famulari
2016-09-13  5:14                                                         ` Leo Famulari
2016-09-13  5:14                                                       ` Leo Famulari
2016-08-18 20:18                           ` Leo Famulari

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CD768191-982B-4CE5-B1B0-84B576A42AE5@gmail.com \
    --to=woodibe@gmail.com \
    --cc=alezost@gmail.com \
    --cc=guix-devel@gnu.org \
    --cc=leo@famulari.name \
    --cc=mbakke@fastmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).