From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jelle Licht Subject: Re: [PATCH 3/4] gnu: node: Do not use bundled dependencies. Date: Sun, 28 Aug 2016 21:38:00 +0200 Message-ID: References: <20160827112333.1759-1-jlicht@fsfe.org> <20160827112333.1759-4-jlicht@fsfe.org> <87a8fydk22.fsf@gmail.com> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=047d7bb70b36a3c3b7053b26e278 Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:55519) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1be5uF-0007Ye-M9 for guix-devel@gnu.org; Sun, 28 Aug 2016 15:38:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1be5uB-0005BL-Ab for guix-devel@gnu.org; Sun, 28 Aug 2016 15:38:10 -0400 Received: from mail.fsfe.org ([2001:aa8:ffed::3:102]:53708) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1be5uA-0005Az-UR for guix-devel@gnu.org; Sun, 28 Aug 2016 15:38:07 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.fsfe.org (Postfix) with ESMTP id 609A963BADF for ; Sun, 28 Aug 2016 21:38:05 +0200 (CEST) Received: from mail.fsfe.org ([127.0.0.1]) by localhost (cavendish.fsfeurope.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id DTY6glD2s4GS for ; Sun, 28 Aug 2016 21:38:05 +0200 (CEST) Received: from mail-wm0-f46.google.com (mail-wm0-f46.google.com [74.125.82.46]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (not verified)) (Authenticated sender: jlicht) by mail.fsfe.org (Postfix) with ESMTPSA id BE82F63BAE6 for ; Sun, 28 Aug 2016 21:38:04 +0200 (CEST) Received: by mail-wm0-f46.google.com with SMTP id o80so62239407wme.1 for ; Sun, 28 Aug 2016 12:38:04 -0700 (PDT) In-Reply-To: <87a8fydk22.fsf@gmail.com> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Alex Kost Cc: guix-devel --047d7bb70b36a3c3b7053b26e278 Content-Type: text/plain; charset=UTF-8 2016-08-27 22:38 GMT+02:00 Alex Kost : > Jelle Licht (2016-08-27 14:23 +0300) wrote: > > > The Node build system was previously building its own copies of > > C-ares and http-parser. > > > > * gnu/packages/node.scm (node)[inputs]: Add c-ares and http-parser. > > [arguments]: Add configure flags for using system libraries. > > --- > > gnu/packages/node.scm | 7 ++++++- > > 1 file changed, 6 insertions(+), 1 deletion(-) > > > > > > diff --git a/gnu/packages/node.scm b/gnu/packages/node.scm > > index d1c5e1b..7c020e6 100644 > > --- a/gnu/packages/node.scm > > +++ b/gnu/packages/node.scm > > @@ -25,6 +25,7 @@ > > #:use-module (guix derivations) > > #:use-module (guix download) > > #:use-module (guix build-system gnu) > > + #:use-module (gnu packages adns) > > #:use-module (gnu packages base) > > #:use-module (gnu packages compression) > > #:use-module (gnu packages gcc) > > @@ -86,6 +87,8 @@ it does not buffer data, it can be interrupted at > anytime.") > > '(#:configure-flags '("--shared-openssl" > > "--shared-zlib" > > "--shared-libuv" > > + "--shared-cares" > > + "--shared-http-parser" > > "--without-snapshot") > > #:phases > > (modify-phases %standard-phases > > @@ -158,7 +161,9 @@ it does not buffer data, it can be interrupted at > anytime.") > > (inputs > > `(("libuv" ,libuv) > > ("openssl" ,tls:openssl) > > - ("zlib" ,zlib))) > > + ("zlib" ,compression:zlib) > > This change shouldn't belong this patch: here you use 'compression' > prefix which is introduced by the next patch. This would leave the git > repo in a broken state on this commit. > > > + ("http-parser" ,http-parser) > > + ("c-ares" ,c-ares))) > > (synopsis "Evented I/O for V8 JavaScript") > > (description "Node.js is a platform built on Chrome's JavaScript > runtime > > for easily building fast, scalable network applications. Node.js uses > an > > -- > Alex > I probably put the wrong things together when rebasing. Should I provide updated patches in these threads, or should I just send in a new patch series? - Jelle --047d7bb70b36a3c3b7053b26e278 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
2016= -08-27 22:38 GMT+02:00 Alex Kost <alezost@gmail.com>:
Jelle L= icht (2016-08-27 14:23 +0300) wrote:

> The Node build system was previously building its own copies of
> C-ares and http-parser.
>
> * gnu/packages/node.scm (node)[inputs]: Add c-ares and http-parser. > [arguments]: Add configure flags for using system libraries.
> ---
>=C2=A0 gnu/packages/node.scm | 7 ++++++-
>=C2=A0 1 file changed, 6 insertions(+), 1 deletion(-)
>
>
> diff --git a/gnu/packages/node.scm b/gnu/packages/node.scm
> index d1c5e1b..7c020e6 100644
> --- a/gnu/packages/node.scm
> +++ b/gnu/packages/node.scm
> @@ -25,6 +25,7 @@
>=C2=A0 =C2=A0 #:use-module (guix derivations)
>=C2=A0 =C2=A0 #:use-module (guix download)
>=C2=A0 =C2=A0 #:use-module (guix build-system gnu)
> +=C2=A0 #:use-module (gnu packages adns)
>=C2=A0 =C2=A0 #:use-module (gnu packages base)
>=C2=A0 =C2=A0 #:use-module (gnu packages compression)
>=C2=A0 =C2=A0 #:use-module (gnu packages gcc)
> @@ -86,6 +87,8 @@ it does not buffer data, it can be interrupted at an= ytime.")
>=C2=A0 =C2=A0 =C2=A0 =C2=A0'(#:configure-flags '("--shared= -openssl"
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0"--shared-zlib"
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0"--shared-libuv"
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0"--shared-cares"
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0"--shared-http-parser"
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0"--without-snapshot")
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0#:phases
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(modify-phases %standard-phases
> @@ -158,7 +161,9 @@ it does not buffer data, it can be interrupted at = anytime.")
>=C2=A0 =C2=A0 =C2=A0 (inputs
>=C2=A0 =C2=A0 =C2=A0 =C2=A0`(("libuv" ,libuv)
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0("openssl" ,tls:openssl) > -=C2=A0 =C2=A0 =C2=A0 =C2=A0("zlib" ,zlib)))
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0("zlib" ,compression:zlib)

This change shouldn't belong this patch: here you use '= compression'
prefix which is introduced by the next patch.=C2=A0 This would leave the gi= t
repo in a broken state on this commit.

> +=C2=A0 =C2=A0 =C2=A0 =C2=A0("http-parser" ,http-parser)
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0("c-ares" ,c-ares)))
>=C2=A0 =C2=A0 =C2=A0 (synopsis "Evented I/O for V8 JavaScript"= ;)
>=C2=A0 =C2=A0 =C2=A0 (description "Node.js is a platform built on = Chrome's JavaScript runtime
>=C2=A0 for easily building fast, scalable network applications.=C2=A0 N= ode.js uses an

--
Alex

I pro= bably put the wrong things together when rebasing. Should I provide updated=
patches in these threads, or should I just send in a new patch series?=

- Jelle
--047d7bb70b36a3c3b7053b26e278--