From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id SPsiNR6cqWU9IQAA62LTzQ:P1 (envelope-from ) for ; Thu, 18 Jan 2024 22:46:07 +0100 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id SPsiNR6cqWU9IQAA62LTzQ (envelope-from ) for ; Thu, 18 Jan 2024 22:46:06 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=OlN3tcwc; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1705614366; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=fNNFfhEA9wCWFp0FPln7RHilTYxOjZDPy9QAu6/WBDc=; b=mFCJ6Av7VVBGp0PFawVsrOLUzBrHArVBx6sjfibC9EzNHf8ER7Ta6aMYFxt3V6BHoPGYXt sS0pEC5yMnsHavFLphWnpDsQ5fKP1XkfiryH0sVQr+BsXepLELazFLHYe1mDEXYamHrbFE f4IC4rOP3058N09/XTFxGgvtg9MOCE6QjqdvdsblxjoOWIunm63l454gIRT9cc581R5gLM 1pw3oOLbYyOm/zrDRh5U9grBQwpQ+NJM3qtMXxyZun6xr4QTZSll5lJ8ZpFG34eE8gEbtp kN1fE7H/1ZNsLhBab4cCwf4poAyRt9tE8o5KZBPj0tstuLahc0QMDCis9rRr3A== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=OlN3tcwc; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=key1; d=yhetil.org; t=1705614366; a=rsa-sha256; cv=none; b=U/F4HfOC2yRRUGYzKr90MIGclZEL6HqoDKEWSebmtLsADQXtnQRSjHlZ50iOadLcwuLDO9 9Llia7iChIWNlCksP5Z2Y2AVpDzbOoamwgymWiW64rX8RPRhkQOnN1DxJkXkv5gUWi/ow0 3iomFNMC7KK9cI4CbxRVQ4UnH0RjHlknPXXyvvMWxV3nAh+eTEYNcS0jyzDHIVCtqx3XOP VA8c2lPT7LpYHlgYXz3G0QeyCR+4lAd+KvD0O1SBc1M30GUgB7dlEs+AqMFxNMM/X9SP9v Uuf/xB4RkLMiGFNKJ2Gvd6y+OXtS5LthzFXpTssZtL4l+N4PZEjNwkL/nW4eTw== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 78B3643EFF for ; Thu, 18 Jan 2024 22:46:06 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rQaCV-0004ei-Ev; Thu, 18 Jan 2024 16:45:27 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rQaCT-0004eT-2F for guix-devel@gnu.org; Thu, 18 Jan 2024 16:45:25 -0500 Received: from mail-lj1-x231.google.com ([2a00:1450:4864:20::231]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rQaCR-0008LV-14 for guix-devel@gnu.org; Thu, 18 Jan 2024 16:45:24 -0500 Received: by mail-lj1-x231.google.com with SMTP id 38308e7fff4ca-2cddb11b2e2so1956381fa.1 for ; Thu, 18 Jan 2024 13:45:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1705614320; x=1706219120; darn=gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=fNNFfhEA9wCWFp0FPln7RHilTYxOjZDPy9QAu6/WBDc=; b=OlN3tcwcI6KWng27BBrpU3oOqgbG1S6JZimIESipmS8cspQhlMPBRr/qflcHAg/ayr CvBYSIxJYL/5KeIxQWnnoRT9HhlY7MHXvFG4P8ejZ7LhcycWV9NdBBbo0DYkPDZE4Q6Y cNXMQVzdd/oOkyiJ4HmWmEWVnrfcrSocmLohzk29EguXYAqytP4n4RkrHd7vj8nYL57s Z/C3KHK4tjktU9qjUVke0SmgGrPGEHopWU9CmUCUgbQIXEuzfwStvNA4kuae7smWS0e9 GZyEvuISoiW9eF9AohXIVc7XjAuxtW/ITzsAmCGlpGW/YsASPAZxhjUpga/L34SmAWjg KfVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705614320; x=1706219120; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fNNFfhEA9wCWFp0FPln7RHilTYxOjZDPy9QAu6/WBDc=; b=HpqBsowwnX9WJw+Or35Dp4KYwXE7qwlwlr4aDYlGSzs2rAH+pT4GwshEv/jMgMywMg pzVZfzJyWgng2lVgnzYQ5cIemRuA9i9bTMhg/FrMweB3dT4Cm/i2Pums49U6RFJZ+bX6 0XrXELCJ77VSApVWPsz5sEQtvcNp78VuUrstvGqTglkExZVFtdC1iGwDbRAaxq2X1TeZ hXwtmv04/FwimXrBhK3lFPEJvPFo+YMzgtow9hCi/tOtfc9RcK+Iq42OpkUtEQ5pXK2J fYyvagFu7ZyPxKFHu6i3r2SthLXbPKpL5nBVupS91uAKQQIXg0ldkAhQu1mxmKAfkbdz dMNA== X-Gm-Message-State: AOJu0YwV6fvTiK7Sa92LUFXI5ws1Z6bFApKawjW0EbzZYW3I+jsBM8Xd 1i6t1JEf5DPWdSF8pY8bF8drgH8q/THgvzwTROuNvPe2jC8yN0T/hGyRTIMpqseRM7Mb7epbDLr SKngzTT2MAL30ji4fNJl0d079oLM= X-Google-Smtp-Source: AGHT+IGVoCVFr+1USQezJQ5rGAS56alNvUKDgD98PYAfo7p5XBP7/27xQugSLsHvuIAjM59axeIZJei+qC1w+Afp9gY= X-Received: by 2002:a05:651c:1551:b0:2cd:f946:d474 with SMTP id y17-20020a05651c155100b002cdf946d474mr1080905ljp.94.1705614320311; Thu, 18 Jan 2024 13:45:20 -0800 (PST) MIME-Version: 1.0 References: <65b75d58-e27b-4d02-80be-d87b86bf0342@troyfigiel.com> <87r0igt0r9.fsf@gmail.com> <7b1e5ca5-9088-4522-adc0-2330d2b7bb94@troyfigiel.com> In-Reply-To: <7b1e5ca5-9088-4522-adc0-2330d2b7bb94@troyfigiel.com> From: Sharlatan Hellseher Date: Thu, 18 Jan 2024 21:45:08 +0000 Message-ID: Subject: Re: Golang check phase skipping some tests? To: Troy Figiel Cc: Simon Tournier , guix-devel@gnu.org, Katherine Cox-Buday Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2a00:1450:4864:20::231; envelope-from=sharlatanus@gmail.com; helo=mail-lj1-x231.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: guix-devel-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -7.49 X-Migadu-Queue-Id: 78B3643EFF X-Spam-Score: -7.49 X-Migadu-Scanner: mx11.migadu.com X-TUID: TXpdlROgsbf3 Hi, There are not too many Golang packages in Guix comparing to other language spectific modules: --8<---------------cut here---------------start------------->8--- grep -r "build-system go-build-system" gnu/packages | awk '{print $1}' | sort | uniq -c | sort -rn 382 gnu/packages/golang.scm: 47 gnu/packages/golang-web.scm: 34 gnu/packages/syncthing.scm: 17 gnu/packages/golang-check.scm: 9 gnu/packages/web.scm: 8 gnu/packages/version-control.scm: 7 gnu/packages/databases.scm: 5 gnu/packages/ipfs.scm: 5 gnu/packages/bioinformatics.scm: 4 gnu/packages/virtualization.scm: 4 gnu/packages/networking.scm: 4 gnu/packages/mail.scm: 4 gnu/packages/games.scm: 4 gnu/packages/docker.scm: 4 gnu/packages/check.scm: 3 gnu/packages/file-systems.scm: 3 gnu/packages/admin.scm: 2 gnu/packages/time.scm: 2 gnu/packages/textutils.scm: 2 gnu/packages/terminals.scm: 2 gnu/packages/password-utils.scm: 2 gnu/packages/messaging.scm: 2 gnu/packages/irc.scm: 2 gnu/packages/geo.scm: 2 gnu/packages/education.scm: 2 gnu/packages/curl.scm: 2 gnu/packages/containers.scm: 2 gnu/packages/backup.scm: 1 gnu/packages/xdisorg.scm: 1 gnu/packages/web-browsers.scm: 1 gnu/packages/weather.scm: 1 gnu/packages/vpn.scm: 1 gnu/packages/tls.scm: 1 gnu/packages/terraform.scm: 1 gnu/packages/tcl.scm: 1 gnu/packages/task-runners.scm: 1 gnu/packages/task-management.scm: 1 gnu/packages/sync.scm: 1 gnu/packages/shellutils.scm: 1 gnu/packages/radio.scm: 1 gnu/packages/pulseaudio.scm: 1 gnu/packages/music.scm: 1 gnu/packages/monitoring.scm: 1 gnu/packages/linux.scm: 1 gnu/packages/image-viewers.scm: 1 gnu/packages/hyperledger.scm: 1 gnu/packages/high-availability.scm: 1 gnu/packages/finance.scm: 1 gnu/packages/disk.scm: 1 gnu/packages/debug.scm: 1 gnu/packages/crypto.scm: 1 gnu/packages/configuration-management.scm: 1 gnu/packages/compression.scm: 1 gnu/packages/calendar.scm: 1 gnu/packages/authentication.scm: 1 gnu/packages/android.scm: --8<---------------cut here---------------start------------->8--- We may enable it globally and rebuild each package and pack and place missi= ng in native inputs/propagated inputs depending on the purpose. I would love to investigate the count of packages in `34 gnu/packages/syncthing.scm:` :-) Thanks, Oleg On Thu, 18 Jan 2024 at 21:31, Troy Figiel wrote: > > Hi Oleg and others, > > On 2024-01-18 11:25, Sharlatan Hellseher wrote: > > With small adjustment of the invok line, I could manage to trigger all = tests to > > be run, but it brings other issue of some not packed modules required f= or the > > check phase. > > Thanks for the update! I noticed the same with `go-github-com-kr-text'. > It was actually missing a propagated-input that has not been packaged > yet, so I couldn't easily fix it. > > On 2024-01-18 11:25, Sharlatan Hellseher wrote: > > As a quick ad-hoc to run all tests for some new package you may add a c= ustom > > check phase with the snippet you provided. > > > > I'm currently in review and split some packages from (gnu packages gola= ng) into > > (gnu packages golang-crypto) to simplify the maintenance. I try to play= with > > that option and see which packages are missed to satisfy passing all te= sts. > > Once the migration is over, what would you recommend for new packages? I > could see two options here: > > 1. Change the default check phase and only replace it back to the > previous one for packages that fail to build or > > 2. Replace the check phase for all packages one-by-one. > > I noticed this behaviour when I was packaging gotenberg and as with any > reasonably sized Golang package, this one also has a gazillion > dependencies... I would love to start on the right track :-) > > Best wishes, > > Troy --=20 VCS: https://github.incerto.xyz/; https://git.sr.ht/~hellseher/ GPG: 9847 81DE 689C 21C2 6418 0867 76D7 27BF F62C D2B5 =E2=80=A6 =D0=BD=D0=B0=D1=88 =D1=80=D0=B0=D0=B7=D1=83=D0=BC - =D0=BF=D1=80= =D0=B5=D0=B2=D0=BE=D1=81=D1=85=D0=BE=D0=B4=D0=BD=D0=B0=D1=8F =D0=BE=D0=B1= =D1=8A=D1=8F=D1=81=D0=BD=D0=B8=D1=82=D0=B5=D0=BB=D1=8C=D0=BD=D0=B0=D1=8F = =D0=BC=D0=B0=D1=88=D0=B8=D0=BD=D0=B0 =D0=BA=D0=BE=D1=82=D0=BE=D1=80=D0=B0= =D1=8F =D1=81=D0=BF=D0=BE=D1=81=D0=BE=D0=B1=D0=BD=D0=B0 =D0=BD=D0=B0=D0=B9=D1=82=D0=B8 =D1=81=D0=BC=D1=8B=D1=81=D0=BB =D0=BF=D0=BE= =D1=87=D1=82=D0=B8 =D0=B2 =D1=87=D0=B5=D0=BC =D1=83=D0=B3=D0=BE=D0=B4=D0=BD= =D0=BE, =D0=B8=D1=81=D1=82=D0=BE=D0=BB=D0=BA=D0=BE=D0=B2=D0=B0=D1=82=D1=8C = =D0=BB=D1=8E=D0=B1=D0=BE=D0=B9 =D1=84=D0=B5=D0=BD=D0=BE=D0=BC=D0=B5=D0=BD, = =D0=BD=D0=BE =D1=81=D0=BE=D0=B2=D0=B5=D1=80=D1=88=D0=B5=D0=BD=D0=BD=D0=BE =D0=BD=D0=B5 = =D0=B2 =D1=81=D0=BE=D1=81=D1=82=D0=BE=D1=8F=D0=BD=D0=B8=D0=B8 =D0=BF=D1=80= =D0=B8=D0=BD=D1=8F=D1=82=D1=8C =D0=BC=D1=8B=D1=81=D0=BB=D1=8C =D0=BE =D0=BD= =D0=B5=D0=BF=D1=80=D0=B5=D0=B4=D1=81=D0=BA=D0=B0=D0=B7=D1=83=D0=B5=D0=BC=D0= =BE=D1=81=D1=82=D0=B8.