From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Du=C5=A1an_Xmetov?= Subject: Re: [PATCH 3/3] gnu: Add mupdf Date: Mon, 15 Sep 2014 07:20:35 +0200 Message-ID: References: <874mw95vi4.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:51267) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XTOiK-0006Wh-PT for guix-devel@gnu.org; Mon, 15 Sep 2014 01:20:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XTOiK-0003Hx-22 for guix-devel@gnu.org; Mon, 15 Sep 2014 01:20:36 -0400 Received: from mail-vc0-x232.google.com ([2607:f8b0:400c:c03::232]:40869) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XTOiJ-0003Hr-SJ for guix-devel@gnu.org; Mon, 15 Sep 2014 01:20:35 -0400 Received: by mail-vc0-f178.google.com with SMTP id hy4so2983360vcb.9 for ; Sun, 14 Sep 2014 22:20:35 -0700 (PDT) In-Reply-To: <874mw95vi4.fsf@gmail.com> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Alex Kost Cc: guix-devel@gnu.org On 9/15/14, Alex Kost wrote: > Hello, I don't have real comments, I just noticed a couple of typos. Thanks :) >> >> * gnu/packages/pdf.scm (mupdf): New variable. >> * gnu/packages/patches/mupdf-buildsystem-fix.patch: New vile. > > New file. > Yup. > > 5 * trailing space. > They were generated by diff, won't removing them break the patch? > >> + (inputs >> + `(("curl" ,curl) >> + ("freetype", freetype) > > ("freetype" ,freetype) > Yup. > >> + (synopsis "A lightweight PDF viewer and toolkit.") >> + (description >> + "MuPDF is a C library that implements a PDF and XPS parsing and >> rendering >> +engine. It is used primarily to render pages into bitmaps, but also >> provides >> +support for other operations such as searching and listing the table of >> +contents and hyperlinks. >> + >> +The library ships with a rudimentary X11 viewer, and a set of command >> line tools >> +for batch rendering (pdfdraw), examining the file structure (pdfshow), >> and >> +rewriting files (pdfclean).") >> + (license license:agpl3+))) > > I think people usually avoid a period in a synopsis and use a double > space after a period in a description. Also the description should be > wrapped by 72 (or 78?) characters in a line. Yup. Thanks for the reply, I'll try to fix the patch, but I don't know about the trailing spaces, I kind of don't want to touch diff's output.