From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxim Cournoyer Subject: Re: [PATCH 3/3] gnu: Add filezilla. Date: Wed, 15 Feb 2017 13:13:40 -0800 Message-ID: References: <20170209163618.1759-1-rennes@openmailbox.org> <20170209163618.1759-4-rennes@openmailbox.org> <87o9y64y0y.fsf@gmail.com> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=001a113f42e6a200c40548982761 Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:34429) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ce6tU-00037X-CC for guix-devel@gnu.org; Wed, 15 Feb 2017 16:13:45 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ce6tS-0001AS-V9 for guix-devel@gnu.org; Wed, 15 Feb 2017 16:13:44 -0500 Received: from mail-qt0-x241.google.com ([2607:f8b0:400d:c0d::241]:36486) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ce6tS-00019D-Pz for guix-devel@gnu.org; Wed, 15 Feb 2017 16:13:42 -0500 Received: by mail-qt0-x241.google.com with SMTP id h53so22781141qth.3 for ; Wed, 15 Feb 2017 13:13:41 -0800 (PST) In-Reply-To: List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: rennes Cc: guix-devel --001a113f42e6a200c40548982761 Content-Type: text/plain; charset=UTF-8 Hi, While I haven't tried it, the patch looks good to me! Maxim On Tue, Feb 14, 2017 at 9:44 PM, wrote: > > Minor thing, and I'm not sure if we have a convention for this, but it'd >> be neat to keep the use-module statements ordered alphabetically. >> >> > Ordered alphabetically! > > >> Again, I'm under the impression that this should rather be gpl2+. I'd be >> happy to be proven wrong otherwise! >> >> + (properties '((upstream-name . "FileZilla"))))) >>> >> >> Otherwise LGTM (haven't tested though). >> > > Updated patch. Thanks --001a113f42e6a200c40548982761 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi,

While I haven't tried it, t= he patch looks good to me!

Maxim


On Tue, Feb 14, 2017 at 9:44 PM, = <rennes@openmailbox.org> wrote:

Minor thing, and I'm not sure if we have a convention for this, but it&= #39;d
be neat to keep the use-module statements ordered alphabetically.


 Ordered alphabetically!


Again, I'm under the impression that this should rather be gpl2+. I'= ;d be
happy to be proven wrong otherwise!

+=C2=A0 =C2=A0 (properties '((upstream-name . "FileZilla"))))= )

Otherwise LGTM (haven't tested though).

 Updated patch. Thanks

--001a113f42e6a200c40548982761--