From mboxrd@z Thu Jan 1 00:00:00 1970 From: Omar Radwan Subject: Re: [PATCH] gnu: Add urwid Date: Mon, 2 Feb 2015 09:46:10 -0800 Message-ID: References: <87bnlddowe.fsf@netris.org> <87y4ogdg32.fsf@netris.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=047d7bdca2989fda09050e1e877b Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:56687) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YIL4e-0001QN-O9 for guix-devel@gnu.org; Mon, 02 Feb 2015 12:46:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YIL4d-0001zi-Ix for guix-devel@gnu.org; Mon, 02 Feb 2015 12:46:12 -0500 Received: from mail-ig0-x22d.google.com ([2607:f8b0:4001:c05::22d]:39233) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YIL4d-0001za-DU for guix-devel@gnu.org; Mon, 02 Feb 2015 12:46:11 -0500 Received: by mail-ig0-f173.google.com with SMTP id a13so20064635igq.0 for ; Mon, 02 Feb 2015 09:46:10 -0800 (PST) In-Reply-To: <87y4ogdg32.fsf@netris.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Mark H Weaver Cc: guix-devel --047d7bdca2989fda09050e1e877b Content-Type: text/plain; charset=UTF-8 My mistake. I was in such a hurry. I'll get it in asap On Feb 1, 2015 9:42 PM, "Mark H Weaver" wrote: > Omar Radwan writes: > > Here's a patch that does all the changes you requested to the previous > > patch file > > A few problems here: > > (1) This new version doesn't even compile, because of several typos. > Please always test before sending patches. > > (2) Instead of sending a patch that assumes the first version of your > patch has been applied, please send a patch that can be applied by > itself. > > (3) In the description, don't put two spaces between every two words, > just between sentences. > > (4) In the source URI specification, please follow our Scheme > indentation and spacing conventions, as I showed in my last message > in this thread. > > Can you send an updated patch? > > Mark > --047d7bdca2989fda09050e1e877b Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable

My mistake. I was in such a hurry. I'll get it in asap

On Feb 1, 2015 9:42 PM, "Mark H Weaver"= ; <mhw@netris.org> wrote:
Omar Radwan <toxemicsquire4@gmail.com> write= s:
> Here's a patch that does all the changes you requested to the prev= ious
> patch file

A few problems here:

(1) This new version doesn't even compile, because of several typos. =C2=A0 =C2=A0 Please always test before sending patches.

(2) Instead of sending a patch that assumes the first version of your
=C2=A0 =C2=A0 patch has been applied, please send a patch that can be appli= ed by
=C2=A0 =C2=A0 itself.

(3) In the description, don't put two spaces between every two words, =C2=A0 =C2=A0 just between sentences.

(4) In the source URI specification, please follow our Scheme
=C2=A0 =C2=A0 indentation and spacing conventions, as I showed in my last m= essage
=C2=A0 =C2=A0 in this thread.

Can you send an updated patch?

=C2=A0 =C2=A0 =C2=A0 Mark
--047d7bdca2989fda09050e1e877b--