From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vicente Vera Subject: Re: [PATCH 11/19] gnu: Add r-knitr. Date: Mon, 14 Sep 2015 17:06:34 -0300 Message-ID: References: <87bnd58d2l.fsf@mdc-berlin.de> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary=001a11c2f6a026e09e051fba9a04 Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:40663) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zba1M-0006HO-T4 for guix-devel@gnu.org; Mon, 14 Sep 2015 16:06:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zba1L-0002Bg-F3 for guix-devel@gnu.org; Mon, 14 Sep 2015 16:06:36 -0400 Received: from mail-ob0-x234.google.com ([2607:f8b0:4003:c01::234]:35837) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zba1L-0002Bc-0Z for guix-devel@gnu.org; Mon, 14 Sep 2015 16:06:35 -0400 Received: by obbzf10 with SMTP id zf10so62223844obb.2 for ; Mon, 14 Sep 2015 13:06:34 -0700 (PDT) In-Reply-To: <87bnd58d2l.fsf@mdc-berlin.de> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Ricardo Wurmus Cc: guix-devel@gnu.org --001a11c2f6a026e09e051fba9a04 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hello, I'm not sure if it's correct, but I changed the license from gpl3+ to gpl2+ to keep it consistent with the r-markdown package (https://www.gnu.org/licenses/gpl-faq.html#v2v3Compatibility). Thanks for figuring that out. New patch attached. 2015-09-14 8:17 GMT-03:00 Ricardo Wurmus : > Hi Vicente, > >> From 36f94f07cba5edea4897ac36b92a73bfc6a3258b Mon Sep 17 00:00:00 2001 >> From: Vicente Vera Parra >> Date: Sun, 13 Sep 2015 13:20:29 -0300 >> Subject: [PATCH 11/19] gnu: Add r-knitr. > >> * gnu/packages/statistics.scm (r-knitr): New variable. > > [...] > >> + (synopsis "General-Purpose Package for Dynamic Report Generation in= R") >> + (description >> + "Provides a general-purpose tool for dynamic report generation in >> +R using Literate Programming techniques.") > > As before, please provide a better description (at least by replacing > =E2=80=9CProvides=E2=80=9D in the first sentence with =E2=80=9CThis packa= ge provides=E2=80=9D); and use > lower-case in the synopsis. > >> + (license license:gpl3+))) > > I don=E2=80=99t think this is correct. The package actually doesn=E2=80= =99t declare the > version of the GPL. There are no license headers I could find and all > it says is > > =E2=80=9CThis package is free and open source software, licensed unde= r GPL.=E2=80=9D > > Furthermore, as noted before, there might be a license conflict when > combining =E2=80=9Cr-knitr=E2=80=9D with =E2=80=9Cr-markdown=E2=80=9D, be= cause the latter is released > under =E2=80=9CGPLv2 only=E2=80=9D. > > I just asked the author about what version of the GPL was intended > here[1]. > > ~~ Ricardo > > [1]: https://github.com/yihui/knitr/issues/566#issuecomment-140042571 --001a11c2f6a026e09e051fba9a04 Content-Type: text/x-patch; charset=US-ASCII; name="0011-gnu-Add-r-knitr.patch" Content-Disposition: attachment; filename="0011-gnu-Add-r-knitr.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_iekctyx10 RnJvbSBiMDA5MGQ4ZTkyMzY1OTVhZDcyYjMzNzE2OGEwOGViOTM2OTg0MGNhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBWaWNlbnRlIFZlcmEgUGFycmEgPHZpY2VudGVtdnBAZ21haWwu Y29tPgpEYXRlOiBNb24sIDE0IFNlcCAyMDE1IDE2OjA1OjI0IC0wMzAwClN1YmplY3Q6IFtQQVRD SCAxMS8xMl0gZ251OiBBZGQgci1rbml0ci4KCiogZ251L3BhY2thZ2VzL3N0YXRpc3RpY3Muc2Nt IChyLWtuaXRyKTogTmV3IHZhcmlhYmxlLgotLS0KIGdudS9wYWNrYWdlcy9zdGF0aXN0aWNzLnNj bSB8IDI2ICsrKysrKysrKysrKysrKysrKysrKysrKysrCiAxIGZpbGUgY2hhbmdlZCwgMjYgaW5z ZXJ0aW9ucygrKQoKZGlmZiAtLWdpdCBhL2dudS9wYWNrYWdlcy9zdGF0aXN0aWNzLnNjbSBiL2du dS9wYWNrYWdlcy9zdGF0aXN0aWNzLnNjbQppbmRleCA5Nzk0OTA4Li5lMWYxNmQ1IDEwMDY0NAot LS0gYS9nbnUvcGFja2FnZXMvc3RhdGlzdGljcy5zY20KKysrIGIvZ251L3BhY2thZ2VzL3N0YXRp c3RpY3Muc2NtCkBAIC03MDAsMyArNzAwLDI5IEBAIGh0dHA6Ly9lbi53aWtpcGVkaWEub3JnL3dp a2kvTWFya2Rvd24gZm9yIG1vcmUgaW5mb3JtYXRpb24gYWJvdXQgTWFya2Rvd24uIikKICAgICAg IlRoaXMgcGFja2FnZSBpbXBsZW1lbnRzIHRoZSBsaWJ5YW1sIFlBTUwgMS4xIHBhcnNlciBhbmQK IGVtaXR0ZXIgKGh0dHA6Ly9weXlhbWwub3JnL3dpa2kvTGliWUFNTCkgZm9yIFIuIikKICAgICAo bGljZW5zZSBsaWNlbnNlOmJzZC0zKSkpCisKKyhkZWZpbmUtcHVibGljIHIta25pdHIKKyAgKHBh Y2thZ2UKKyAgICAobmFtZSAici1rbml0ciIpCisgICAgKHZlcnNpb24gIjEuMTEiKQorICAgIChz b3VyY2UgKG9yaWdpbgorICAgICAgICAgICAgICAobWV0aG9kIHVybC1mZXRjaCkKKyAgICAgICAg ICAgICAgKHVyaSAoc3RyaW5nLWFwcGVuZCAibWlycm9yOi8vY3Jhbi9zcmMvY29udHJpYi9rbml0 cl8iCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgdmVyc2lvbiAiLnRhci5neiIp KQorICAgICAgICAgICAgICAoc2hhMjU2CisgICAgICAgICAgICAgICAoYmFzZTMyICIxaWtqbGEw aG5wamZrZGJ5ZHFoaHF5cGMwYWlpemJpNG55bjhjNjk0c2RrOWNhNGphc2RkIikpKSkKKyAgICAo YnVpbGQtc3lzdGVtIHItYnVpbGQtc3lzdGVtKQorICAgIChwcm9wYWdhdGVkLWlucHV0cworICAg ICBgKCgici1ldmFsdWF0ZSIgLHItZXZhbHVhdGUpCisgICAgICAgKCJyLWRpZ2VzdCIgLHItZGln ZXN0KQorICAgICAgICgici1mb3JtYXRyIiAsci1mb3JtYXRyKQorICAgICAgICgici1oaWdociIg LHItaGlnaHIpCisgICAgICAgKCJyLW1hcmtkb3duIiAsci1tYXJrZG93bikKKyAgICAgICAoInIt c3RyaW5nciIgLHItc3RyaW5ncikKKyAgICAgICAoInIteWFtbCIgLHIteWFtbCkpKQorICAgICho b21lLXBhZ2UgImh0dHA6Ly95aWh1aS5uYW1lL2tuaXRyLyIpCisgICAgKHN5bm9wc2lzICJHZW5l cmFsLXB1cnBvc2UgcGFja2FnZSBmb3IgZHluYW1pYyByZXBvcnQgZ2VuZXJhdGlvbiBpbiBSIikK KyAgICAoZGVzY3JpcHRpb24KKyAgICAgIlRoaXMgcGFja2FnZSBwcm92aWRlcyBhIGdlbmVyYWwt cHVycG9zZSB0b29sIGZvciBkeW5hbWljIHJlcG9ydAorZ2VuZXJhdGlvbiBpbiBSIHVzaW5nIExp dGVyYXRlIFByb2dyYW1taW5nIHRlY2huaXF1ZXMuIikKKyAgICAobGljZW5zZSBsaWNlbnNlOmdw bDIrKSkpCi0tIAoyLjUuMgoK --001a11c2f6a026e09e051fba9a04--