From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vicente Vera Subject: Re: [PATCH 09/19] gnu: Add r-markdown. Date: Mon, 14 Sep 2015 16:59:21 -0300 Message-ID: References: <87d1xl8deo.fsf@mdc-berlin.de> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary=001a1136038a58ca0f051fba80ea Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:38760) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZbZuS-0005wp-2Y for guix-devel@gnu.org; Mon, 14 Sep 2015 15:59:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZbZuQ-0007SN-NY for guix-devel@gnu.org; Mon, 14 Sep 2015 15:59:28 -0400 Received: from mail-ob0-x235.google.com ([2607:f8b0:4003:c01::235]:33850) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZbZuQ-0007SH-Ct for guix-devel@gnu.org; Mon, 14 Sep 2015 15:59:26 -0400 Received: by obbda8 with SMTP id da8so117455834obb.1 for ; Mon, 14 Sep 2015 12:59:21 -0700 (PDT) In-Reply-To: <87d1xl8deo.fsf@mdc-berlin.de> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Ricardo Wurmus Cc: guix-devel@gnu.org --001a1136038a58ca0f051fba80ea Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hello Ricardo, Both the code and the comment related to the check phase were changed. Indeed, the comment was pretty much unreadable. Hope the new one is better. New patch attached. 2015-09-14 8:10 GMT-03:00 Ricardo Wurmus : > >> From 7e291c7f87498368be556941f6eb7315f94a7c74 Mon Sep 17 00:00:00 2001 >> From: Vicente Vera Parra >> Date: Sun, 13 Sep 2015 13:17:39 -0300 >> Subject: [PATCH 09/19] gnu: Add r-markdown. > >> * gnu/packages/statistics.scm (r-markdown): New variable. > > [...] > >> + ;; Skip check phase because the tests require knitr to be >> + ;; installed. Since it won't (markdown is a dependency of the knitr >> + ;; package), installation will fail. >> + (arguments >> + `(#:phases >> + (modify-phases %standard-phases >> + (delete 'check)))) > > Two things: 1) the comment isn=E2=80=99t very clear. =E2=80=9CSince it w= on=E2=80=99t=E2=80=9D what? Maybe > you can rephrase. 2) Instead of deleting the =E2=80=9Ccheck=E2=80=9D pha= se just write > > (arguments `(#:tests? #f)) > >> + (propagated-inputs >> + `(("r-mime" ,r-mime))) >> + (home-page "https://github.com/rstudio/markdown") >> + (synopsis "'Markdown' Rendering for R") > > Quoting =E2=80=9CMarkdown=E2=80=9D looks odd. How about just > > =E2=80=9CMarkdown rendering library for R=E2=80=9D > >> + (description >> + "Provides R bindings to the 'Sundown' 'Markdown' rendering >> +library (https://github.com/vmg/sundown). 'Markdown' is a plain-text >> +formatting syntax that can be converted to 'XHTML' or other formats. >> +See http://en.wikipedia.org/wiki/Markdown for more information about >> +'Markdown'.") > > The quoting looks very odd. Does this mean that =E2=80=9CSundown=E2=80= =9D must be > available at runtime in order to use the =E2=80=9Cr-markdown=E2=80=9D pac= kage? If this > is so, shouldn=E2=80=99t a =E2=80=9Csundown=E2=80=9D package be among the= inputs of this > package? > >> + (license license:gpl2))) > > This appears to be correct. The license headers of the files in the =E2= =80=9CR=E2=80=9D > directory only explicitly mention =E2=80=9Cversion 2=E2=80=9D, there is n= o =E2=80=9Cor later=E2=80=9D > clause. I just wonder what this means for libraries using > =E2=80=9Cr-markdown=E2=80=9D, such as =E2=80=9Cr-knitr=E2=80=9D, which ac= cording to your next patch is > supposedly released under =E2=80=9CGPLv3+=E2=80=9D. IIUC this cannot be = the case. > > ~~ Ricardo --001a1136038a58ca0f051fba80ea Content-Type: text/x-patch; charset=US-ASCII; name="0009-gnu-Add-r-markdown.patch" Content-Disposition: attachment; filename="0009-gnu-Add-r-markdown.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_iekco8sv0 RnJvbSA4ZGQ2YWYwMWNiMzk4NzlhYzFlNWVhYTAxYWJkZTkyMmY5Y2M3MDA4IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBWaWNlbnRlIFZlcmEgUGFycmEgPHZpY2VudGVtdnBAZ21haWwu Y29tPgpEYXRlOiBNb24sIDE0IFNlcCAyMDE1IDE1OjUwOjI2IC0wMzAwClN1YmplY3Q6IFtQQVRD SCAwOS8xMl0gZ251OiBBZGQgci1tYXJrZG93bi4KCiogZ251L3BhY2thZ2VzL3N0YXRpc3RpY3Mu c2NtIChyLW1hcmtkb3duKTogTmV3IHZhcmlhYmxlLgotLS0KIGdudS9wYWNrYWdlcy9zdGF0aXN0 aWNzLnNjbSB8IDI3ICsrKysrKysrKysrKysrKysrKysrKysrKysrKwogMSBmaWxlIGNoYW5nZWQs IDI3IGluc2VydGlvbnMoKykKCmRpZmYgLS1naXQgYS9nbnUvcGFja2FnZXMvc3RhdGlzdGljcy5z Y20gYi9nbnUvcGFja2FnZXMvc3RhdGlzdGljcy5zY20KaW5kZXggNWNlMDNmNC4uNTg4ZmQ2MiAx MDA2NDQKLS0tIGEvZ251L3BhY2thZ2VzL3N0YXRpc3RpY3Muc2NtCisrKyBiL2dudS9wYWNrYWdl cy9zdGF0aXN0aWNzLnNjbQpAQCAtNjU1LDMgKzY1NSwzMCBAQCB2aWEgQW5kcmUgU2ltb24ncyBo aWdobGlnaHQgcGFja2FnZSAoaHR0cDovL3d3dy5hbmRyZS1zaW1vbi5kZSkuIikKICAgICAgIlRo aXMgcGFja2FnZSBndWVzc2VzIHRoZSBNSU1FIHR5cGUgZnJvbSBhIGZpbGVuYW1lIGV4dGVuc2lv biB1c2luZyB0aGUKIGRhdGEgZGVyaXZlZCBmcm9tIC9ldGMvbWltZS50eXBlcyBpbiBVTklYLXR5 cGUgc3lzdGVtcy4iKQogICAgIChsaWNlbnNlIGxpY2Vuc2U6Z3BsMikpKQorCisoZGVmaW5lLXB1 YmxpYyByLW1hcmtkb3duCisgIChwYWNrYWdlCisgICAgKG5hbWUgInItbWFya2Rvd24iKQorICAg ICh2ZXJzaW9uICIwLjcuNyIpCisgICAgKHNvdXJjZSAob3JpZ2luCisgICAgICAgICAgICAgICht ZXRob2QgdXJsLWZldGNoKQorICAgICAgICAgICAgICAodXJpIChzdHJpbmctYXBwZW5kICJtaXJy b3I6Ly9jcmFuL3NyYy9jb250cmliL21hcmtkb3duXyIKKyAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICB2ZXJzaW9uICIudGFyLmd6IikpCisgICAgICAgICAgICAgIChzaGEyNTYKKyAg ICAgICAgICAgICAgIChiYXNlMzIgIjAwajFobGliM2lsNTBhenMydmxjeWhpMGJqcHgxcjUwbXhy OXc5ZGw1ZzFid2pqYzcxaGIiKSkpKQorICAgIChidWlsZC1zeXN0ZW0gci1idWlsZC1zeXN0ZW0p CisgICAgOzsgU2tpcCBjaGVjayBwaGFzZSBiZWNhdXNlIHRoZSB0ZXN0cyByZXF1aXJlIHRoZSBy LWtuaXRyIHBhY2thZ2UgdG8gYmUKKyAgICA7OyBpbnN0YWxsZWQuIFRoaXMgcHJldmVudHMgaW5z dGFsbGF0aW9uIGZhaWx1cmVzLiBLbml0ciBub3JtYWxseQorICAgIDs7IHNob3VsZG4ndCBiZSBh dmFpbGFibGUgc2luY2Ugci1tYXJrZG93biBpcyBhIGRlcGVuZGVuY3kgb2YgdGhlIHIta25pdHIK KyAgICA7OyBwYWNrYWdlLgorICAgIChhcmd1bWVudHMgYCgjOnRlc3RzPyAjZikpCisgICAgKHBy b3BhZ2F0ZWQtaW5wdXRzCisgICAgIGAoKCJyLW1pbWUiICxyLW1pbWUpKSkKKyAgICAoaG9tZS1w YWdlICJodHRwczovL2dpdGh1Yi5jb20vcnN0dWRpby9tYXJrZG93biIpCisgICAgKHN5bm9wc2lz ICJNYXJrZG93biByZW5kZXJpbmcgZm9yIFIiKQorICAgIChkZXNjcmlwdGlvbgorICAgICAiVGhp cyBwYWNrYWdlIHByb3ZpZGVzIFIgYmluZGluZ3MgdG8gdGhlIFN1bmRvd24gTWFya2Rvd24gcmVu ZGVyaW5nCitsaWJyYXJ5IChodHRwczovL2dpdGh1Yi5jb20vdm1nL3N1bmRvd24pLiAgTWFya2Rv d24gaXMgYSBwbGFpbi10ZXh0IGZvcm1hdHRpbmcKK3N5bnRheCB0aGF0IGNhbiBiZSBjb252ZXJ0 ZWQgdG8gWEhUTUwgb3Igb3RoZXIgZm9ybWF0cy4gIFNlZQoraHR0cDovL2VuLndpa2lwZWRpYS5v cmcvd2lraS9NYXJrZG93biBmb3IgbW9yZSBpbmZvcm1hdGlvbiBhYm91dCBNYXJrZG93bi4iKQor ICAgIChsaWNlbnNlIGxpY2Vuc2U6Z3BsMikpKQotLSAKMi41LjIKCg== --001a1136038a58ca0f051fba80ea--