unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
* Adding new R packages
@ 2015-09-13  5:26 Vicente Vera
  2015-09-13  7:29 ` Efraim Flashner
  0 siblings, 1 reply; 3+ messages in thread
From: Vicente Vera @ 2015-09-13  5:26 UTC (permalink / raw)
  To: guix-devel

Hi,
Just managed to define several new R packages which could be added to
the distribution. Basically it's just r-dplyr and its dependencies
(r-knitr, etc.).

Should I send a single patch for r-dplyr, or several patches, one for
each dependency (19)?

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Adding new R packages
  2015-09-13  5:26 Adding new R packages Vicente Vera
@ 2015-09-13  7:29 ` Efraim Flashner
  2015-09-13  9:42   ` Ludovic Courtès
  0 siblings, 1 reply; 3+ messages in thread
From: Efraim Flashner @ 2015-09-13  7:29 UTC (permalink / raw)
  To: Vicente Vera; +Cc: guix-devel

[-- Attachment #1: Type: text/plain, Size: 636 bytes --]

On Sun, 13 Sep 2015 02:26:42 -0300
Vicente Vera <vicentemvp@gmail.com> wrote:

> Hi,
> Just managed to define several new R packages which could be added to
> the distribution. Basically it's just r-dplyr and its dependencies
> (r-knitr, etc.).

nice

> 
> Should I send a single patch for r-dplyr, or several patches, one for
> each dependency (19)?
> 

We generally do 1 patch per package, so 19 (or so).

-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Adding new R packages
  2015-09-13  7:29 ` Efraim Flashner
@ 2015-09-13  9:42   ` Ludovic Courtès
  0 siblings, 0 replies; 3+ messages in thread
From: Ludovic Courtès @ 2015-09-13  9:42 UTC (permalink / raw)
  To: Vicente Vera; +Cc: guix-devel

Efraim Flashner <efraim@flashner.co.il> skribis:

> On Sun, 13 Sep 2015 02:26:42 -0300

[...]

>> Should I send a single patch for r-dplyr, or several patches, one for
>> each dependency (19)?
>> 
>
> We generally do 1 patch per package, so 19 (or so).

Yes; email clients can easily handle that.

Before posting them, please make sure ‘guix lint’ does not report
anything for those 20 packages.

Thanks,
Ludo’.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-09-13  9:42 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-09-13  5:26 Adding new R packages Vicente Vera
2015-09-13  7:29 ` Efraim Flashner
2015-09-13  9:42   ` Ludovic Courtès

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).