From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vicente Vera Subject: Re: [PATCH 09/19] gnu: Add r-markdown. Date: Tue, 15 Sep 2015 14:40:21 -0300 Message-ID: References: <87d1xl8deo.fsf@mdc-berlin.de> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary=001a11c17cda2a81ca051fccad1d Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:59977) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZbuDW-0000m7-6q for guix-devel@gnu.org; Tue, 15 Sep 2015 13:40:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZbuDQ-0005tQ-8i for guix-devel@gnu.org; Tue, 15 Sep 2015 13:40:30 -0400 Received: from mail-oi0-x235.google.com ([2607:f8b0:4003:c06::235]:36446) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZbuDP-0005tG-TC for guix-devel@gnu.org; Tue, 15 Sep 2015 13:40:24 -0400 Received: by oibi136 with SMTP id i136so100238985oib.3 for ; Tue, 15 Sep 2015 10:40:22 -0700 (PDT) In-Reply-To: List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Ricardo Wurmus Cc: guix-devel@gnu.org --001a11c17cda2a81ca051fccad1d Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Updated patch attached. 2015-09-14 16:59 GMT-03:00 Vicente Vera : > Hello Ricardo, > > Both the code and the comment related to the check phase were changed. > Indeed, the comment was pretty much unreadable. Hope the new one is > better. > > New patch attached. > > 2015-09-14 8:10 GMT-03:00 Ricardo Wurmus : >> >>> From 7e291c7f87498368be556941f6eb7315f94a7c74 Mon Sep 17 00:00:00 2001 >>> From: Vicente Vera Parra >>> Date: Sun, 13 Sep 2015 13:17:39 -0300 >>> Subject: [PATCH 09/19] gnu: Add r-markdown. >> >>> * gnu/packages/statistics.scm (r-markdown): New variable. >> >> [...] >> >>> + ;; Skip check phase because the tests require knitr to be >>> + ;; installed. Since it won't (markdown is a dependency of the knit= r >>> + ;; package), installation will fail. >>> + (arguments >>> + `(#:phases >>> + (modify-phases %standard-phases >>> + (delete 'check)))) >> >> Two things: 1) the comment isn=E2=80=99t very clear. =E2=80=9CSince it = won=E2=80=99t=E2=80=9D what? Maybe >> you can rephrase. 2) Instead of deleting the =E2=80=9Ccheck=E2=80=9D ph= ase just write >> >> (arguments `(#:tests? #f)) >> >>> + (propagated-inputs >>> + `(("r-mime" ,r-mime))) >>> + (home-page "https://github.com/rstudio/markdown") >>> + (synopsis "'Markdown' Rendering for R") >> >> Quoting =E2=80=9CMarkdown=E2=80=9D looks odd. How about just >> >> =E2=80=9CMarkdown rendering library for R=E2=80=9D >> >>> + (description >>> + "Provides R bindings to the 'Sundown' 'Markdown' rendering >>> +library (https://github.com/vmg/sundown). 'Markdown' is a plain-text >>> +formatting syntax that can be converted to 'XHTML' or other formats. >>> +See http://en.wikipedia.org/wiki/Markdown for more information about >>> +'Markdown'.") >> >> The quoting looks very odd. Does this mean that =E2=80=9CSundown=E2=80= =9D must be >> available at runtime in order to use the =E2=80=9Cr-markdown=E2=80=9D pa= ckage? If this >> is so, shouldn=E2=80=99t a =E2=80=9Csundown=E2=80=9D package be among th= e inputs of this >> package? >> >>> + (license license:gpl2))) >> >> This appears to be correct. The license headers of the files in the =E2= =80=9CR=E2=80=9D >> directory only explicitly mention =E2=80=9Cversion 2=E2=80=9D, there is = no =E2=80=9Cor later=E2=80=9D >> clause. I just wonder what this means for libraries using >> =E2=80=9Cr-markdown=E2=80=9D, such as =E2=80=9Cr-knitr=E2=80=9D, which a= ccording to your next patch is >> supposedly released under =E2=80=9CGPLv3+=E2=80=9D. IIUC this cannot be= the case. >> >> ~~ Ricardo --001a11c17cda2a81ca051fccad1d Content-Type: text/x-patch; charset=US-ASCII; name="0009-gnu-Add-r-markdown.patch" Content-Disposition: attachment; filename="0009-gnu-Add-r-markdown.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_ielna8b21 RnJvbSA4NmFjOTQ2YzIxNDY5MTlhZDlmNzRjZjUyMjA2MDlkYTAwOWMzMGE5IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBWaWNlbnRlIFZlcmEgUGFycmEgPHZpY2VudGVtdnBAZ21haWwu Y29tPgpEYXRlOiBUdWUsIDE1IFNlcCAyMDE1IDE0OjE4OjU4IC0wMzAwClN1YmplY3Q6IFtQQVRD SCAwOS8xOV0gZ251OiBBZGQgci1tYXJrZG93bi4KCiogZ251L3BhY2thZ2VzL3N0YXRpc3RpY3Mu c2NtIChyLW1hcmtkb3duKTogTmV3IHZhcmlhYmxlLgotLS0KIGdudS9wYWNrYWdlcy9zdGF0aXN0 aWNzLnNjbSB8IDMwICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKwogMSBmaWxlIGNoYW5n ZWQsIDMwIGluc2VydGlvbnMoKykKCmRpZmYgLS1naXQgYS9nbnUvcGFja2FnZXMvc3RhdGlzdGlj cy5zY20gYi9nbnUvcGFja2FnZXMvc3RhdGlzdGljcy5zY20KaW5kZXggYTFjMmJmZi4uNGI0ZTgz OSAxMDA2NDQKLS0tIGEvZ251L3BhY2thZ2VzL3N0YXRpc3RpY3Muc2NtCisrKyBiL2dudS9wYWNr YWdlcy9zdGF0aXN0aWNzLnNjbQpAQCAtNjgwLDMgKzY4MCwzMyBAQCB2aWEgQW5kcmUgU2ltb24n cyBoaWdobGlnaHQgcGFja2FnZSAoaHR0cDovL3d3dy5hbmRyZS1zaW1vbi5kZSkuIikKICAgICAg IlRoaXMgcGFja2FnZSBndWVzc2VzIHRoZSBNSU1FIHR5cGUgZnJvbSBhIGZpbGVuYW1lIGV4dGVu c2lvbiB1c2luZyB0aGUKIGRhdGEgZGVyaXZlZCBmcm9tIC9ldGMvbWltZS50eXBlcyBpbiBVTklY LXR5cGUgc3lzdGVtcy4iKQogICAgIChsaWNlbnNlIGxpY2Vuc2U6Z3BsMikpKQorCisoZGVmaW5l LXB1YmxpYyByLW1hcmtkb3duCisgIChwYWNrYWdlCisgICAgKG5hbWUgInItbWFya2Rvd24iKQor ICAgICh2ZXJzaW9uICIwLjcuNyIpCisgICAgKHNvdXJjZSAob3JpZ2luCisgICAgICAgICAgICAg IChtZXRob2QgdXJsLWZldGNoKQorICAgICAgICAgICAgICAodXJpIChzdHJpbmctYXBwZW5kICJt aXJyb3I6Ly9jcmFuL3NyYy9jb250cmliL21hcmtkb3duXyIKKyAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICB2ZXJzaW9uICIudGFyLmd6IikpCisgICAgICAgICAgICAgIChzaGEyNTYK KyAgICAgICAgICAgICAgIChiYXNlMzIKKyAgICAgICAgICAgICAgICAiMDBqMWhsaWIzaWw1MGF6 czJ2bGN5aGkwYmpweDFyNTBteHI5dzlkbDVnMWJ3ampjNzFoYiIpKSkpCisgICAgKGJ1aWxkLXN5 c3RlbSByLWJ1aWxkLXN5c3RlbSkKKyAgICA7OyBTa2lwIGNoZWNrIHBoYXNlIGJlY2F1c2UgdGhl IHRlc3RzIHJlcXVpcmUgdGhlIHIta25pdHIgcGFja2FnZSB0byBiZQorICAgIDs7IGluc3RhbGxl ZC4gVGhpcyBwcmV2ZW50cyBpbnN0YWxsYXRpb24gZmFpbHVyZXMuIEtuaXRyIG5vcm1hbGx5Cisg ICAgOzsgc2hvdWxkbid0IGJlIGF2YWlsYWJsZSBzaW5jZSByLW1hcmtkb3duIGlzIGEgZGVwZW5k ZW5jeSBvZiB0aGUgci1rbml0cgorICAgIDs7IHBhY2thZ2UuCisgICAgKGFyZ3VtZW50cyBgKCM6 dGVzdHM/ICNmKSkKKyAgICAocHJvcGFnYXRlZC1pbnB1dHMKKyAgICAgYCgoInItbWltZSIgLHIt bWltZSkpKQorICAgIChob21lLXBhZ2UKKyAgICAgImh0dHBzOi8vZ2l0aHViLmNvbS9yc3R1ZGlv L21hcmtkb3duIikKKyAgICAoc3lub3BzaXMKKyAgICAgIk1hcmtkb3duIHJlbmRlcmluZyBmb3Ig UiIpCisgICAgKGRlc2NyaXB0aW9uCisgICAgICJUaGlzIHBhY2thZ2UgcHJvdmlkZXMgUiBiaW5k aW5ncyB0byB0aGUgU3VuZG93biBNYXJrZG93biByZW5kZXJpbmcKK2xpYnJhcnkgKGh0dHBzOi8v Z2l0aHViLmNvbS92bWcvc3VuZG93bikuICBNYXJrZG93biBpcyBhIHBsYWluLXRleHQgZm9ybWF0 dGluZworc3ludGF4IHRoYXQgY2FuIGJlIGNvbnZlcnRlZCB0byBYSFRNTCBvciBvdGhlciBmb3Jt YXRzLiAgU2VlCitodHRwOi8vZW4ud2lraXBlZGlhLm9yZy93aWtpL01hcmtkb3duIGZvciBtb3Jl IGluZm9ybWF0aW9uIGFib3V0IE1hcmtkb3duLiIpCisgICAgKGxpY2Vuc2UgbGljZW5zZTpncGwy KSkpCi0tIAoyLjUuMgoK --001a11c17cda2a81ca051fccad1d--