From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vicente Vera Subject: Re: [PATCH 11/19] gnu: Add r-knitr. Date: Tue, 15 Sep 2015 14:41:45 -0300 Message-ID: References: <87bnd58d2l.fsf@mdc-berlin.de> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary=047d7bd904aa1f1058051fccb2f1 Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:60672) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZbuEm-0001Pe-UI for guix-devel@gnu.org; Tue, 15 Sep 2015 13:41:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZbuEl-0006ij-PX for guix-devel@gnu.org; Tue, 15 Sep 2015 13:41:48 -0400 Received: from mail-ob0-x236.google.com ([2607:f8b0:4003:c01::236]:35703) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZbuEl-0006ia-BZ for guix-devel@gnu.org; Tue, 15 Sep 2015 13:41:47 -0400 Received: by obbzf10 with SMTP id zf10so85842345obb.2 for ; Tue, 15 Sep 2015 10:41:45 -0700 (PDT) In-Reply-To: List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Ricardo Wurmus Cc: guix-devel@gnu.org --047d7bd904aa1f1058051fccb2f1 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Updated patch attached. 2015-09-14 17:06 GMT-03:00 Vicente Vera : > Hello, > > I'm not sure if it's correct, but I changed the license from gpl3+ to > gpl2+ to keep it consistent with the r-markdown package > (https://www.gnu.org/licenses/gpl-faq.html#v2v3Compatibility). Thanks > for figuring that out. > > New patch attached. > > 2015-09-14 8:17 GMT-03:00 Ricardo Wurmus : >> Hi Vicente, >> >>> From 36f94f07cba5edea4897ac36b92a73bfc6a3258b Mon Sep 17 00:00:00 2001 >>> From: Vicente Vera Parra >>> Date: Sun, 13 Sep 2015 13:20:29 -0300 >>> Subject: [PATCH 11/19] gnu: Add r-knitr. >> >>> * gnu/packages/statistics.scm (r-knitr): New variable. >> >> [...] >> >>> + (synopsis "General-Purpose Package for Dynamic Report Generation i= n R") >>> + (description >>> + "Provides a general-purpose tool for dynamic report generation in >>> +R using Literate Programming techniques.") >> >> As before, please provide a better description (at least by replacing >> =E2=80=9CProvides=E2=80=9D in the first sentence with =E2=80=9CThis pack= age provides=E2=80=9D); and use >> lower-case in the synopsis. >> >>> + (license license:gpl3+))) >> >> I don=E2=80=99t think this is correct. The package actually doesn=E2=80= =99t declare the >> version of the GPL. There are no license headers I could find and all >> it says is >> >> =E2=80=9CThis package is free and open source software, licensed und= er GPL.=E2=80=9D >> >> Furthermore, as noted before, there might be a license conflict when >> combining =E2=80=9Cr-knitr=E2=80=9D with =E2=80=9Cr-markdown=E2=80=9D, b= ecause the latter is released >> under =E2=80=9CGPLv2 only=E2=80=9D. >> >> I just asked the author about what version of the GPL was intended >> here[1]. >> >> ~~ Ricardo >> >> [1]: https://github.com/yihui/knitr/issues/566#issuecomment-140042571 --047d7bd904aa1f1058051fccb2f1 Content-Type: text/x-patch; charset=US-ASCII; name="0011-gnu-Add-r-knitr.patch" Content-Disposition: attachment; filename="0011-gnu-Add-r-knitr.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_ielnbzkg1 RnJvbSA3MzBmOGI2NDBkNzBlOTY5M2JjZTY1ZGVkNDdiYTkxZDRiNmFmMjMzIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBWaWNlbnRlIFZlcmEgUGFycmEgPHZpY2VudGVtdnBAZ21haWwu Y29tPgpEYXRlOiBUdWUsIDE1IFNlcCAyMDE1IDE0OjIwOjEzIC0wMzAwClN1YmplY3Q6IFtQQVRD SCAxMS8xOV0gZ251OiBBZGQgci1rbml0ci4KCiogZ251L3BhY2thZ2VzL3N0YXRpc3RpY3Muc2Nt IChyLWtuaXRyKTogTmV3IHZhcmlhYmxlLgotLS0KIGdudS9wYWNrYWdlcy9zdGF0aXN0aWNzLnNj bSB8IDI5ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrCiAxIGZpbGUgY2hhbmdlZCwgMjkg aW5zZXJ0aW9ucygrKQoKZGlmZiAtLWdpdCBhL2dudS9wYWNrYWdlcy9zdGF0aXN0aWNzLnNjbSBi L2dudS9wYWNrYWdlcy9zdGF0aXN0aWNzLnNjbQppbmRleCAwNTBhNTA3Li5lNWI3MWY5IDEwMDY0 NAotLS0gYS9nbnUvcGFja2FnZXMvc3RhdGlzdGljcy5zY20KKysrIGIvZ251L3BhY2thZ2VzL3N0 YXRpc3RpY3Muc2NtCkBAIC03MzEsMyArNzMxLDMyIEBAIGh0dHA6Ly9lbi53aWtpcGVkaWEub3Jn L3dpa2kvTWFya2Rvd24gZm9yIG1vcmUgaW5mb3JtYXRpb24gYWJvdXQgTWFya2Rvd24uIikKICAg ICAgIlRoaXMgcGFja2FnZSBpbXBsZW1lbnRzIHRoZSBsaWJ5YW1sIFlBTUwgMS4xIHBhcnNlciBh bmQKIGVtaXR0ZXIgKGh0dHA6Ly9weXlhbWwub3JnL3dpa2kvTGliWUFNTCkgZm9yIFIuIikKICAg ICAobGljZW5zZSBsaWNlbnNlOmJzZC0zKSkpCisKKyhkZWZpbmUtcHVibGljIHIta25pdHIKKyAg KHBhY2thZ2UKKyAgICAobmFtZSAici1rbml0ciIpCisgICAgKHZlcnNpb24gIjEuMTEiKQorICAg IChzb3VyY2UgKG9yaWdpbgorICAgICAgICAgICAgICAobWV0aG9kIHVybC1mZXRjaCkKKyAgICAg ICAgICAgICAgKHVyaSAoc3RyaW5nLWFwcGVuZCAibWlycm9yOi8vY3Jhbi9zcmMvY29udHJpYi9r bml0cl8iCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgdmVyc2lvbiAiLnRhci5n eiIpKQorICAgICAgICAgICAgICAoc2hhMjU2CisgICAgICAgICAgICAgICAoYmFzZTMyCisgICAg ICAgICAgICAgICAgIjFpa2psYTBobnBqZmtkYnlkcWhocXlwYzBhaWl6Ymk0bnluOGM2OTRzZGs5 Y2E0amFzZGQiKSkpKQorICAgIChidWlsZC1zeXN0ZW0gci1idWlsZC1zeXN0ZW0pCisgICAgKHBy b3BhZ2F0ZWQtaW5wdXRzCisgICAgIGAoKCJyLWV2YWx1YXRlIiAsci1ldmFsdWF0ZSkKKyAgICAg ICAoInItZGlnZXN0IiAsci1kaWdlc3QpCisgICAgICAgKCJyLWZvcm1hdHIiICxyLWZvcm1hdHIp CisgICAgICAgKCJyLWhpZ2hyIiAsci1oaWdocikKKyAgICAgICAoInItbWFya2Rvd24iICxyLW1h cmtkb3duKQorICAgICAgICgici1zdHJpbmdyIiAsci1zdHJpbmdyKQorICAgICAgICgici15YW1s IiAsci15YW1sKSkpCisgICAgKGhvbWUtcGFnZQorICAgICAiaHR0cDovL3lpaHVpLm5hbWUva25p dHIvIikKKyAgICAoc3lub3BzaXMKKyAgICAgIkdlbmVyYWwtcHVycG9zZSBwYWNrYWdlIGZvciBk eW5hbWljIHJlcG9ydCBnZW5lcmF0aW9uIGluIFIiKQorICAgIChkZXNjcmlwdGlvbgorICAgICAi VGhpcyBwYWNrYWdlIHByb3ZpZGVzIGEgZ2VuZXJhbC1wdXJwb3NlIHRvb2wgZm9yIGR5bmFtaWMg cmVwb3J0CitnZW5lcmF0aW9uIGluIFIgdXNpbmcgTGl0ZXJhdGUgUHJvZ3JhbW1pbmcgdGVjaG5p cXVlcy4iKQorICAgIChsaWNlbnNlIGxpY2Vuc2U6Z3BsMispKSkKLS0gCjIuNS4yCgo= --047d7bd904aa1f1058051fccb2f1--