Re: [PATCH 05/19] gnu: Add r-evaluate.

[Vicente Vera <vicentemvp@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1404 bytes --]

Hi,

Sure, once the upgraded package is available at CRAN the corresponding
changes will be added. Thank you for the heads up.

New patch attached.

2015-09-14 7:57 GMT-03:00 Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>:
>
>> * gnu/packages/statistics.scm (r-evaluate): New variable.
>
> [...]
>
>> +    (synopsis "Parsing and Evaluation Tools that Provide More Details
>> than the Default")
>
> This synopsis is a bit long (and again: please use lower case).  How
> about
>
>   “Parsing and evaluation tools for R”?
>
>> +    (description
>> +     "Parsing and evaluation tools that make it easy to recreate the
>> +command line behaviour of R.")
>
> This description is a little short.  What about using the description
> derived from the README in the repository:
>
>   “Evaluate provides tools that allow you to recreate the parsing,
>   evaluation and display of R code, with enough information that you can
>   accurately recreate what happens at the command line.  The tools can
>   easily be adapted for other output formats, such as HTML or LaTeX.”
>
>> +    (license license:gpl3+)))
>
> According to LICENSE on Github[1] this package is release under the
> “MIT” license (= Expat?) since version 0.7.3 (you packaged 0.7.2).  This
> should be noted when you prepare a new patch and decide to upgrade to
> the latest version.
>
> ~~ Ricardo

[-- Attachment #2: 0005-gnu-Add-r-evaluate.patch --]
[-- Type: text/x-patch, Size: 1721 bytes --]

From 068eccba79d8908a859c1b565a86d0677c1d823d Mon Sep 17 00:00:00 2001
From: Vicente Vera Parra <vicentemvp@gmail.com>
Date: Mon, 14 Sep 2015 14:50:31 -0300
Subject: [PATCH 05/12] gnu: Add r-evaluate.

* gnu/packages/statistics.scm (r-evaluate): New variable.
---
 gnu/packages/statistics.scm | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/gnu/packages/statistics.scm b/gnu/packages/statistics.scm
index 1efacde..e041986 100644
--- a/gnu/packages/statistics.scm
+++ b/gnu/packages/statistics.scm
@@ -576,3 +576,25 @@ for template use among CRAN packages.  By placing these libraries in this
 package, we offer a more efficient distribution system for CRAN as replication
 of this code in the sources of other packages is avoided.")
     (license license:boost1.0)))
+
+(define-public r-evaluate
+  (package
+    (name "r-evaluate")
+    (version "0.7.2")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append "mirror://cran/src/contrib/evaluate_"
+                                  version ".tar.gz"))
+              (sha256
+               (base32 "0r4jl32d817w9472l7a240w3aip5h7v0vw7byvkwqwv8gnx8r7xv"))))
+    (build-system r-build-system)
+    (propagated-inputs
+     `(("r-stringr" ,r-stringr)))
+    (home-page "https://github.com/hadley/evaluate")
+    (synopsis "Parsing and evaluation tools for R")
+    (description
+     "This package provides tools that allow you to recreate the parsing,
+evaluation and display of R code, with enough information that you can
+accurately recreate what happens at the command line.  The tools can easily be
+adapted for other output formats, such as HTML or LaTeX.")
+    (license license:gpl3+)))
-- 
2.5.2