From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tatiana Sholokhova Subject: Re: GSoC: Adding a web interface similar to the Hydra web interface Date: Wed, 4 Jul 2018 22:54:46 +0200 Message-ID: References: <87d0xyn9zs.fsf@elephly.net> <87d0xswvls.fsf@elephly.net> <87r2m4ntk4.fsf@mdc-berlin.de> <87tvqxy4i9.fsf@elephly.net> <87in78hxo2.fsf@elephly.net> <878t7xb58o.fsf@elephly.net> <874lijbqvf.fsf@elephly.net> <20180606200210.7a9c4dd6@scratchpost.org> <20180612183504.2621cefa@scratchpost.org> <8736xrd64y.fsf@elephly.net> <8736x8ype9.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000bc24c5057032a45b" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:39745) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1faonm-0001Fz-Ln for guix-devel@gnu.org; Wed, 04 Jul 2018 16:55:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1faonl-0000Dz-EJ for guix-devel@gnu.org; Wed, 04 Jul 2018 16:55:02 -0400 In-Reply-To: <8736x8ype9.fsf@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: =?UTF-8?Q?Ludovic_Court=C3=A8s?= Cc: guix-devel --000000000000bc24c5057032a45b Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi all, I just committed the code I wrote trying to improve pagination. I screwed up a bit with the new pagination. The problem I encountered is following. If we want to maintain a link to the previous page we have to filter the database table entries with to types of filters: one with lower bound on the id, and the other with the upper bound. As we do so simultaneously with limiting the query output to the maximal page size, we need to change the ordering type depending on the type of the filter. At the moment I am not sure, what it the best way to implement database query with such properties. Could you please take a look on the commit and share your ideas on that? The current implementation of pagination works correctly but it does not support link to the previous page (first, and next only). I have been trying to improve pagination for a while, and I now am thinking about starting the parallel work on the implementation of the features we listed before. What do you think about it? Best regards, Tatiana =D1=81=D1=80, 27 =D0=B8=D1=8E=D0=BD. 2018 =D0=B3. =D0=B2 21:56, Ludovic Cou= rt=C3=A8s : > Hi Tatiana, > > Tatiana Sholokhova skribis: > > > On the last week, I had fallen out of the process. I had been having > exams > > at the university since the beginning of June. The last exam was > > rescheduled and that has affected my plans. I am sorry for that. Now th= e > > semester is finished and I am having much more time to focus on our > > project. I am very happy to pass the first evaluation. It is a pleasure > for > > me to work with such a great team! > > Thank you, and thanks for letting us know. > > > In a few days, I am going to implement the whitelist for the static fil= es > > and improve pagination tool performance as we discussed before. Also, I > > intend to make the pagination tool universal and add it to the page whi= ch > > displays all builds of a selected evaluation. > > Sounds cool! I haven=E2=80=99t followed your work as closely as I was ho= ping > for, but it seems like we could merge it quickly, notably because > everyone wants these enhancements. :-) > > > Do you think it would be okay if I add auxiliary pagination filters to > > the request which retrieves builds from the database? > > Why not. Depending on the filter, We may need to add indexes to the > database (see the bottom of =E2=80=98schema.sql=E2=80=99) so that request= s aren=E2=80=99t too > slow. > > Thank you for the update! > > Ludo=E2=80=99. > --000000000000bc24c5057032a45b Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi all,

I just committed the= code I wrote trying to improve pagination. I screwed up a bit with the new= pagination.=C2=A0
The problem I encountered is following. If we = want to maintain a link to the previous page we have to filter the database= table entries with to types of filters: one with lower bound on the id, an= d the other with the upper bound. As we do so simultaneously with limiting = the query output to the maximal page size, we need to change the ordering t= ype depending on the type of the filter. At the moment I am not sure, what = it the best way to implement database query with such properties. Could you= please take a look on the commit and share your ideas on that?
<= br>
The current implementation of pagination works correctly but = it does not support link to the previous page (first, and next only).
=

I have been trying to improve pagination for a while, a= nd I now am thinking about starting the parallel work on the implementation= of the features we listed before. What do you think about it?
Best regards,
Tatiana

=D1=81=D1=80, 27 =D0=B8=D1=8E=D0=BD. 2018 =D0= =B3. =D0=B2 21:56, Ludovic Court=C3=A8s <ludo@gnu.org>:
Hi Tatiana,<= br>
Tatiana Sholokhova <tanja201396@gmail.com> skribis:

> On the last week, I had fallen out of the process. I had been having e= xams
> at the university since the beginning of June. The last exam was
> rescheduled and that has affected my plans. I am sorry for that. Now t= he
> semester is finished and I am having much more time to focus on our > project. I am very happy to pass the first evaluation. It is a pleasur= e for
> me to work with such a great team!

Thank you, and thanks for letting us know.

> In a few days, I am going to implement the whitelist for the static fi= les
> and improve pagination tool performance as we discussed before. Also, = I
> intend to make the pagination tool universal and add it to the page wh= ich
> displays all builds of a selected evaluation.

Sounds cool!=C2=A0 I haven=E2=80=99t followed your work as closely as I was= hoping
for, but it seems like we could merge it quickly, notably because
everyone wants these enhancements.=C2=A0 :-)

> Do you think it would be okay if I add auxiliary pagination filters to=
> the request which retrieves builds from the database?

Why not.=C2=A0 Depending on the filter, We may need to add indexes to the database (see the bottom of =E2=80=98schema.sql=E2=80=99) so that requests = aren=E2=80=99t too
slow.

Thank you for the update!

Ludo=E2=80=99.
--000000000000bc24c5057032a45b--