From: Amirouche Boubekki <amirouche.boubekki@gmail.com>
To: Amir P <amirpli@gmail.com>, guix-devel@gnu.org
Subject: Re: [PATCH] gnu: link-grammar: New module.
Date: Fri, 04 Nov 2016 18:13:28 +0000 [thread overview]
Message-ID: <CAL7_Mo_Fyu9a5NfSwkVMaOCyKjoiz3-FY8DdXoQRh3PUN=KLSQ@mail.gmail.com> (raw)
In-Reply-To: <CAE=djt13hsQrr_YTF7QFddkf2aCpxDMgocxNqvToc94gTEkNnw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1591 bytes --]
Thx for the review and explanation.
I am not in a hurry, I will wait for the 5.3.12 release.
On Mon, Oct 24, 2016 at 7:03 PM Amir P <amirpli@gmail.com> wrote:
> On Sun, 23 Oct 2016 17:20:11 -0400 Leo Famulari wrote:
> > If sqlite and zlib are only used when building, but not when running
> > link-grammar, then they should be native-inputs.
> >
> > Otherwise, we will need to figure out how to make link-grammar retain
> > references to these libraries.
>
> The link-grammar library doesn't use the zlib library directly or
> indirectly.
> What happens is that zlib.h is needed for the compilation of its
> sat-solver code
> because it is included in a header file of the minisat library which is
> indirectly
> included by the sat-solver code. So zlib (actually zlib.h) is only used
> when building.
>
> However, if the sqlite library+headers exist when using "configure",
> HAVE_SQLITE will get defined, which will bring in code that can use sqlite
> (sqlite3_open etc. are referenced in the result link-grammar library).
> As this code is currently not fully functional, a solution may be to
> "configure"
> link-grammar without the presence of the sqlite library+headers.
> A better solution may be to add a link-grammar "configure" option like
> "--enable-sqlite".
> If you think it is indeed better, I will open an issue there for adding it
> - to be
> included in the next version - 5.3.12.
> In any case, 5.3.12 is needed to overcome additional problems in 5.3.11
> (some
> of them are already fixed in the repository, and for some others
> pull-requests are
> still pending).
>
[-- Attachment #2: Type: text/html, Size: 3329 bytes --]
next prev parent reply other threads:[~2016-11-04 18:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-24 15:19 [PATCH] gnu: link-grammar: New module Amir P
2016-11-04 18:13 ` Amirouche Boubekki [this message]
-- strict thread matches above, loose matches on Subject: below --
2016-10-23 14:54 Amirouche Boubekki
2016-10-23 15:13 ` Catonano
2016-10-23 21:20 ` Leo Famulari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAL7_Mo_Fyu9a5NfSwkVMaOCyKjoiz3-FY8DdXoQRh3PUN=KLSQ@mail.gmail.com' \
--to=amirouche.boubekki@gmail.com \
--cc=amirpli@gmail.com \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).