unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: David Craven <david@craven.ch>
To: Alex Vong <alexvong1995@gmail.com>
Cc: guix-devel <guix-devel@gnu.org>
Subject: Re: [PATCH] gnu: vlc: Add inputs.
Date: Sat, 3 Sep 2016 18:15:48 +0200	[thread overview]
Message-ID: <CAL1_imns1O2JQWN+4DRN3BGxvzicybh6Ng5K8hJmfMJJrVnrCw@mail.gmail.com> (raw)
In-Reply-To: <87oa479bhc.fsf@gmail.com>

Hi Alex,

I'm not sure we need all those dependencies =) Can you explain what
they are for? If you are adding dependencies to vlc why did you leave
libinput-minimal off the list? ;)

> 3. Our vlc was built with fast-math disabled as explained in the
> comment. However, this is actually not necessary, vlc would built with
> '-ffast-math -fno-finite-math-only'.

This should probably be a separate patch, and will probably have a
easier path to master...

Thanks!

  reply	other threads:[~2016-09-03 16:15 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-02  4:22 [PATCH] gnu: vlc: Add inputs Alex Vong
2016-09-03 16:15 ` David Craven [this message]
2016-09-05 19:56   ` Efraim Flashner
2016-09-06 10:36     ` Alex Vong
2016-09-06 11:11       ` David Craven
2016-09-10  2:27         ` Alex Vong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAL1_imns1O2JQWN+4DRN3BGxvzicybh6Ng5K8hJmfMJJrVnrCw@mail.gmail.com \
    --to=david@craven.ch \
    --cc=alexvong1995@gmail.com \
    --cc=guix-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).