From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Craven Subject: Re: [PATCH] gnu: Add inox. Date: Wed, 11 Jan 2017 09:56:17 +0100 Message-ID: References: <20170110120856.17190-1-david@craven.ch> <20170110190214.GA31184@jasmine> <87o9ze8pqz.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:33376) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cREhi-0002eH-Gl for guix-devel@gnu.org; Wed, 11 Jan 2017 03:56:23 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cREhf-00050Y-A0 for guix-devel@gnu.org; Wed, 11 Jan 2017 03:56:22 -0500 Received: from mail-qk0-x232.google.com ([2607:f8b0:400d:c09::232]:36390) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cREhf-0004zW-4n for guix-devel@gnu.org; Wed, 11 Jan 2017 03:56:19 -0500 Received: by mail-qk0-x232.google.com with SMTP id 11so103209920qkl.3 for ; Wed, 11 Jan 2017 00:56:18 -0800 (PST) In-Reply-To: <87o9ze8pqz.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Marius Bakke Cc: guix-devel > Tell me about it! I've been secretly maintaining a Chromium branch over > at https://github.com/mbakke/guix/commits/chromium . It's frequently > rebased. Looks awesome! > One thing that worries me about Inox is that version 53 is very old and > likely contains known vulnerabilities. Do you know if they backport > fixes? If not, I think we should try to stick with upstream Chromium. This is due to me not having worked on it for a while. Inox are just a couple of patches and default configure flags, but it's still chromium. I'm not too concerned with inox, but *whisper* I got the impression that there where FSDG issues with chromium. By applying a bunch of patches and calling it inox instead of chromium, I think it could be considered a "good faith effort", and the problem avoided until someone complains. Another interesting collection of chromium patches would be: https://github.com/Eloston/ungoogled-chromium > Also, Chromium 54+ have abandoned the "gyp" build system completely in > favor of the "gn" build system. With it, many build flags don't work > properly yet. See the FIXMEs in the HEAD of the above branch :-) Good to know, thanks for the heads up! > Anyway, great work so far, hopefully we can join efforts and get this in > somehow. I'm not happy with the current build, the 3rd party stuff > should be removed in a source snippet, and some sites tend to just > "hang" infrequently, likely from one of the patches (IPv6 probe?). Sounds good! We should definitely use your package as a base...