From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Craven <david@craven.ch>
Subject: Re: [PATCH 14/24] gnu: gstreamer: Use license: prefix.
Date: Tue, 16 Aug 2016 22:29:46 +0200
Message-ID: <CAL1_imnRjN4g0h4B7+LCR=+99TsfV2rvkL-fty+6nvoT2XWyzA@mail.gmail.com>
References: <20160816183938.22794-1-david@craven.ch>
	<20160816183938.22794-14-david@craven.ch>
	<87inv0ii7o.fsf@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49901)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <david@craven.ch>) id 1bZkzj-0004bZ-F5
	for guix-devel@gnu.org; Tue, 16 Aug 2016 16:29:56 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <david@craven.ch>) id 1bZkzd-0005qx-T0
	for guix-devel@gnu.org; Tue, 16 Aug 2016 16:29:54 -0400
Received: from mail-yb0-x242.google.com ([2607:f8b0:4002:c09::242]:34093)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <david@craven.ch>) id 1bZkzc-0005qY-Lp
	for guix-devel@gnu.org; Tue, 16 Aug 2016 16:29:49 -0400
Received: by mail-yb0-x242.google.com with SMTP id g67so1801491ybi.1
	for <guix-devel@gnu.org>; Tue, 16 Aug 2016 13:29:47 -0700 (PDT)
In-Reply-To: <87inv0ii7o.fsf@gmail.com>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Alex Kost <alezost@gmail.com>
Cc: guix-devel <guix-devel@gnu.org>

> I like this patch.  However in general (a question for Guix people): is
> there a reason to use #:select for licenses?  Or would it be better to
> use #:prefix everywhere?  If the latter (my preference), I think it
> would be good to make this "#:select"=E2=86=92"#:prefix" change in a sing=
le
> patch instead of making separate patches for different modules.

I think that #:select has it's purpose. It helps increase readability when
one or two things are selected for example in bootstrap.scm.

#:use-module ((guix store) #:select (add-to-store add-text-to-store))
#:use-module ((guix derivations) #:select (derivation))
#:use-module ((guix utils) #:select (gnu-triplet->nix-system))

However when it comes to licenses it's verbose and unnecessary. I'll
amend the commit tomorrow to cover all cases where #:select is used
for importing licenses.