From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Craven Subject: Re: [PATCH 2/2] system: Add btrfs file system support. Date: Sat, 3 Dec 2016 17:21:13 +0100 Message-ID: References: <20161130183635.6513-1-david@craven.ch> <20161130183635.6513-2-david@craven.ch> <871sxpav20.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:44850) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cDD3v-0001zt-O7 for guix-devel@gnu.org; Sat, 03 Dec 2016 11:21:20 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cDD3r-00034u-PZ for guix-devel@gnu.org; Sat, 03 Dec 2016 11:21:19 -0500 Received: from mail-qt0-x243.google.com ([2607:f8b0:400d:c0d::243]:33661) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cDD3r-00034I-II for guix-devel@gnu.org; Sat, 03 Dec 2016 11:21:15 -0500 Received: by mail-qt0-x243.google.com with SMTP id n6so30981679qtd.0 for ; Sat, 03 Dec 2016 08:21:14 -0800 (PST) In-Reply-To: <871sxpav20.fsf@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: =?UTF-8?Q?Ludovic_Court=C3=A8s?= Cc: guix-devel The nice thing about having the check procedure be part of the is that it can be overridden. I'm not sure what use cases there are yet. One I can think of is that btrfs device scan is only required when using a multi-device configuration like raid. So I don't know if we want to run it by default as a %btrfs-checker or do nothing by default, and let the user add a custom file system pre-mount hook (file-system-checker) when needed. A version of Marius'es patch that works would be here: http://lists.gnu.org/archive/html/guix-devel/2016-12/msg00087.html