From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Craven <david@craven.ch>
Subject: Re: [PATCH] services: Add rngd service.
Date: Sun, 3 Jul 2016 04:21:15 +0200
Message-ID: <CAL1_immWsTXaRVTshXaWaLWUsHy58YDmOBOeTM1e83fFgUaHeg@mail.gmail.com>
References: <20160703001623.27550-1-david@craven.ch>
	<20160703014231.GA1178@jasmine>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51631)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <david@craven.ch>) id 1bJX2B-0001Xx-TA
	for guix-devel@gnu.org; Sat, 02 Jul 2016 22:21:24 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <david@craven.ch>) id 1bJX27-0004ka-6Y
	for guix-devel@gnu.org; Sat, 02 Jul 2016 22:21:22 -0400
Received: from mail-yw0-x22f.google.com ([2607:f8b0:4002:c05::22f]:34025)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <david@craven.ch>) id 1bJX25-0004kU-Vo
	for guix-devel@gnu.org; Sat, 02 Jul 2016 22:21:19 -0400
Received: by mail-yw0-x22f.google.com with SMTP id i12so16744853ywa.1
	for <guix-devel@gnu.org>; Sat, 02 Jul 2016 19:21:16 -0700 (PDT)
In-Reply-To: <20160703014231.GA1178@jasmine>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Leo Famulari <leo@famulari.name>
Cc: guix-devel@gnu.org

Thank you for reviewing my patches. I didn't get it to work with lsh
yet though :/ - need to practice my scheme skills...

On Sun, Jul 3, 2016 at 3:42 AM, Leo Famulari <leo@famulari.name> wrote:
> On Sun, Jul 03, 2016 at 02:16:23AM +0200, David Craven wrote:
>> * gnu/services/base.scm (rngd-service): New service.
>> * gnu/packages/linux.scm (rng-tools): New package.
>
> Thanks for taking this on!
>
> Can you split this into 3 separate commits? One to alphabetize the
> module imports in linux.scm, one to add rng-tools, and one to add
> rngd-service?
>
> Also, can you document the service in doc/guix.texi?
>
>> +(define-public rng-tools
>
> This package looks good to me, although I didn't try to build it yet.
>
>> --- a/gnu/services/base.scm
>> +++ b/gnu/services/base.scm
>> @@ -31,7 +31,7 @@
>>    #:use-module (gnu system mapped-devices)
>>    #:use-module (gnu packages admin)
>>    #:use-module ((gnu packages linux)
>> -                #:select (eudev kbd e2fsprogs lvm2 fuse alsa-utils crda gpm))
>> +                #:select (alsa-utils crda eudev e2fsprogs fuse gpm kbd lvm2 rng-tools))
>>    #:use-module ((gnu packages base)
>>                  #:select (canonical-package glibc))
>>    #:use-module (gnu packages package-management)
>> @@ -95,6 +95,7 @@
>>              gpm-service
>>
>>              urandom-seed-service
>> +            rngd-service
>
> I will let someone with more experience writing services review this
> part.