From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Craven <david@craven.ch>
Subject: Re: [PATCH] WIP refactor file-system-check-procedure
Date: Sat, 7 Jan 2017 17:05:11 +0100
Message-ID: <CAL1_imkYhha=jwxx0_Umo4nNjsqm+e-7sVs1Fz7Dvge=h+sEsQ@mail.gmail.com>
References: <20170107155454.9645-1-david@craven.ch>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58938)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <david@craven.ch>) id 1cPtUc-0002H7-Ow
	for guix-devel@gnu.org; Sat, 07 Jan 2017 11:05:19 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <david@craven.ch>) id 1cPtUX-0006V7-S7
	for guix-devel@gnu.org; Sat, 07 Jan 2017 11:05:18 -0500
Received: from mail-qk0-x242.google.com ([2607:f8b0:400d:c09::242]:36624)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <david@craven.ch>) id 1cPtUX-0006Tb-OD
	for guix-devel@gnu.org; Sat, 07 Jan 2017 11:05:13 -0500
Received: by mail-qk0-x242.google.com with SMTP id a20so13593279qkc.3
	for <guix-devel@gnu.org>; Sat, 07 Jan 2017 08:05:12 -0800 (PST)
In-Reply-To: <20170107155454.9645-1-david@craven.ch>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: guix-devel <guix-devel@gnu.org>

Hi!

It doesn't quite work yet, but wanted to know if you think that moving
checking the file systems outside the mounting procedure to be a good
idea or not.

Alternatively I could try moving all of the file-system-checking to
the build side, but I wanted to use gexps so that we can avoid this:
-  `(,@(if (find (lambda (fs)
-                    (string-prefix? "ext" (file-system-type fs)))
-                  file-systems)
-            (list e2fsck/static)
-            '())
-      ,@(if (find (lambda (fs)
-                    (string-suffix? "fat" (file-system-type fs)))
-                  file-systems)
-            (list fatfsck/static)
-            '())

David