From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Craven <david@craven.ch>
Subject: Re: [PATCH 3/3] gnu: Add openocd.
Date: Wed, 26 Oct 2016 14:49:00 +0200
Message-ID: <CAL1_imkRRzbvZ7ykQszDP7x9YdjriuAZOg8iE50Bj84z9P6SaA@mail.gmail.com>
References: <20161025132615.20705-1-theodoros.for@openmailbox.org>
	<20161025132615.20705-4-theodoros.for@openmailbox.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33552)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <david@craven.ch>) id 1bzNdi-0002Nl-8t
	for guix-devel@gnu.org; Wed, 26 Oct 2016 08:49:10 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <david@craven.ch>) id 1bzNdd-000704-Q3
	for guix-devel@gnu.org; Wed, 26 Oct 2016 08:49:06 -0400
Received: from mail-qk0-x242.google.com ([2607:f8b0:400d:c09::242]:34602)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <david@craven.ch>) id 1bzNdd-0006zg-Lf
	for guix-devel@gnu.org; Wed, 26 Oct 2016 08:49:01 -0400
Received: by mail-qk0-x242.google.com with SMTP id n189so360276qke.1
	for <guix-devel@gnu.org>; Wed, 26 Oct 2016 05:49:01 -0700 (PDT)
In-Reply-To: <20161025132615.20705-4-theodoros.for@openmailbox.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Theodoros Foradis <theodoros.for@openmailbox.org>
Cc: guix-devel <guix-devel@gnu.org>

Hi Theodoros,

Do we really need this patch? Is there a reason why it hasn't been
upstreamed yet?

(add-before 'configure 'bootstrap
+             (lambda _
+               (system* "aclocal")
+               (system* "libtoolize" "--automake" "--copy")
+               (system* "autoconf")
+               (system* "autoheader")
+               (system* "automake" "--gnu" "--add-missing" "--copy")
+               #t))

Why not (add-before 'configure 'autoreconf
(lambda _
  (zero? (system* "autoreconf" "-vfi"))

I prefer indenting like this as is done in most of the codebase:

+      (inputs
          `(("libusb" ,libusb)
+          ("libusb-compat" ,libusb-compat)
+          ("libftdi" ,libftdi)
+          ("hidapi" ,hidapi)))
+      (native-inputs
          `(("autoconf" ,autoconf)
+          ("libtool" ,libtool)
+          ("automake" ,automake)
+          ("pkg-config" ,pkg-config)))

It would also be nice if the inputs where ordered alphabetically.

Thanks for the patch, looking good!! You don't need to resubmit
(unless someone else has more objections :).

David