From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Craven <david@craven.ch>
Subject: Re: [PATCH 03/13] gnu: pinentry-qt: Fix regression.
Date: Mon, 22 Aug 2016 00:37:45 +0200
Message-ID: <CAL1_im=xwVKsVxAiOytxm0RdOw6-=cRvrNCGOUdaKLawcE+WpA@mail.gmail.com>
References: <20160820215957.GA6502@jasmine>
	<20160821140825.13048-1-david@craven.ch>
	<20160821140825.13048-3-david@craven.ch> <87vaytc1xz.fsf@netris.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46731)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <david@craven.ch>) id 1bbbNI-0000en-OW
	for guix-devel@gnu.org; Sun, 21 Aug 2016 18:37:53 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <david@craven.ch>) id 1bbbNE-0005MZ-GP
	for guix-devel@gnu.org; Sun, 21 Aug 2016 18:37:51 -0400
Received: from mail-yw0-x241.google.com ([2607:f8b0:4002:c05::241]:35311)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <david@craven.ch>) id 1bbbND-0005MU-94
	for guix-devel@gnu.org; Sun, 21 Aug 2016 18:37:48 -0400
Received: by mail-yw0-x241.google.com with SMTP id r9so2953764ywg.2
	for <guix-devel@gnu.org>; Sun, 21 Aug 2016 15:37:45 -0700 (PDT)
In-Reply-To: <87vaytc1xz.fsf@netris.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Mark H Weaver <mhw@netris.org>
Cc: guix-devel <guix-devel@gnu.org>

I removed gettext and added

(arguments
  `(#:configure-flags '("CXXFLAGS=-std=gnu++11")))

instead. I don't know why adding gettext as a native-input fixed the
build failure.

On Sun, Aug 21, 2016 at 10:16 PM, Mark H Weaver <mhw@netris.org> wrote:
> David Craven <david@craven.ch> writes:
>
>> * gnu/packages/gnupg.scm (pinentry-qt)[native-inputs]: Add gnu-gettext.
>
> The summary line should say "Add gnu-gettext to native-inputs" instead
> of "Fix regression".
>
>> ---
>>  gnu/packages/gnupg.scm | 3 +++
>>  1 file changed, 3 insertions(+)
>>
>> diff --git a/gnu/packages/gnupg.scm b/gnu/packages/gnupg.scm
>> index 7df96b4..fde6018 100644
>> --- a/gnu/packages/gnupg.scm
>> +++ b/gnu/packages/gnupg.scm
>> @@ -28,6 +28,7 @@
>>    #:use-module (gnu packages)
>>    #:use-module (gnu packages adns)
>>    #:use-module (gnu packages curl)
>> +  #:use-module (gnu packages gettext)
>>    #:use-module (gnu packages openldap)
>>    #:use-module (gnu packages perl)
>>    #:use-module (gnu packages pth)
>> @@ -642,6 +643,8 @@ passphrase when @code{gpg} or @code{gpg2} is run and needs it.")))
>>    (package
>>      (inherit pinentry-tty)
>>      (name "pinentry-qt")
>> +    (native-inputs
>> +     `(("gettext" ,gnu-gettext)))
>
> It would be good to understand why this is needed, because it shouldn't
> be needed for a tarball release.  Can you add a comment explaining the
> reason, possibly with "FIXME" in it?
>
>      Thanks,
>        Mark