From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Craven Subject: Re: [PATCH 13/16] gnu: Add python-nose2. Date: Sun, 11 Sep 2016 21:39:48 +0200 Message-ID: References: <20160911185857.2123-1-efraim@flashner.co.il> <20160911185857.2123-14-efraim@flashner.co.il> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:58182) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bjAca-00036z-KQ for guix-devel@gnu.org; Sun, 11 Sep 2016 15:40:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bjAcW-0005cv-FJ for guix-devel@gnu.org; Sun, 11 Sep 2016 15:40:55 -0400 Received: from mail-yw0-f195.google.com ([209.85.161.195]:33343) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bjAcV-0005cT-8I for guix-devel@gnu.org; Sun, 11 Sep 2016 15:40:52 -0400 Received: by mail-yw0-f195.google.com with SMTP id g192so4745528ywh.0 for ; Sun, 11 Sep 2016 12:40:50 -0700 (PDT) In-Reply-To: <20160911185857.2123-14-efraim@flashner.co.il> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Efraim Flashner Cc: guix-devel > + (arguments `(#:tests? #f)) ; 'module' object has no attribute 'collector' > + (native-inputs > + `(("python-setuptools" ,python-setuptools))) > + (inputs > + `(("python-cov-core" ,python-cov-core) > + ("python-pytest-cov" ,python-pytest-cov) > + ("python-six" ,python-six))) nitpick: arguments below inputs. same as with other patch otherwise LGTM