From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Craven Subject: Re: [PATCH 2/2] system: Add btrfs file system support. Date: Fri, 2 Dec 2016 17:27:24 +0100 Message-ID: References: <20161130183635.6513-1-david@craven.ch> <20161130183635.6513-2-david@craven.ch> <87zikfsbk3.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> <87zikeposs.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:40963) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cCqgM-0003bD-FK for guix-devel@gnu.org; Fri, 02 Dec 2016 11:27:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cCqgI-0008Hj-Hb for guix-devel@gnu.org; Fri, 02 Dec 2016 11:27:30 -0500 Received: from mail-qk0-x241.google.com ([2607:f8b0:400d:c09::241]:36173) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cCqgI-0008HO-9q for guix-devel@gnu.org; Fri, 02 Dec 2016 11:27:26 -0500 Received: by mail-qk0-x241.google.com with SMTP id h201so31089537qke.3 for ; Fri, 02 Dec 2016 08:27:26 -0800 (PST) In-Reply-To: <87zikeposs.fsf@gmail.com> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Chris Marusich Cc: guix-devel > How to handle the return codes. This isn't a problem, the check-procedure can normalize the return codes. The confusing thing is this part: (else #~(system* (string-append "fsck." type) device) The default behavior should be to emit a warning to stderr and do nothing. I don't think this produces anything useful for any file system... > I've also wondered about this. I'm not sure how long each test takes to > run, so an analysis of the tests to find their slow areas might help > guide us. I noticed that the system tests in general are fast. It's only the installer tests that take so long.