From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Craven Subject: Re: [PATCH 06/96] gnu: ocaml: Use a helper function to download from ocaml-forge. Date: Wed, 4 Jan 2017 14:38:48 +0100 Message-ID: References: <20170103191217.6431-1-julien@lepiller.eu> <20170103191217.6431-7-julien@lepiller.eu> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:53977) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cOlmI-0003gE-ER for guix-devel@gnu.org; Wed, 04 Jan 2017 08:38:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cOlmD-0003mt-Jh for guix-devel@gnu.org; Wed, 04 Jan 2017 08:38:54 -0500 Received: from mail-qt0-x242.google.com ([2607:f8b0:400d:c0d::242]:33200) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cOlmD-0003md-Eq for guix-devel@gnu.org; Wed, 04 Jan 2017 08:38:49 -0500 Received: by mail-qt0-x242.google.com with SMTP id w39so654184qtw.0 for ; Wed, 04 Jan 2017 05:38:49 -0800 (PST) In-Reply-To: <20170103191217.6431-7-julien@lepiller.eu> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Julien Lepiller Cc: guix-devel + (ocaml-forge-origin name version 1627 + "0cyj6sfdvzx8hw7553lhgwc0krlgvlza0ph3dk9gsxy047dm3wib")) I changed this to be ocaml-forge-uri. There are multiple reasons why I think it's a better idea: * if one ever writes an ocaml updater then it can use the existing code to update the hash. * the hash is checked at compile time to be a correct base32 hash (when running make). This is because base32 is implemented as a syntax rule. * it's consistent with what other packages do.